Uploader\Adapters\Upload

Complexity

Total Complexity

10

Size/Duplication

Total Lines	44
Duplicated Lines	27.27 %

Coupling/Cohesion

Components	0
Dependencies	1

Importance

Changes	5
Bugs	1	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	check()	0	4	2
A	fixDestination()	12	12	3
B	save()	0	14	5

<?php

namespace Uploader\Adapters;

use Uploader\Uploader;

/**
 * Adapter to save a file from upload ($_FILES).
 */
class Upload implements AdapterInterface
{
    /**
     * {@inheritdoc}
     */
    public static function check($original)
    {
        return is_array($original) && isset($original['tmp_name']);
    }

    /**
     * {@inheritdoc}
     */
    public static function fixDestination(Uploader $uploader, $original)

This method seems to be duplicated in your project.

    {
        $path = Uploader::parsePath($original['name']);

        if (!$uploader->getFilename()) {

The expression $uploader->getFilename() of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.

            $uploader->setFilename($path['filename']);
        }

        if (!$uploader->getExtension()) {
            $uploader->setExtension($path['extension']);
        }
    }

    /**
     * {@inheritdoc}
     */
    public static function save($original, $destination)
    {
        if (empty($original['tmp_name']) || !empty($original['error'])) {
            throw new \RuntimeException('Unable to copy the uploaded file because has an error');
        }

        $moved = php_sapi_name() == 'cli' ? rename($original['tmp_name'], $destination) : move_uploaded_file($original['tmp_name'], $destination);

        if (!$moved) {
            throw new \RuntimeException("Unable to copy '{$original['tmp_name']}' to '{$destination}'");
        }

        chmod($destination, 0755);
    }
}