This method seems to be duplicated in your project.
Duplicated code is one of the most pungent code smells. If you need to duplicate
the same code in three or more different places, we strongly encourage you to
look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.
It seems like parse_url($original, PHP_URL_PATH) targeting parse_url() can also be of type false; however, Uploader\Uploader::parsePath() does only seem to accept string, did you maybe forget to handle an error condition?
The expression $uploader->getFilename() of type null|string is loosely compared to false; this is ambiguous if the string can be empty. You might want to explicitly use === null instead.
In PHP, under loose comparison (like ==, or !=, or switch conditions),
values of different types might be equal.
For string values, the empty string '' is a special case, in particular
the following results might be unexpected:
''==false// true''==null// true'ab'==false// false'ab'==null// false// It is often better to use strict comparison''===false// false''===null// false
Loading history...
28
$uploader->setFilename($path['filename']);
29
}
30
31
if (!$uploader->getExtension()) {
32
$uploader->setExtension($path['extension']);
33
}
34
}
35
36
/**
37
* {@inheritdoc}
38
*/
39
public static function save($original, $destination)
40
{
41
if (!@rename($original['tmp_name'], $destination)) {
42
throw new \RuntimeException("Unable to copy '{$original['tmp_name']}' to '{$destination}'");
oscarotero /
uploader
Loading history...
Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.
You can also find more detailed suggestions in the “Code” section of your repository.