Select::__construct() - Code Metrics - Inspection of "format fields" - oscarotero/simple-crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 89e667...0da900 )

by Oscar

created 2019-03-31 18:51 UTC

Select::__construct() A

↳ Parent: Select

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	22
rs	9.568
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php
declare(strict_types = 1);

namespace SimpleCrud\Query;

use Closure;
use PDO;
use SimpleCrud\Events\CreateSelectQuery;
use SimpleCrud\Table;

final class Select implements QueryInterface
{
    use Traits\Common;
    use Traits\HasRelatedWith;
    use Traits\HasPagination;
    use Traits\HasJoinRelation;

    private $one;
    private $allowedMethods = [
        'from',
        'join',
        'catJoin',
        'groupBy',
        'having',
        'orHaving',
        'orderBy',
        'catHaving',
        'where',
        'orWhere',
        'catWhere',
        'limit',
        'offset',
        'distinct',
        'forUpdate',
        'setFlag',
    ];

    public function __construct(Table $table)
    {
        $this->table = $table;

        $fields = array_map(
            function ($field) {
                return (string) $field;
            },
            array_values($table->getFields())
        );

        $this->query = $table->getDatabase()
            ->select()
            ->from((string) $table)
            ->columns(...$fields);

        $eventDispatcher = $table->getEventDispatcher();

        if ($eventDispatcher) {
            $eventDispatcher->dispatch(new CreateSelectQuery($this));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        }
    }

    public function one(): self
    {
        $this->one = true;
        $this->query->limit(1);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $this;
    }

    public function run()
    {
        $statement = $this->__invoke();
        $statement->setFetchMode(PDO::FETCH_ASSOC);

        if ($this->one) {
            $data = $statement->fetch();

            return $data ? $this->table->create($this->formatRow($data)) : null;
        }

        $data = array_map(Closure::fromCallable([$this, 'formatRow']), $statement->fetchAll());

        return $this->table->createCollection($data);
    }

    private function formatRow(array $data): array
    {
        foreach ($data as $fieldName => &$value) {
            $value = $this->table->{$fieldName}->format($value);
        }

        return $data;
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace SimpleCrud\Query;
5
6			use Closure;
7			use PDO;
8			use SimpleCrud\Events\CreateSelectQuery;
9			use SimpleCrud\Table;
10
11			final class Select implements QueryInterface
12			{
13			use Traits\Common;
14			use Traits\HasRelatedWith;
15			use Traits\HasPagination;
16			use Traits\HasJoinRelation;
17
18			private $one;
19			private $allowedMethods = [
20			'from',
21			'join',
22			'catJoin',
23			'groupBy',
24			'having',
25			'orHaving',
26			'orderBy',
27			'catHaving',
28			'where',
29			'orWhere',
30			'catWhere',
31			'limit',
32			'offset',
33			'distinct',
34			'forUpdate',
35			'setFlag',
36			];
37
38			public function __construct(Table $table)
39			{
40			$this->table = $table;
41
42			$fields = array_map(
43			function ($field) {
44			return (string) $field;
45			},
46			array_values($table->getFields())
47			);
48
49			$this->query = $table->getDatabase()
50			->select()
51			->from((string) $table)
52			->columns(...$fields);
53
54			$eventDispatcher = $table->getEventDispatcher();
55
56			if ($eventDispatcher) {
57			$eventDispatcher->dispatch(new CreateSelectQuery($this));
			0 ignored issues – show Documentation introduced 2019-03-30 00:32 UTC by Report Bug Copy Issue Report `new \SimpleCrud\Events\CreateSelectQuery($this)` is of type `object<SimpleCrud\Events\CreateSelectQuery>`, but the function expects a `object<Psr\EventDispatcher\object>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
58			}
59			}
60
61			public function one(): self
62			{
63			$this->one = true;
64			$this->query->limit(1);
			0 ignored issues – show Bug introduced 2018-09-27 20:28 UTC by Report Bug Copy Issue Report The method `limit` does only exist in `Atlas\Query\Delete and A... and Atlas\Query\Update`, but not in `Atlas\Query\Insert`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
65
66			return $this;
67			}
68
69			public function run()
70			{
71			$statement = $this->__invoke();
72			$statement->setFetchMode(PDO::FETCH_ASSOC);
73
74			if ($this->one) {
75			$data = $statement->fetch();
76
77			return $data ? $this->table->create($this->formatRow($data)) : null;
78			}
79
80			$data = array_map(Closure::fromCallable([$this, 'formatRow']), $statement->fetchAll());
81
82			return $this->table->createCollection($data);
83			}
84
85			private function formatRow(array $data): array
86			{
87			foreach ($data as $fieldName => &$value) {
88			$value = $this->table->{$fieldName}->format($value);
89			}
90
91			return $data;
92			}
93			}
94

oscarotero / simple-crud

Push — master ( 89e667...0da900 )

Select::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like