Select::run() - Code Metrics - Inspection of "allow to add extra columns in select queries" - oscarotero/simple-crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 45b64e...037c01 )

by Oscar

created 2019-04-02 22:50 UTC

Select::run() A

↳ Parent: Select

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	17
rs	9.7
c	0
b	0
f	0
cc	3
nc	3
nop	0

<?php
declare(strict_types = 1);

namespace SimpleCrud\Query;

use Closure;
use PDO;
use SimpleCrud\Table;
use SimpleCrud\Row;

final class Select implements QueryInterface
{
    use Traits\Common;
    use Traits\HasRelatedWith;
    use Traits\HasPagination;
    use Traits\HasJoinRelation;

    private $one;
    private $allowedMethods = [
        'from',
        'columns',
        'join',
        'catJoin',
        'groupBy',
        'having',
        'orHaving',
        'orderBy',
        'catHaving',
        'where',
        'orWhere',
        'catWhere',
        'limit',
        'offset',
        'distinct',
        'forUpdate',
        'setFlag',
    ];

    public function __construct(Table $table)
    {
        $this->table = $table;

        $this->query = $table->getDatabase()
            ->select()
            ->from((string) $table);

        foreach ($table->getFields() as $field) {
            $field->select($this->query);
        }
    }

    public function one(): self
    {
        $this->one = true;
        $this->query->limit(1);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $this;
    }

    public function run()
    {
        $statement = $this->__invoke();
        $statement->setFetchMode(PDO::FETCH_ASSOC);

        $dataFields = [];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        if ($this->one) {
            $data = $statement->fetch();

            return $data ? $this->createRow($data) : null;
        }

        $rows = array_map(Closure::fromCallable([$this, 'createRow']), $statement->fetchAll());

        return $this->table->createCollection($rows);
    }

    private function createRow(array $data): Row
    {
        $values = [];
        $extraData = [];
        $fields = $this->table->getFields();

        foreach ($data as $name => $value) {
            if (isset($fields[$name])) {
                $values[$name] = $fields[$name]->format($value);
            } else {
                $extraData[$name] = $value;
            }
        }

        return $this->table->create($values)->setData($extraData);
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace SimpleCrud\Query;
5
6			use Closure;
7			use PDO;
8			use SimpleCrud\Table;
9			use SimpleCrud\Row;
10
11			final class Select implements QueryInterface
12			{
13			use Traits\Common;
14			use Traits\HasRelatedWith;
15			use Traits\HasPagination;
16			use Traits\HasJoinRelation;
17
18			private $one;
19			private $allowedMethods = [
20			'from',
21			'columns',
22			'join',
23			'catJoin',
24			'groupBy',
25			'having',
26			'orHaving',
27			'orderBy',
28			'catHaving',
29			'where',
30			'orWhere',
31			'catWhere',
32			'limit',
33			'offset',
34			'distinct',
35			'forUpdate',
36			'setFlag',
37			];
38
39			public function __construct(Table $table)
40			{
41			$this->table = $table;
42
43			$this->query = $table->getDatabase()
44			->select()
45			->from((string) $table);
46
47			foreach ($table->getFields() as $field) {
48			$field->select($this->query);
49			}
50			}
51
52			public function one(): self
53			{
54			$this->one = true;
55			$this->query->limit(1);
			0 ignored issues – show Bug introduced 2018-09-27 20:28 UTC by Report Bug Copy Issue Report The method `limit` does only exist in `Atlas\Query\Delete and A... and Atlas\Query\Update`, but not in `Atlas\Query\Insert`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
56
57			return $this;
58			}
59
60			public function run()
61			{
62			$statement = $this->__invoke();
63			$statement->setFetchMode(PDO::FETCH_ASSOC);
64
65			$dataFields = [];
			0 ignored issues – show Unused Code introduced 2019-04-02 22:51 UTC by Report Bug Copy Issue Report `$dataFields` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
66
67			if ($this->one) {
68			$data = $statement->fetch();
69
70			return $data ? $this->createRow($data) : null;
71			}
72
73			$rows = array_map(Closure::fromCallable([$this, 'createRow']), $statement->fetchAll());
74
75			return $this->table->createCollection($rows);
76			}
77
78			private function createRow(array $data): Row
79			{
80			$values = [];
81			$extraData = [];
82			$fields = $this->table->getFields();
83
84			foreach ($data as $name => $value) {
85			if (isset($fields[$name])) {
86			$values[$name] = $fields[$name]->format($value);
87			} else {
88			$extraData[$name] = $value;
89			}
90			}
91
92			return $this->table->create($values)->setData($extraData);
93			}
94			}
95

oscarotero / simple-crud

Push — master ( 45b64e...037c01 )

Select::run() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like