Select::createRow() - Code Metrics - Inspection of "code style" - oscarotero/simple-crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 037c01...3910ea )

by Oscar

created 2019-04-02 23:15 UTC

Select::createRow() A

↳ Parent: Select

Complexity

Conditions	3
Paths	3

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	16
rs	9.7333
c	0
b	0
f	0
cc	3
nc	3
nop	1

<?php
declare(strict_types = 1);

namespace SimpleCrud\Queries;

use Closure;
use PDO;
use SimpleCrud\Row;
use SimpleCrud\Table;

final class Select extends Query
{
    use Traits\HasRelatedWith;
    use Traits\HasPagination;
    use Traits\HasJoinRelation;

    private $one;
    protected const ALLOWED_METHODS = [
        'from',
        'columns',
        'join',
        'catJoin',
        'groupBy',
        'having',
        'orHaving',
        'orderBy',
        'catHaving',
        'where',
        'orWhere',
        'catWhere',
        'limit',
        'offset',
        'distinct',
        'forUpdate',
        'setFlag',
    ];

    public function __construct(Table $table)
    {
        $this->table = $table;

        $this->query = $table->getDatabase()
            ->select()
            ->from((string) $table);

        foreach ($table->getFields() as $field) {
            $field->select($this->query);
        }
    }

    public function one(): self
    {
        $this->one = true;
        $this->query->limit(1);
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

        return $this;
    }

    public function run()
    {
        $statement = $this->__invoke();
        $statement->setFetchMode(PDO::FETCH_ASSOC);

        if ($this->one) {
            $data = $statement->fetch();

            return $data ? $this->createRow($data) : null;
        }

        $rows = array_map(Closure::fromCallable([$this, 'createRow']), $statement->fetchAll());

        return $this->table->createCollection($rows);
    }

    private function createRow(array $data): Row
    {
        $values = [];
        $extraData = [];
        $fields = $this->table->getFields();

        foreach ($data as $name => $value) {
            if (isset($fields[$name])) {
                $values[$name] = $fields[$name]->format($value);
            } else {
                $extraData[$name] = $value;
            }
        }

        return $this->table->create($values)->setData($extraData);
    }
}


1			<?php
2			declare(strict_types = 1);
3
4			namespace SimpleCrud\Queries;
5
6			use Closure;
7			use PDO;
8			use SimpleCrud\Row;
9			use SimpleCrud\Table;
10
11			final class Select extends Query
12			{
13			use Traits\HasRelatedWith;
14			use Traits\HasPagination;
15			use Traits\HasJoinRelation;
16
17			private $one;
18			protected const ALLOWED_METHODS = [
19			'from',
20			'columns',
21			'join',
22			'catJoin',
23			'groupBy',
24			'having',
25			'orHaving',
26			'orderBy',
27			'catHaving',
28			'where',
29			'orWhere',
30			'catWhere',
31			'limit',
32			'offset',
33			'distinct',
34			'forUpdate',
35			'setFlag',
36			];
37
38			public function __construct(Table $table)
39			{
40			$this->table = $table;
41
42			$this->query = $table->getDatabase()
43			->select()
44			->from((string) $table);
45
46			foreach ($table->getFields() as $field) {
47			$field->select($this->query);
48			}
49			}
50
51			public function one(): self
52			{
53			$this->one = true;
54			$this->query->limit(1);
			0 ignored issues – show Bug introduced 2018-09-27 20:28 UTC by Report Bug Copy Issue Report The method `limit` does only exist in `Atlas\Query\Delete and A... and Atlas\Query\Update`, but not in `Atlas\Query\Insert`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
55
56			return $this;
57			}
58
59			public function run()
60			{
61			$statement = $this->__invoke();
62			$statement->setFetchMode(PDO::FETCH_ASSOC);
63
64			if ($this->one) {
65			$data = $statement->fetch();
66
67			return $data ? $this->createRow($data) : null;
68			}
69
70			$rows = array_map(Closure::fromCallable([$this, 'createRow']), $statement->fetchAll());
71
72			return $this->table->createCollection($rows);
73			}
74
75			private function createRow(array $data): Row
76			{
77			$values = [];
78			$extraData = [];
79			$fields = $this->table->getFields();
80
81			foreach ($data as $name => $value) {
82			if (isset($fields[$name])) {
83			$values[$name] = $fields[$name]->format($value);
84			} else {
85			$extraData[$name] = $value;
86			}
87			}
88
89			return $this->table->create($values)->setData($extraData);
90			}
91			}
92

oscarotero / simple-crud

Push — master ( 037c01...3910ea )

Select::createRow() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like