HasJoinRelation - Code Metrics - Inspection of "code style" - oscarotero/simple-crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 037c01...3910ea )

by Oscar

created 2019-04-02 23:15 UTC

HasJoinRelation A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	49
Duplicated Lines	20.41 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

Metric	Value
wmc	4
lcom	1
cbo	1
dl	10
loc	49
rs	10
c	0
b	0
f	0

1 Method

Rating	Name	Duplication	Size	Complexity
A	joinRelation()	10	46	4

How to fix Duplicated Code

<?php
declare(strict_types = 1);

namespace SimpleCrud\Queries\Traits;

use RuntimeException;
use SimpleCrud\Table;

trait HasJoinRelation
{
    public function joinRelation(Table $table2): self
    {
        $table1 = $this->table;
class MyClass { }

$x = new MyClass();
$x->foo = true;

        //Has One
        if ($field = $table1->getJoinField($table2)) {
            $this->query
class MyClass { }

$x = new MyClass();
$x->foo = true;
                ->join(
                    'LEFT',
                    (string) $table2,
                    sprintf('%s = %s', $field, $table2->id)
                );

        //Has many
        } elseif ($field = $table2->getJoinField($table1)) {

            $this->query
                ->join(
                    'LEFT',
                    (string) $table2,
                    sprintf('%s = %s', $field, $table1->id)
                );

        //Has many to many
        } elseif ($joinTable = $table1->getJoinTable($table2)) {
            $field1 = $joinTable->getJoinField($table1);
            $field2 = $joinTable->getJoinField($table2);

            $this->query
                ->join(
                    'LEFT',
                    (string) $joinTable,
                    sprintf('%s = %s', $field1, $table1->id)
                )
                ->join(
                    'LEFT',
                    (string) $table2,
                    sprintf('%s = %s', $field2, $table2->id)
                );
        } else {
            throw new RuntimeException(
                sprintf('The tables %s and %s are not related', $table1, $table2)
            );
        }

        return $this;
    }
}


1		<?php
2		declare(strict_types = 1);
3
4		namespace SimpleCrud\Queries\Traits;
5
6		use RuntimeException;
7		use SimpleCrud\Table;
8
9		trait HasJoinRelation
10		{
11		public function joinRelation(Table $table2): self
12		{
13		$table1 = $this->table;
		0 ignored issues – show Bug introduced 2018-09-27 20:28 UTC by Report Bug Copy Issue Report The property `table` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
14
15		//Has One
16		if ($field = $table1->getJoinField($table2)) {
17		$this->query
		0 ignored issues – show Bug introduced 2019-03-30 00:32 UTC by Report Bug Copy Issue Report The property `query` does not exist. Did you maybe forget to declare it? In PHP it is possible to write to properties without declaring them. For example, the following is perfectly valid PHP code: class MyClass { } $x = new MyClass(); $x->foo = true; Generally, it is a good practice to explictly declare properties to avoid accidental typos and provide IDE auto-completion: class MyClass { public $foo; } $x = new MyClass(); $x->foo = true; Loading history...
18		->join(
19		'LEFT',
20		(string) $table2,
21		sprintf('%s = %s', $field, $table2->id)
22		);
23
24		//Has many
25	View Code Duplication	} elseif ($field = $table2->getJoinField($table1)) {
		0 ignored issues – show Duplication introduced 2018-09-27 20:28 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
26		$this->query
27		->join(
28		'LEFT',
29		(string) $table2,
30		sprintf('%s = %s', $field, $table1->id)
31		);
32
33		//Has many to many
34		} elseif ($joinTable = $table1->getJoinTable($table2)) {
35		$field1 = $joinTable->getJoinField($table1);
36		$field2 = $joinTable->getJoinField($table2);
37
38		$this->query
39		->join(
40		'LEFT',
41		(string) $joinTable,
42		sprintf('%s = %s', $field1, $table1->id)
43		)
44		->join(
45		'LEFT',
46		(string) $table2,
47		sprintf('%s = %s', $field2, $table2->id)
48		);
49		} else {
50		throw new RuntimeException(
51		sprintf('The tables %s and %s are not related', $table1, $table2)
52		);
53		}
54
55		return $this;
56		}
57		}
58

oscarotero / simple-crud

Push — master ( 037c01...3910ea )

HasJoinRelation A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like