AggregationTrait::__toString() - Code Metrics - Inspection of "fix hardcoded typecast to (int) for SUM() and add..." - oscarotero/simple-crud - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#22)

unknown

created 2017-11-25 21:26 UTC

AggregationTrait::__toString() A

↳ Parent: AggregationTrait

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	6

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	6
nc	1
nop	0

<?php

namespace SimpleCrud\Queries\Mysql;

use PDO;

/**
 * Trait with common funcions used in aggregation queries (min,max,avg,count,sum).
 *
 * @property \SimpleCrud\Table $table
 */
trait AggregationTrait
{
    use ExtendedSelectionTrait;
    protected $field;

    /**
     * Set the field name to sum over.
     *
     * @param string $field
     *
     * @return self
     */
    public function field($field)
    {
        $this->field = $field;

        return $this;
    }

    /**
     * Run the query and return the value.
     * 
     * @return int
     */
    public function run()
    {
        $result = $this->__invoke()->fetch();
        $field = $this->table->{$this->field};
        
        return $field->dataFromDatabase($result[0]);
    }

    /**
     * {@inheritdoc}
     */
    public function __invoke()
    {
        $statement = $this->table->getDatabase()->execute((string) $this, $this->marks);
        $statement->setFetchMode(PDO::FETCH_NUM);

        return $statement;
    }

    /**
     * Build and return the query.
     *
     * @return string
     */
    public function __toString()
    {
        $query = "SELECT ".self::AGGREGATION_FUNCTION."(`{$this->field}`) FROM `{$this->table->getName()}`";

        $query .= $this->fromToString();
        $query .= $this->whereToString();
        $query .= $this->limitToString();

        return $query;
    }
}


1		<?php
2
3		namespace SimpleCrud\Queries\Mysql;
4
5		use PDO;
6
7		/**
8		* Trait with common funcions used in aggregation queries (min,max,avg,count,sum).
9		*
10		* @property \SimpleCrud\Table $table
11		*/
12		trait AggregationTrait
13		{
14		use ExtendedSelectionTrait;
15		protected $field;
16
17		/**
18		* Set the field name to sum over.
19		*
20		* @param string $field
21		*
22		* @return self
23		*/
24		public function field($field)
25		{
26		$this->field = $field;
27
28		return $this;
29		}
30
31		/**
32		* Run the query and return the value.
33		*
34		* @return int
35		*/
36		public function run()
37		{
38		$result = $this->__invoke()->fetch();
39		$field = $this->table->{$this->field};
40
41		return $field->dataFromDatabase($result[0]);
42		}
43
44		/**
45		* {@inheritdoc}
46		*/
47	View Code Duplication	public function __invoke()
48		{
49		$statement = $this->table->getDatabase()->execute((string) $this, $this->marks);
50		$statement->setFetchMode(PDO::FETCH_NUM);
51
52		return $statement;
53		}
54
55		/**
56		* Build and return the query.
57		*
58		* @return string
59		*/
60	View Code Duplication	public function __toString()
61		{
62		$query = "SELECT ".self::AGGREGATION_FUNCTION."(`{$this->field}`) FROM `{$this->table->getName()}`";
63
64		$query .= $this->fromToString();
65		$query .= $this->whereToString();
66		$query .= $this->limitToString();
67
68		return $query;
69		}
70		}
71

oscarotero / simple-crud

Pull Request — master (#22)

AggregationTrait::__toString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like