AppTest::testServerRequest() - Code Metrics - oscarotero/psr7-unitesting - Measure and Improve Code Quality continuously with Scrutinizer

AppTest::testServerRequest() A
last analyzed 2016-05-28 16:45 UTC

↳ Parent: AppTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	51
Code Lines	46

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	1

Metric	Value
c	2
b	1
f	1
dl	0
loc	51
rs	9.4109
cc	1
eloc	46
nc	1
nop	0

How to fix Long Method

<?php

use Zend\Diactoros\ServerRequest;
use Zend\Diactoros\Response;
use Zend\Diactoros\Uri;
use Zend\Diactoros\UploadedFile;
use Zend\Diactoros\Stream;
use Psr7Unitesting\Assert;

class AppTest extends PHPUnit_Framework_TestCase
namespace YourVendor;

class YourClass { }
{
    public function testServerRequest()
    {
        $request = (new ServerRequest(['DOCUMENT_ROOT' => '/www']))
            ->withMethod('GET')
            ->withUri(new Uri('http://user:[email protected]/?ola#id'))
            ->withQueryParams(['ola' => 'value'])
            ->withAttribute('bar', 'foo')
            ->withCookieParams(['cookie-name' => 'cookie-value'])
            ->withParsedBody(['name' => 'value'])
            ->withUploadedFiles([
                'file' => new UploadedFile('file.jpg', 50, 0, 'file.jpg', 'image/jpg'),
            ])
            ->withBody(new Stream('php://temp', 'r'))
            ->withHeader('Content-Type', 'text/html');

        Assert::create($request)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
            ->protocolVersion('1.1')
            ->header('Content-Type', 'text/html')
            ->hasHeader('Content-Type')
            ->hasNotHeader('X-Content-Type')
            ->requestTarget('/?ola')
            ->uri('http://user:[email protected]/?ola#id')
            ->method('GET')
            ->attribute('bar', 'foo')
            ->hasAttribute('bar')
            ->hasParsedBody('name')
            ->parsedBody('name', 'value')
            ->hasUploadedFile('file')
            ->hasQueryParam('ola')
            ->queryParam('ola', 'value')
            ->cookieParam('cookie-name', 'cookie-value')
            ->hasCookieParam('cookie-name')
            ->hasServerParam('DOCUMENT_ROOT')
            ->serverParam('DOCUMENT_ROOT', '/www')
            ->assertUri()
                ->scheme('http')
                ->authority('user:[email protected]')
                ->host('dag.gal')
                ->query('ola')
                ->fragment('id')
                ->path('/')
                ->userInfo('user:pass')
                ->port(null)
                ->end()

            ->assertBody()
                ->isNotWritable()
                ->isReadable()
                ->isSeekable()
                ->size(0);
    }

    public function testResponse()
    {
        $response = (new Response())
            ->withHeader('Content-Type', 'text/html')
            ->withStatus(200, 'Ok!');

        $response->getBody()->write(<<<HTML
<!DOCTYPE html>
<html>
    <head>
        <title>Hello world</title>
    </head>
    <body>
        <h1>Ola mundo</h1>
        <div class="first">Ola mundo</div>
        <div class="second">Ola mundo</div>
    </body>
</html>
HTML
);

    Assert::create($response)
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
        ->protocolVersion('1.1')
        ->header('Content-Type', 'text/html')
        ->hasHeader('Content-Type')
        ->hasNotHeader('X-Content-Type')
        ->statusCode(200)
        ->reasonPhrase('Ok!')
        ->assertBody()
            ->isWritable()
            ->isReadable()
            ->isSeekable()
            ->size(225)
            ->assertHtml()
                ->count('div', 2)
                ->has('h1')
                ->hasNot('section')
                ->contains('h1', 'mundo')
                ->notContains('h1', 'mundor');
    }
}


AppTest::testServerRequest() A
last analyzed 2016-05-28 16:45 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

1			<?php
2
3			use Zend\Diactoros\ServerRequest;
4			use Zend\Diactoros\Response;
5			use Zend\Diactoros\Uri;
6			use Zend\Diactoros\UploadedFile;
7			use Zend\Diactoros\Stream;
8			use Psr7Unitesting\Assert;
9
10			class AppTest extends PHPUnit_Framework_TestCase
			0 ignored issues – show Coding Style Compatibility introduced 2016-05-28 12:53 UTC by Report Bug Copy Issue Report PSR1 recommends that each class must be in a namespace of at least one level to avoid collisions. You can fix this by adding a namespace to your class: namespace YourVendor; class YourClass { } When choosing a vendor namespace, try to pick something that is not too generic to avoid conflicts with other libraries. Loading history...
11			{
12			public function testServerRequest()
13			{
14			$request = (new ServerRequest(['DOCUMENT_ROOT' => '/www']))
15			->withMethod('GET')
16			->withUri(new Uri('http://user:[email protected]/?ola#id'))
17			->withQueryParams(['ola' => 'value'])
18			->withAttribute('bar', 'foo')
19			->withCookieParams(['cookie-name' => 'cookie-value'])
20			->withParsedBody(['name' => 'value'])
21			->withUploadedFiles([
22			'file' => new UploadedFile('file.jpg', 50, 0, 'file.jpg', 'image/jpg'),
23			])
24			->withBody(new Stream('php://temp', 'r'))
25			->withHeader('Content-Type', 'text/html');
26
27			Assert::create($request)
			0 ignored issues – show Bug introduced 2016-05-28 12:53 UTC by Report Bug Copy Issue Report The method `protocolVersion` does only exist in `Psr7Unitesting\Request and Psr7Unitesting\Response`, but not in `Psr7Unitesting\Stream and Psr7Unitesting\Uri`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
28			->protocolVersion('1.1')
29			->header('Content-Type', 'text/html')
30			->hasHeader('Content-Type')
31			->hasNotHeader('X-Content-Type')
32			->requestTarget('/?ola')
33			->uri('http://user:[email protected]/?ola#id')
34			->method('GET')
35			->attribute('bar', 'foo')
36			->hasAttribute('bar')
37			->hasParsedBody('name')
38			->parsedBody('name', 'value')
39			->hasUploadedFile('file')
40			->hasQueryParam('ola')
41			->queryParam('ola', 'value')
42			->cookieParam('cookie-name', 'cookie-value')
43			->hasCookieParam('cookie-name')
44			->hasServerParam('DOCUMENT_ROOT')
45			->serverParam('DOCUMENT_ROOT', '/www')
46			->assertUri()
47			->scheme('http')
48			->authority('user:[email protected]')
49			->host('dag.gal')
50			->query('ola')
51			->fragment('id')
52			->path('/')
53			->userInfo('user:pass')
54			->port(null)
55			->end()
56
57			->assertBody()
58			->isNotWritable()
59			->isReadable()
60			->isSeekable()
61			->size(0);
62			}
63
64			public function testResponse()
65			{
66			$response = (new Response())
67			->withHeader('Content-Type', 'text/html')
68			->withStatus(200, 'Ok!');
69
70			$response->getBody()->write(<<<HTML
71			<!DOCTYPE html>
72			<html>
73			<head>
74			<title>Hello world</title>
75			</head>
76			<body>
77			<h1>Ola mundo</h1>
78			<div class="first">Ola mundo</div>
79			<div class="second">Ola mundo</div>
80			</body>
81			</html>
82			HTML
83			);
84
85			Assert::create($response)
			0 ignored issues – show Bug introduced 2016-05-28 12:53 UTC by Report Bug Copy Issue Report The method `protocolVersion` does only exist in `Psr7Unitesting\Request and Psr7Unitesting\Response`, but not in `Psr7Unitesting\Stream and Psr7Unitesting\Uri`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
86			->protocolVersion('1.1')
87			->header('Content-Type', 'text/html')
88			->hasHeader('Content-Type')
89			->hasNotHeader('X-Content-Type')
90			->statusCode(200)
91			->reasonPhrase('Ok!')
92			->assertBody()
93			->isWritable()
94			->isReadable()
95			->isSeekable()
96			->size(225)
97			->assertHtml()
98			->count('div', 2)
99			->has('h1')
100			->hasNot('section')
101			->contains('h1', 'mundo')
102			->notContains('h1', 'mundor');
103			}
104			}
105

oscarotero / psr7-unitesting

AppTest::testServerRequest() A last analyzed 2016-05-28 16:45 UTC

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like

AppTest::testServerRequest() A
last analyzed 2016-05-28 16:45 UTC