FormTrait::insertIntoPostForms() - Code Metrics - Inspection of "changes in imageTransformer" - oscarotero/psr7-middlewares - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 7dba56...6875ae )

by Oscar

created 2015-12-17 11:11 UTC

FormTrait::insertIntoPostForms() A

↳ Parent: FormTrait

Complexity

Conditions	2
Paths	2

Size

Total Lines	23
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	23
rs	9.0857
cc	2
eloc	14
nc	2
nop	2

<?php

namespace Psr7Middlewares\Utils;

use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;
use Psr7Middlewares\Middleware;

/**
 * Utilities used by middlewares that manipulates forms.
 */
trait FormTrait
{
    /**
     * Insert content into all POST forms.
     * 
     * @param ResponseInterface $response
     * @param string            $input
     * 
     * @return ResponseInterface
     */
    private function insertIntoPostForms(ResponseInterface $response, $input)
    {
        $html = (string) $response->getBody();

        $html = preg_replace_callback(
            '/(<form\s[^>]*method=["\']?POST["\']?[^>]*>)/i',
            function ($match) use ($input) {
                return $match[0].$input;
            },
            $html,
            -1,
            $count
        );

        if ($count) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $body = Middleware::createStream();
            $body->write($html);

            return $response->withBody($body);
        }

        return $response;
    }

    /**
     * Check whether the request is post (or any similar method).
     * 
     * @param RequestInterface $request
     * 
     * @return bool
     */
    private function isPost(RequestInterface $request)
    {
        switch (strtoupper($request->getMethod())) {
            case 'GET':
            case 'HEAD':
            case 'CONNECT':
            case 'TRACE':
            case 'OPTIONS':
                return false;
        }

        return true;
    }
}


1			<?php
2
3			namespace Psr7Middlewares\Utils;
4
5			use Psr\Http\Message\RequestInterface;
6			use Psr\Http\Message\ResponseInterface;
7			use Psr7Middlewares\Middleware;
8
9			/**
10			* Utilities used by middlewares that manipulates forms.
11			*/
12			trait FormTrait
13			{
14			/**
15			* Insert content into all POST forms.
16			*
17			* @param ResponseInterface $response
18			* @param string $input
19			*
20			* @return ResponseInterface
21			*/
22			private function insertIntoPostForms(ResponseInterface $response, $input)
23			{
24			$html = (string) $response->getBody();
25
26			$html = preg_replace_callback(
27			'/(<form\s[^>]method=["\']?POST["\']?[^>]>)/i',
28			function ($match) use ($input) {
29			return $match[0].$input;
30			},
31			$html,
32			-1,
33			$count
34			);
35
36			if ($count) {
			0 ignored issues – show Bug Best Practice introduced 2015-11-28 18:25 UTC by Report Bug Copy Issue Report The expression `$count` of type `integer\|null` is loosely compared to `true`; this is ambiguous if the integer can be zero. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
37			$body = Middleware::createStream();
38			$body->write($html);
39
40			return $response->withBody($body);
41			}
42
43			return $response;
44			}
45
46			/**
47			* Check whether the request is post (or any similar method).
48			*
49			* @param RequestInterface $request
50			*
51			* @return bool
52			*/
53			private function isPost(RequestInterface $request)
54			{
55			switch (strtoupper($request->getMethod())) {
56			case 'GET':
57			case 'HEAD':
58			case 'CONNECT':
59			case 'TRACE':
60			case 'OPTIONS':
61			return false;
62			}
63
64			return true;
65			}
66			}
67

oscarotero / psr7-middlewares

Push — master ( 7dba56...6875ae )

FormTrait::insertIntoPostForms() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like