CallableTrait - Code Metrics - Inspection of "silenced decrypt errors" - oscarotero/psr7-middlewares - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 206c33...9e77c2 )

by Oscar

created 2015-11-28 18:20 UTC

CallableTrait B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	82
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
wmc	47
c	2
b	1
f	0
lcom	1
cbo	3
dl	0
loc	82
rs	8.439

2 Methods

Rating	Name	Duplication	Size	Complexity
B	executeCallable()	0	30	6
B	getCallable()	0	27	6

How to fix Complexity

<?php

namespace Psr7Middlewares\Utils;

use RuntimeException;
use Psr\Http\Message\RequestInterface;
use Psr\Http\Message\ResponseInterface;

/**
 * Utilities used by middlewares with callables.
 */
trait CallableTrait
{
    use ArgumentsTrait;

    /**
     * Execute the callable.
     *
     * @param mixed             $target
     * @param RequestInterface  $request
     * @param ResponseInterface $response
     *
     * @return ResponseInterface
     */
    protected function executeCallable($target, RequestInterface $request, ResponseInterface $response)
    {
        try {
            ob_start();

            $arguments = array_merge([$request, $response], $this->arguments);
            $target = static::getCallable($target, $arguments);
            $return = call_user_func_array($target, $arguments);

            if ($return instanceof ResponseInterface) {
                $response = $return;
                $return = '';
            }

            $return = ob_get_contents().$return;
            $body = $response->getBody();

            if ($return !== '' && $body->isWritable()) {
                $body->write($return);
            }

            return $response;
        } catch (\Exception $exception) {
            throw $exception;
        } finally {
            if (ob_get_level() > 0) {
                ob_end_clean();
            }
        }
    }

    /**
     * Resolves the target of the route and returns a callable.
     *
     * @param mixed $target
     * @param array $construct_args
     *
     * @throws RuntimeException If the target is not callable
     *
     * @return callable
     */
    protected static function getCallable($target, array $construct_args)
    {
        //if it's callable as is
        if (is_callable($target)) {
            return $target;
        }

        if (is_string($target)) {
            //is a class "classname::method"
            if (strpos($target, '::') === false) {
                $class = $target;
                $method = '__invoke';
            } else {
                list($class, $method) = explode('::', $target, 2);
            }

            if (!class_exists($class)) {
                throw new RuntimeException("The class {$class} does not exists");
            }

            $class = new \ReflectionClass($class);
            $instance = $class->hasMethod('__construct') ? $class->newInstanceArgs($construct_args) : $class->newInstance();
            $target = [$instance, $method];
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        }

        throw new RuntimeException('The route target is not callable');
    }
}


1			<?php
2
3			namespace Psr7Middlewares\Utils;
4
5			use RuntimeException;
6			use Psr\Http\Message\RequestInterface;
7			use Psr\Http\Message\ResponseInterface;
8
9			/**
10			* Utilities used by middlewares with callables.
11			*/
12			trait CallableTrait
13			{
14			use ArgumentsTrait;
15
16			/**
17			* Execute the callable.
18			*
19			* @param mixed $target
20			* @param RequestInterface $request
21			* @param ResponseInterface $response
22			*
23			* @return ResponseInterface
24			*/
25			protected function executeCallable($target, RequestInterface $request, ResponseInterface $response)
26			{
27			try {
28			ob_start();
29
30			$arguments = array_merge([$request, $response], $this->arguments);
31			$target = static::getCallable($target, $arguments);
32			$return = call_user_func_array($target, $arguments);
33
34			if ($return instanceof ResponseInterface) {
35			$response = $return;
36			$return = '';
37			}
38
39			$return = ob_get_contents().$return;
40			$body = $response->getBody();
41
42			if ($return !== '' && $body->isWritable()) {
43			$body->write($return);
44			}
45
46			return $response;
47			} catch (\Exception $exception) {
48			throw $exception;
49			} finally {
50			if (ob_get_level() > 0) {
51			ob_end_clean();
52			}
53			}
54			}
55
56			/**
57			* Resolves the target of the route and returns a callable.
58			*
59			* @param mixed $target
60			* @param array $construct_args
61			*
62			* @throws RuntimeException If the target is not callable
63			*
64			* @return callable
65			*/
66			protected static function getCallable($target, array $construct_args)
67			{
68			//if it's callable as is
69			if (is_callable($target)) {
70			return $target;
71			}
72
73			if (is_string($target)) {
74			//is a class "classname::method"
75			if (strpos($target, '::') === false) {
76			$class = $target;
77			$method = '__invoke';
78			} else {
79			list($class, $method) = explode('::', $target, 2);
80			}
81
82			if (!class_exists($class)) {
83			throw new RuntimeException("The class {$class} does not exists");
84			}
85
86			$class = new \ReflectionClass($class);
87			$instance = $class->hasMethod('__construct') ? $class->newInstanceArgs($construct_args) : $class->newInstance();
88			$target = [$instance, $method];
			0 ignored issues – show Unused Code introduced 2015-11-28 18:25 UTC by Report Bug Copy Issue Report `$target` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
89			}
90
91			throw new RuntimeException('The route target is not callable');
92			}
93			}
94

oscarotero / psr7-middlewares

Push — master ( 206c33...9e77c2 )

CallableTrait B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

2 Methods

How to fix Complexity

Complex Class

Duplication Side-by-Side

Filter issues like