Dimmensions::getResizeDimmensions() - Code Metrics - Inspection of "removed Dimmentsions::getPercentageValue method be..." - oscarotero/imagecow - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d7d63e...f91d06 )

by Oscar

created 2016-05-12 10:57 UTC

Dimmensions::getResizeDimmensions() C

↳ Parent: Dimmensions

Complexity

Conditions	14
Paths	12

Size

Total Lines	41
Code Lines	22

Duplication

Lines	24
Ratio	58.54 %

Importance

Changes	4
Bugs	2	Features	0

Metric	Value
c	4
b	2
f	0
dl	24
loc	41
rs	5.0864
cc	14
eloc	22
nc	12
nop	5

How to fix Complexity

<?php

namespace Imagecow\Utils;

use Imagecow\ImageException;

/**
 * Usefull dimmensions calculations.
 */
class Dimmensions
{
    protected static $positionsKeywordsX = [
        'left' => '0%',
        'center' => '50%',
        'right' => '100%',
    ];

    protected static $positionsKeywordsY = [
        'top' => '0%',
        'middle' => '50%',
        'bottom' => '100%',
    ];

    /**
     * Calculate the dimensions of a resize.
     *
     * @param int  $oldWidth
     * @param int  $oldHeight
     * @param int  $newWidth
     * @param int  $newHeight
     * @param bool $cover
     *
     * @return array [width, height]
     */
    public static function getResizeDimmensions($oldWidth, $oldHeight, $newWidth, $newHeight, $cover = false)
    {
        if (empty($newHeight)) {

            return [(int) $newWidth, (int) ceil(($newWidth / $oldWidth) * $oldHeight)];
        }

        if (empty($newWidth)) {

            return [(int) ceil(($newHeight / $oldHeight) * $oldWidth), (int) $newHeight];
        }

        $scaleWidth = $newWidth / $oldWidth;
        $scaleHeight = $newHeight / $oldHeight;

        if ($cover) {
            if ($scaleWidth > $scaleHeight) {

                return [(int) $newWidth, (int) ceil($scaleWidth * $oldHeight)];
            }

            if ($scaleWidth < $scaleHeight) {

                return [(int) ceil($scaleHeight * $oldWidth), (int) $newHeight];
            }
        } else {
            if ($scaleWidth < $scaleHeight) {

                return [(int) $newWidth, (int) ceil($scaleWidth * $oldHeight)];
            }

            if ($scaleWidth > $scaleHeight) {

                return [(int) ceil($scaleHeight * $oldWidth), (int) $newHeight];
            }
        }

        if ($scaleWidth < $scaleHeight || ($cover && $scaleWidth > $scaleHeight)) {

            return [(int) $newWidth, (int) ceil($scaleWidth * $oldHeight)];
        }

        if ($scaleWidth > $scaleHeight || ($cover && $scaleWidth < $scaleHeight)) {

            return [(int) ceil($scaleHeight * $oldWidth), (int) $newHeight];
        }

        return [(int) $newWidth, (int) $newHeight];
    }

    /**
     * Calculate a dimension value.
     *
     * @param string     $direction
     * @param int|string $value
     * @param int        $relatedValue
     * @param bool       $position
     *
     * @return int
     */
    public static function getIntegerValue($direction, $value, $relatedValue, $position = false)
    {
        $keywords = ($direction === 'y') ? static::$positionsKeywordsY : static::$positionsKeywordsX;

        if ($position && isset($keywords[$value])) {
            $value = $keywords[$value];
        }

        if (substr($value, -1) === '%') {
            return intval(($relatedValue / 100) * floatval(substr($value, 0, -1)));
        }

        return intval($value);
    }

    /**
     * Calculates the x/y position.
     *
     * @param string          $direction (y or x)
     * @param string|int|null $position
     * @param int             $newValue
     * @param int             $oldValue
     *
     * @return int
     */
    public static function getPositionValue($direction, $position, $newValue, $oldValue)
    {
        $split = explode(' ', $position, 2);
        $position = $split[0];
        $offset = isset($split[1]) ? (int) $split[1] : 0;

        if (is_numeric($position)) {
            return intval($position) + $offset;
        }

        $newCenter = static::getIntegerValue($direction, $position, $newValue, true);
        $oldCenter = static::getIntegerValue($direction, $position, $oldValue, true);

        return $oldCenter - $newCenter + $offset;
    }
}


1		<?php
2
3		namespace Imagecow\Utils;
4
5		use Imagecow\ImageException;
6
7		/**
8		* Usefull dimmensions calculations.
9		*/
10		class Dimmensions
11		{
12		protected static $positionsKeywordsX = [
13		'left' => '0%',
14		'center' => '50%',
15		'right' => '100%',
16		];
17
18		protected static $positionsKeywordsY = [
19		'top' => '0%',
20		'middle' => '50%',
21		'bottom' => '100%',
22		];
23
24		/**
25		* Calculate the dimensions of a resize.
26		*
27		* @param int $oldWidth
28		* @param int $oldHeight
29		* @param int $newWidth
30		* @param int $newHeight
31		* @param bool $cover
32		*
33		* @return array [width, height]
34		*/
35		public static function getResizeDimmensions($oldWidth, $oldHeight, $newWidth, $newHeight, $cover = false)
36		{
37	View Code Duplication	if (empty($newHeight)) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		return [(int) $newWidth, (int) ceil(($newWidth / $oldWidth) * $oldHeight)];
39		}
40
41	View Code Duplication	if (empty($newWidth)) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
42		return [(int) ceil(($newHeight / $oldHeight) * $oldWidth), (int) $newHeight];
43		}
44
45		$scaleWidth = $newWidth / $oldWidth;
46		$scaleHeight = $newHeight / $oldHeight;
47
48		if ($cover) {
49	View Code Duplication	if ($scaleWidth > $scaleHeight) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
50		return [(int) $newWidth, (int) ceil($scaleWidth * $oldHeight)];
51		}
52
53	View Code Duplication	if ($scaleWidth < $scaleHeight) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
54		return [(int) ceil($scaleHeight * $oldWidth), (int) $newHeight];
55		}
56		} else {
57	View Code Duplication	if ($scaleWidth < $scaleHeight) {
		0 ignored issues – show Duplication introduced 2016-05-12 10:59 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
58		return [(int) $newWidth, (int) ceil($scaleWidth * $oldHeight)];
59		}
60
61	View Code Duplication	if ($scaleWidth > $scaleHeight) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
62		return [(int) ceil($scaleHeight * $oldWidth), (int) $newHeight];
63		}
64		}
65
66	View Code Duplication	if ($scaleWidth < $scaleHeight \|\| ($cover && $scaleWidth > $scaleHeight)) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
67		return [(int) $newWidth, (int) ceil($scaleWidth * $oldHeight)];
68		}
69
70	View Code Duplication	if ($scaleWidth > $scaleHeight \|\| ($cover && $scaleWidth < $scaleHeight)) {
		0 ignored issues – show Duplication introduced 2016-01-19 13:39 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
71		return [(int) ceil($scaleHeight * $oldWidth), (int) $newHeight];
72		}
73
74		return [(int) $newWidth, (int) $newHeight];
75		}
76
77		/**
78		* Calculate a dimension value.
79		*
80		* @param string $direction
81		* @param int\|string $value
82		* @param int $relatedValue
83		* @param bool $position
84		*
85		* @return int
86		*/
87		public static function getIntegerValue($direction, $value, $relatedValue, $position = false)
88		{
89		$keywords = ($direction === 'y') ? static::$positionsKeywordsY : static::$positionsKeywordsX;
90
91		if ($position && isset($keywords[$value])) {
92		$value = $keywords[$value];
93		}
94
95		if (substr($value, -1) === '%') {
96		return intval(($relatedValue / 100) * floatval(substr($value, 0, -1)));
97		}
98
99		return intval($value);
100		}
101
102		/**
103		* Calculates the x/y position.
104		*
105		* @param string $direction (y or x)
106		* @param string\|int\|null $position
107		* @param int $newValue
108		* @param int $oldValue
109		*
110		* @return int
111		*/
112		public static function getPositionValue($direction, $position, $newValue, $oldValue)
113		{
114		$split = explode(' ', $position, 2);
115		$position = $split[0];
116		$offset = isset($split[1]) ? (int) $split[1] : 0;
117
118		if (is_numeric($position)) {
119		return intval($position) + $offset;
120		}
121
122		$newCenter = static::getIntegerValue($direction, $position, $newValue, true);
123		$oldCenter = static::getIntegerValue($direction, $position, $oldValue, true);
124
125		return $oldCenter - $newCenter + $offset;
126		}
127		}
128

oscarotero / imagecow

Push — master ( d7d63e...f91d06 )

Dimmensions::getResizeDimmensions() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like