Folk\Controllers\Entity

Complexity

Total Complexity

20

Size/Duplication

Total Lines	181
Duplicated Lines	10.5 %

Coupling/Cohesion

Components	0
Dependencies	3

Importance

Changes	6
Bugs	1	Features	1

4 Methods

Rating	Name	Duplication	Size	Complexity
D	listItems()	0	74	13
B	createItem()	11	32	3
B	editItem()	8	43	3
A	deleteItem()	0	10	1

<?php

namespace Folk\Controllers;

use Psr7Middlewares\Middleware\FormatNegotiator;
use Zend\Diactoros\Response\RedirectResponse;
use FormManager\Builder as F;
use Folk\SearchQuery;

class Entity
{
    protected $entity;

    /**
     * GET: List/search items.
     */
    public function listItems($request, $response, $app)

The parameter $response is not used and could be removed.

    {
        $entity = $app->getEntity($request->getAttribute('entity'));
        $search = new SearchQuery($request->getQueryParams());

        if ($search->getPage() === null) {
            $search->setPage(1);
        }

        //Check whether the query is an id
        if (($id = $search->getId())) {
            if ($items = $entity->read($id)) {
                $items = [$id => $items];
            } else {
                $items = [];
            }
        } else {
            $items = $entity->search($search);
        }

        //Return as json (for ajax calls)

39% of this comment could be valid code. Did you maybe forget this after debugging?

        if (FormatNegotiator::getFormat($request) === 'json') {
            $json = [];

            foreach ($items as $id => $item) {
                $json[$id] = $entity->getLabel($id, $item);
            }

            return json_encode($json);
        }

        //Redirect to edit element if it's only one result
        if (!empty($search->getQuery()) && count($items) === 1) {
            return new RedirectResponse($app->getRouteUrl('edit', [
                'entity' => $entity->getName(),
                'id' => key($items),
            ]));
        }

        //Load the values
        $row = $entity->getScheme($app['builder']);

        //Remove non-listable elements
        $removedKeys = [];

        foreach ($row as $key => $value) {
            if ($value->get('list') === false) {
                $removedKeys[] = $key;
            }
        }

        foreach ($removedKeys as $key) {
            unset($row[$key]);
        }

        //populate the data
        $rows = [];

        foreach ($items as $id => &$item) {
            $rows[$id] = clone $row;
            $rows[$id]->val($item);
        }

        if (count($items) === 50) {
            $search->setPage($search->getPage() + 1);
        }

        //List all results
        return $app['templates']->render('pages/list', [
            'rows' => $rows,
            'entity' => $entity,
            'search' => $search,
        ]);
    }

    /**
     * POST: Create a new element
     * GET:  Display the form.
     */
    public function createItem($request, $response, $app)

The parameter $response is not used and could be removed.

    {
        $entity = $app->getEntity($request->getAttribute('entity'));

        //Create form
        $form = F::form()
            ->method('post')
            ->enctype('multipart/form-data');

        $form->add([
            'entity' => F::hidden()->val($entity->getName())->class('field-data-entity'),
            'data' => $entity->getScheme($app['builder']),
        ]);

        //Save
        if ($request->getMethod() === 'POST') {

This code seems to be duplicated across your project.

            //Load data
            $form->loadFromPsr7($request);

            if ($form->isValid()) {
                return new RedirectResponse($app->getRouteUrl('edit', [
                    'entity' => $entity->getName(),
                    'id' => $entity->create($form['data']->val()),
                ]));
            }
        }

        return $app['templates']->render('pages/create', [
            'entity' => $entity,
            'form' => $form,
        ]);
    }

    /**
     * POST: Edit an element
     * GET:  Display the form.
     */
    public function editItem($request, $response, $app)

The parameter $response is not used and could be removed.

    {
        $entity = $app->getEntity($request->getAttribute('entity'));
        $id = $request->getAttribute('id');

        //Create form
        $form = F::form()
            ->method('post')
            ->enctype('multipart/form-data');

        $form->add([
            'id' => F::hidden()->val($id)->class('field-data-id'),
            'entity' => F::hidden()->val($entity->getName())->class('field-data-entity'),
            'data' => $entity->getScheme($app['builder']),
        ]);

        //Save
        if ($request->getMethod() === 'POST') {
            //Load data
            $form->loadFromPsr7($request);

            if ($form->isValid()) {

This code seems to be duplicated across your project.

                $entity->update($id, $form['data']->val());

                return new RedirectResponse($app->getRouteUrl('edit', [
                    'entity' => $entity->getName(),
                    'id' => $id,
                ]));
            }
        } else {
            //View
            $data = $entity->read($id);

            $form['data']->val($data);
        }

        //Render template
        return $app['templates']->render('pages/edit', [
            'entity' => $entity,
            'form' => $form,
            'id' => $id,
        ]);
    }

    /**
     * POST: Delete the element.
     */
    public function deleteItem($request, $response, $app)

The parameter $response is not used and could be removed.

    {
        $entity = $app->getEntity($request->getAttribute('entity'));

        $entity->delete($request->getAttribute('id'));

        return new RedirectResponse($app->getRouteUrl('list', [
            'entity' => $entity->getName(),
        ]));
    }
}