Completed
Push — master ( 84d676...607d64 )
by Oscar
04:24
created

Formats::getExtensions()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 3
Code Lines 2

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 3
rs 10
c 0
b 0
f 0
cc 1
eloc 2
nc 1
nop 0
1
<?php
2
3
namespace Folk\Providers;
4
5
use Fol\App;
6
use Interop\Container\ServiceProviderInterface;
7
use Folk\Formats\FormatFactory;
8
9
class Formats implements ServiceProviderInterface
10
{
11
    public function getFactories()
12
    {
13
        return [
0 ignored issues
show
Bug Best Practice introduced by
The return type of return array('builder' =...ormatFactory($app); }); (array<string,Closure>) is incompatible with the return type declared by the interface Interop\Container\Servic...Interface::getFactories of type callable[].

If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design.

Let’s take a look at an example:

class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}

Our function my_function expects a Post object, and outputs the author of the post. The base class Post returns a simple string and outputting a simple string will work just fine. However, the child class BlogPost which is a sub-type of Post instead decided to return an object, and is therefore violating the SOLID principles. If a BlogPost were passed to my_function, PHP would not complain, but ultimately fail when executing the strtoupper call in its body.

Loading history...
14
        	'builder' => function (App $app): FormatFactory {
15
            	return new FormatFactory($app);
0 ignored issues
show
Compatibility introduced by
$app of type object<Fol\App> is not a sub-type of object<Folk\Admin>. It seems like you assume a child class of the class Fol\App to be always present.

This check looks for parameters that are defined as one type in their type hint or doc comment but seem to be used as a narrower type, i.e an implementation of an interface or a subclass.

Consider changing the type of the parameter or doing an instanceof check before assuming your parameter is of the expected type.

Loading history...
16
        	}
17
        ];
18
    }
19
20
    public function getExtensions() {
21
    	return [];
22
    }
23
}
24