PhpFunctionsScanner::getFunctions() - Code Metrics - Inspection of "Add test for some PHP special chars" - oscarotero/Gettext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#91)

by Michele

created 2016-02-16 16:06 UTC

PhpFunctionsScanner::getFunctions() D

↳ Parent: PhpFunctionsScanner

Complexity

Conditions	10
Paths	6

Size

Total Lines	45
Code Lines	27

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	45
rs	4.8196
cc	10
eloc	27
nc	6
nop	0

How to fix Complexity

<?php

namespace Gettext\Utils;

class PhpFunctionsScanner extends FunctionsScanner
{
    protected $tokens;

    /**
     * Constructor.
     *
     * @param string $code The php code to scan
     */
    public function __construct($code)
    {
        $this->tokens = token_get_all($code);
    }

    /**
     * Decodes a T_CONSTANT_ENCAPSED_STRING string.
     *
     * @param string $value
     *
     * @return string
     */
    public static function decodeString($value)
    {
        $result = '';
        if ($value[0] === "'" || strpos($value, '$') === false) {
            if (strpos($value, '\\') === false) {
                $result = substr($value, 1, -1);
            } else {
                $result = eval("return $value;");
            }
        } else {
            $value = substr($value, 1, -1);
            while (($p = strpos($value, '\\')) !== false) {
                if (!isset($value[$p + 1])) {
                    break;
                }
                if ($p > 0) {
                    $result .= substr($value, 0, $p);
                }
                $value = substr($value, $p + 1);
                $p = strpos($value, '$');
                if ($p === false) {
                    $result .= eval('return "\\'.$value.'";');
                    $value = '';
                    break;
                }
                if ($p === 0) {
                    $result .= '$';
                    $value = substr($value, 1);
                } else {
                    $result .= eval('return "\\'.substr($value, 0, $p).'";');
                    $value = substr($value, $p);
                }
            }
            $result .= $value;
        }

        return $result;
    }

    /**
     * {@inheritdoc}
     */
    public function getFunctions()
    {
        $count = count($this->tokens);
        $bufferFunctions = array();
        $functions = array();
        $simpleDoubleQuote = array(
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            'n' => "\n",
            'r' => "\r",
            't' => "\t",
            'v' => "\v",
            'e' => "\f",
            '\\' => '\\',
            '$' => '$',
            '"' => '"',
        );

        for ($k = 0; $k < $count; ++$k) {
            $value = $this->tokens[$k];

            //close the current function
            if (is_string($value)) {
                if ($value === ')' && isset($bufferFunctions[0])) {
                    $functions[] = array_shift($bufferFunctions);
                }

                continue;
            }

            //add an argument to the current function
            if (isset($bufferFunctions[0]) && ($value[0] === T_CONSTANT_ENCAPSED_STRING)) {
                $bufferFunctions[0][2][] = static::decodeString($value[1]);
                continue;
            }

            //new function found
            if (($value[0] === T_STRING) && is_string($this->tokens[$k + 1]) && ($this->tokens[$k + 1] === '(')) {
                array_unshift($bufferFunctions, array($value[1], $value[2], array()));
                ++$k;

                continue;
            }
        }

        return $functions;
    }
}


1			<?php
2
3			namespace Gettext\Utils;
4
5			class PhpFunctionsScanner extends FunctionsScanner
6			{
7			protected $tokens;
8
9			/**
10			* Constructor.
11			*
12			* @param string $code The php code to scan
13			*/
14			public function __construct($code)
15			{
16			$this->tokens = token_get_all($code);
17			}
18
19			/**
20			* Decodes a T_CONSTANT_ENCAPSED_STRING string.
21			*
22			* @param string $value
23			*
24			* @return string
25			*/
26			public static function decodeString($value)
27			{
28			$result = '';
29			if ($value[0] === "'" \|\| strpos($value, '$') === false) {
30			if (strpos($value, '\\') === false) {
31			$result = substr($value, 1, -1);
32			} else {
33			$result = eval("return $value;");
34			}
35			} else {
36			$value = substr($value, 1, -1);
37			while (($p = strpos($value, '\\')) !== false) {
38			if (!isset($value[$p + 1])) {
39			break;
40			}
41			if ($p > 0) {
42			$result .= substr($value, 0, $p);
43			}
44			$value = substr($value, $p + 1);
45			$p = strpos($value, '$');
46			if ($p === false) {
47			$result .= eval('return "\\'.$value.'";');
48			$value = '';
49			break;
50			}
51			if ($p === 0) {
52			$result .= '$';
53			$value = substr($value, 1);
54			} else {
55			$result .= eval('return "\\'.substr($value, 0, $p).'";');
56			$value = substr($value, $p);
57			}
58			}
59			$result .= $value;
60			}
61
62			return $result;
63			}
64
65			/**
66			* {@inheritdoc}
67			*/
68			public function getFunctions()
69			{
70			$count = count($this->tokens);
71			$bufferFunctions = array();
72			$functions = array();
73			$simpleDoubleQuote = array(
			0 ignored issues – show Unused Code introduced 2016-02-16 16:10 UTC by Report Bug Copy Issue Report `$simpleDoubleQuote` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
74			'n' => "\n",
75			'r' => "\r",
76			't' => "\t",
77			'v' => "\v",
78			'e' => "\f",
79			'\\' => '\\',
80			'$' => '$',
81			'"' => '"',
82			);
83
84			for ($k = 0; $k < $count; ++$k) {
85			$value = $this->tokens[$k];
86
87			//close the current function
88			if (is_string($value)) {
89			if ($value === ')' && isset($bufferFunctions[0])) {
90			$functions[] = array_shift($bufferFunctions);
91			}
92
93			continue;
94			}
95
96			//add an argument to the current function
97			if (isset($bufferFunctions[0]) && ($value[0] === T_CONSTANT_ENCAPSED_STRING)) {
98			$bufferFunctions[0][2][] = static::decodeString($value[1]);
99			continue;
100			}
101
102			//new function found
103			if (($value[0] === T_STRING) && is_string($this->tokens[$k + 1]) && ($this->tokens[$k + 1] === '(')) {
104			array_unshift($bufferFunctions, array($value[1], $value[2], array()));
105			++$k;
106
107			continue;
108			}
109			}
110
111			return $functions;
112			}
113			}
114

oscarotero / Gettext

Pull Request — master (#91)

PhpFunctionsScanner::getFunctions() D

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like