Gettext\Extractors\CsvDictionary::fromString()

Complexity

Conditions	5
Paths	8

Size

Total Lines	26
Code Lines	14

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	0	Features	0

<?php
    public static function fromString($string, Translations $translations = null, $file = '')
    {
        if ($translations === null) {
            $translations = new Translations();
        }

        $handle = fopen('php://memory', 'w');

        fputs($handle, $string);
        rewind($handle);

        $entries = array();
        while ($row = fgetcsv($handle)) {
            $entries[$row[0]] = $row[1];
        }

        fclose($handle);

        if ($entries) {

The expression $entries of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using ! empty($expr) instead to make it clear that you intend to check for an array without elements.

            foreach ($entries as $original => $translation) {
                $translations->insert(null, $original)->setTranslation($translation);
            }
        }

        return $translations;
    }
}