Po::toString() - Code Metrics - Inspection of "Test multibyte and tab chars" - oscarotero/Gettext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#92)

by Michele

created 2016-02-16 16:58 UTC

Po::toString() C

↳ Parent: Po

Complexity

Conditions	14
Paths	130

Size

Total Lines	58
Code Lines	31

Duplication

Lines	0
Ratio	0 %

Importance

Changes	6
Bugs	2	Features	1

Metric	Value
c	6
b	2
f	1
dl	0
loc	58
rs	5.8652
cc	14
eloc	31
nc	130
nop	1

How to fix Long Method Complexity

<?php

namespace Gettext\Generators;

use Gettext\Translations;

class Po extends Generator implements GeneratorInterface
{
    /**
     * {@parentDoc}.
     */
    public static function toString(Translations $translations)
    {
        $lines = array('msgid ""', 'msgstr ""');

        $headers = $translations->getHeaders();
        $headers['PO-Revision-Date'] = date('c');

        foreach ($headers as $name => $value) {
            $lines[] = '"'.$name.': '.$value.'\\n"';
        }

        $lines[] = '';

        //Translations
        foreach ($translations as $translation) {
            if ($translation->hasComments()) {
                foreach ($translation->getComments() as $comment) {
                    $lines[] = '# '.$comment;
                }
            }

            if ($translation->hasExtractedComments()) {
                foreach ($translation->getExtractedComments() as $comment) {
                    $lines[] = '#. '.$comment;
                }
            }

            if ($translation->hasReferences()) {
                foreach ($translation->getReferences() as $reference) {
                    $lines[] = '#: '.$reference[0].(!is_null($reference[1]) ? ':'.$reference[1] : null);
                }
            }

            if ($translation->hasFlags()) {
                $lines[] = '#, '.implode(',', $translation->getFlags());
            }

            if ($translation->hasContext()) {
                $lines[] = 'msgctxt '.self::quote($translation->getContext());
            }

            self::addLines($lines, 'msgid', $translation->getOriginal());
            if ($translation->hasPlural()) {
                self::addLines($lines, 'msgid_plural', $translation->getPlural());
                self::addLines($lines, 'msgstr[0]', $translation->getTranslation());

                foreach ($translation->getPluralTranslation() as $k => $v) {
                    self::addLines($lines, 'msgstr['.($k + 1).']', $v);
                }
            } else {
                self::addLines($lines, 'msgstr', $translation->getTranslation());
            }

            $lines[] = '';
        }

        return implode("\n", $lines);
    }

    /**
     * Escapes and adds double quotes to a string.
     *
     * @param string $string
     *
     * @return string
     */
    private static function quote($string)
    {
        return '"'.addcslashes($string, "\x00..\x1F").'"';
    }

    /**
     * Escapes and adds double quotes to a string.
     *
     * @param string $string
     *
     * @return string
     */
    private static function multilineQuote($string)
    {
        $lines = explode("\n", $string);
        $last = count($lines) - 1;

        foreach ($lines as $k => $line) {
            if ($k === $last) {
                $lines[$k] = self::quote($line);
            } else {
                $lines[$k] = self::quote($line."\n");
            }
        }

        return $lines;
    }

    /**
     * Add one or more lines depending whether the string is multiline or not.
     *
     * @param array  &$lines
     * @param string $name
     * @param string $value
     */
    private static function addLines(array &$lines, $name, $value)
    {
        $newLines = self::multilineQuote($value);

        if (count($newLines) === 1) {
            $lines[] = $name.' '.$newLines[0];
        } else {
            $lines[] = $name.' ""';

            foreach ($newLines as $line) {
                $lines[] = $line;
            }
        }
    }
}


1			<?php
2
3			namespace Gettext\Generators;
4
5			use Gettext\Translations;
6
7			class Po extends Generator implements GeneratorInterface
8			{
9			/**
10			* {@parentDoc}.
11			*/
12			public static function toString(Translations $translations)
13			{
14			$lines = array('msgid ""', 'msgstr ""');
15
16			$headers = $translations->getHeaders();
17			$headers['PO-Revision-Date'] = date('c');
18
19			foreach ($headers as $name => $value) {
20			$lines[] = '"'.$name.': '.$value.'\\n"';
21			}
22
23			$lines[] = '';
24
25			//Translations
26			foreach ($translations as $translation) {
27			if ($translation->hasComments()) {
28			foreach ($translation->getComments() as $comment) {
29			$lines[] = '# '.$comment;
30			}
31			}
32
33			if ($translation->hasExtractedComments()) {
34			foreach ($translation->getExtractedComments() as $comment) {
35			$lines[] = '#. '.$comment;
36			}
37			}
38
39			if ($translation->hasReferences()) {
40			foreach ($translation->getReferences() as $reference) {
41			$lines[] = '#: '.$reference[0].(!is_null($reference[1]) ? ':'.$reference[1] : null);
42			}
43			}
44
45			if ($translation->hasFlags()) {
46			$lines[] = '#, '.implode(',', $translation->getFlags());
47			}
48
49			if ($translation->hasContext()) {
50			$lines[] = 'msgctxt '.self::quote($translation->getContext());
51			}
52
53			self::addLines($lines, 'msgid', $translation->getOriginal());
54			if ($translation->hasPlural()) {
55			self::addLines($lines, 'msgid_plural', $translation->getPlural());
56			self::addLines($lines, 'msgstr[0]', $translation->getTranslation());
57
58			foreach ($translation->getPluralTranslation() as $k => $v) {
59			self::addLines($lines, 'msgstr['.($k + 1).']', $v);
60			}
61			} else {
62			self::addLines($lines, 'msgstr', $translation->getTranslation());
63			}
64
65			$lines[] = '';
66			}
67
68			return implode("\n", $lines);
69			}
70
71			/**
72			* Escapes and adds double quotes to a string.
73			*
74			* @param string $string
75			*
76			* @return string
77			*/
78			private static function quote($string)
79			{
80			return '"'.addcslashes($string, "\x00..\x1F").'"';
81			}
82
83			/**
84			* Escapes and adds double quotes to a string.
85			*
86			* @param string $string
87			*
88			* @return string
89			*/
90			private static function multilineQuote($string)
91			{
92			$lines = explode("\n", $string);
93			$last = count($lines) - 1;
94
95			foreach ($lines as $k => $line) {
96			if ($k === $last) {
97			$lines[$k] = self::quote($line);
98			} else {
99			$lines[$k] = self::quote($line."\n");
100			}
101			}
102
103			return $lines;
104			}
105
106			/**
107			* Add one or more lines depending whether the string is multiline or not.
108			*
109			* @param array &$lines
110			* @param string $name
111			* @param string $value
112			*/
113			private static function addLines(array &$lines, $name, $value)
114			{
115			$newLines = self::multilineQuote($value);
116
117			if (count($newLines) === 1) {
118			$lines[] = $name.' '.$newLines[0];
119			} else {
120			$lines[] = $name.' ""';
121
122			foreach ($newLines as $line) {
123			$lines[] = $line;
124			}
125			}
126			}
127			}
128

oscarotero / Gettext

Pull Request — master (#92)

Po::toString() C

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like