CsvDictionary::toString() - Code Metrics - Inspection of "CSV Generator and Extractor" - oscarotero/Gettext - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#106)

unknown

created 2016-03-20 10:41 UTC

CsvDictionary::toString() B

↳ Parent: CsvDictionary

Complexity

Conditions	4
Paths	6

Size

Total Lines	29
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	29
rs	8.5806
cc	4
eloc	15
nc	6
nop	1

<?php

namespace Gettext\Generators;

use Gettext\Translations;

class CsvDictionary extends Generator implements GeneratorInterface
{
    /**
     * {@parentDoc}.
     */
    public static function toString(Translations $translations)
    {
        $array = PhpArray::toArray($translations);

        //for a simple json translation dictionary, one domain is supported
        $values = current($array);

        // remove meta / header data
        if (array_key_exists('', $values)) {
            unset($values['']);
        }

        $tmpFile = tempnam(sys_get_temp_dir(), 'gettext_');
        $handle = fopen($tmpFile, 'w');

        //map to a simple csv dictionary (no plurals)
        foreach ($values as $original => $translated) {
$collection = json_decode($data, true);
if ( ! is_array($collection)) {
    throw new \RuntimeException('$collection must be an array.');
}

foreach ($collection as $item) { /** ... */ }
            if (!isset($translated[1])) {
                $translated[1] = '';
            }
            fputcsv($handle, array($original, $translated[1]));
        }

        fclose($handle);
        $csv = file_get_contents($tmpFile);
        unlink($tmpFile);

        return $csv;
    }
}


1			<?php
2
3			namespace Gettext\Generators;
4
5			use Gettext\Translations;
6
7			class CsvDictionary extends Generator implements GeneratorInterface
8			{
9			/**
10			* {@parentDoc}.
11			*/
12			public static function toString(Translations $translations)
13			{
14			$array = PhpArray::toArray($translations);
15
16			//for a simple json translation dictionary, one domain is supported
17			$values = current($array);
18
19			// remove meta / header data
20			if (array_key_exists('', $values)) {
21			unset($values['']);
22			}
23
24			$tmpFile = tempnam(sys_get_temp_dir(), 'gettext_');
25			$handle = fopen($tmpFile, 'w');
26
27			//map to a simple csv dictionary (no plurals)
28			foreach ($values as $original => $translated) {
			0 ignored issues – show Bug introduced 2016-03-20 10:34 UTC by Report Bug Copy Issue Report The expression `$values` of type `array\|false` is not guaranteed to be traversable. How about adding an additional type check? There are different options of fixing this problem. If you want to be on the safe side, you can add an additional type-check: $collection = json_decode($data, true); if ( ! is_array($collection)) { throw new \RuntimeException('$collection must be an array.'); } foreach ($collection as $item) { /** ... / } If you are sure that the expression is traversable, you might want to add a doc comment cast* to improve IDE auto-completion and static analysis: /** @var array $collection / $collection = json_decode($data, true); foreach ($collection as $item) { /* .. / } Mark the issue as a false-positive*: Just hover the remove button, in the top-right corner of this issue for more options. Loading history...
29			if (!isset($translated[1])) {
30			$translated[1] = '';
31			}
32			fputcsv($handle, array($original, $translated[1]));
33			}
34
35			fclose($handle);
36			$csv = file_get_contents($tmpFile);
37			unlink($tmpFile);
38
39			return $csv;
40			}
41			}
42

oscarotero / Gettext

Pull Request — master (#106)

CsvDictionary::toString() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like