oscarLang / weatherModule

src/Weather/WeatherController.php

<?php

namespace Osln\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

// use Anax\Route\Exception\ForbiddenException;
use Anax\Route\Exception\NotFoundException;
// use Anax\Route\Exception\InternalErrorException;

/**
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class WeatherController implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;
    public function initialize() : void
    {
        $this->config = new LoadConfig();

The property config does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $this->ipvalidate = new Ipvalidate();

The property ipvalidate does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
    /**
     * This is the index method action, it handles:
     * ANY METHOD mountpoint
     * ANY METHOD mountpoint/
     * ANY METHOD mountpoint/index
     *
     * @return string
     */
    public function indexAction() : object
    {
        $page = $this->di->get("page");
        $session = $this->di->get("session");
        $data = [
            "title" => "Väder",
            "forecast" => $session->has("forecast") ? $session->get("forecast") : "",
            "month" => $session->has("month") ? $session->get("month") : "",
            "error" => $session->has("error") ? $session->get("error") : "",
            "location" => "",
        ];
        $page->add("osln/weather/default", $data);
        $session->delete("error");
        return $page->render();
    }

    public function responseActionGet()
    {
        $search = $this->di->request->getGet("location");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $session = $this->di->get("session");
        $session->delete("month");
        $url = $this->ipvalidate->getUrl($search);

        $data = $this->di->curl->fetch($url);

Accessing curl on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $forecast = null;

        if (isset($data["latitude"])) {
            $forecast = $this->di->weather->forecast($data["latitude"], $data["longitude"]);

Accessing weather on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        } elseif (isset($data[0]["lat"])) {
            $forecast = $this->di->weather->forecast($data[0]["lat"], $data[0]["lon"]);
        } else {
            $session->set("error", "Could not find this location");
        }
        $session->set("forecast", $forecast);

        $resp = $this->di->get("response");
        return $resp->redirect("weather");
        // return [$data];
    }
    public function previousActionGet()
    {
        $search = $this->di->request->getGet("location");

Accessing request on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $session = $this->di->get("session");
        $url = $this->ipvalidate->getUrl($search);

        $data = $this->di->curl->fetch($url);

Accessing curl on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        $forecast = null;
        $month = null;
        
        if (isset($data["latitude"])) {
            $forecast = $this->di->weather->forecast($data["latitude"], $data["longitude"]);

Accessing weather on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

            $month = $this->di->weather->getLastMonth($data["latitude"], $data["longitude"]);
        } elseif (isset($data[0]["lat"])) {
            $forecast = $this->di->weather->forecast($data[0]["lat"], $data[0]["lon"]);
            $month = $this->di->weather->getLastMonth($data[0]["lat"], $data[0]["lon"]);
        } else {
            $session->set("error", "Could not find this location");
        }
        // return [$forecast];
        $session->set("forecast", $forecast);
        $session->set("month", $month);

        $resp = $this->di->get("response");
        return $resp->redirect("weather");
    }
}