Osln\Weather\Weather

Complexity

Total Complexity

6

Size/Duplication

Total Lines	42
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	getArrayOfDays()	0	9	2
A	getLastMonth()	0	14	2
A	__construct()	0	3	1
A	forecast()	0	8	1

<?php

namespace Osln\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class Weather implements ContainerInjectableInterface
{
    use ContainerInjectableTrait;
    public function __construct()
    {
        $this->config = new LoadConfig();

The property config does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
    public function forecast($lat, $lon) : array
    {
        $url = "https://api.darksky.net/forecast/%1\$s/%2\$s,%3\$s?exclude=currently,flags,hourly,minutely&units=si";
        $key = $this->config->getKey("darksky");
        $urlFinal = sprintf($url, $key, $lat, $lon);
        $data = $this->di->curl->fetch($urlFinal);

Accessing curl on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        // file_put_contents("forecast.json", json_encode($data));
        return [$data];
    }

    public function getLastMonth($lat, $lon) : array
    {
        $currentTimes = $this->getArrayOfDays();
        $urls = [];
        foreach ($currentTimes as $time) {
            $key = $this->config->getKey("darksky");
            $url = "https://api.darksky.net/forecast/%1\$s/%2\$s,%3\$s,%4\$s?exclude=currently,flags,hourly,minutely&units=si";
            $urlFinal = sprintf($url, $key, $lat, $lon, $time);
            $urls[] = $urlFinal;
        }
        // var_dump($urls);
        $data = $this->di->curl->fetchMultiple($urls);

Accessing curl on the interface Psr\Container\ContainerInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        // file_put_contents("historic.json", json_encode($data));
        return [$data];
    }

    private function getArrayOfDays() : array
    {
        $times = [];
        $now = time();
        for ($i=0; $i < 30; $i++) {
            $now -= (24 * 60 * 60);
            $times[] = $now;
        }
        return $times;
    }
}