Osln\Weather\Ipvalidate

Complexity

Total Complexity

3

Size/Duplication

Total Lines	19
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes	1
Bugs	0	Features	0

2 Methods

Rating	Name	Duplication	Size	Complexity
A	getUrl()	0	13	2
A	__construct()	0	3	1

<?php

namespace Osln\Weather;

use Anax\Commons\ContainerInjectableInterface;
use Anax\Commons\ContainerInjectableTrait;

class Ipvalidate
{
    public function __construct()
    {
        $this->config = new LoadConfig();

The property config does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }
    public function getUrl($search)
    {
        $url = null;
        $key = null;
        if (filter_var($search, FILTER_VALIDATE_IP)) {
            $key = $this->config->getKey("ipstack");
            $url = "http://api.ipstack.com/%2\$s?access_key=%1\$s";
        } else {
            $url = "http://open.mapquestapi.com/nominatim/v1/search.php?q=%2\$s&limit=1&format=json&key=%1\$s";
            $key = $this->config->getKey("mapquest");
        }
        $urlFinal = sprintf($url, $key, $search);
        return $urlFinal;
    }
}