Issues in reviews.php (master) - Issues in master - osCommerce/oscommerce2 - Measure and Improve Code Quality continuously with Scrutinizer

Issues (2021)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

catalog/reviews.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php
/**
  * osCommerce Online Merchant
  *
  * @copyright (c) 2016 osCommerce; https://www.oscommerce.com
  * @license MIT; https://www.oscommerce.com/license/mit.txt
  */

  use OSC\OM\HTML;
  use OSC\OM\OSCOM;

  require('includes/application_top.php');

  $OSCOM_Language->loadDefinitions('reviews');

  $breadcrumb->add(OSCOM::getDef('navbar_title'), OSCOM::link('reviews.php'));

  require($oscTemplate->getFile('template_top.php'));
?>

<div class="page-header">
  <h1><?php echo OSCOM::getDef('heading_title'); ?></h1>
</div>

<div class="contentContainer">

<?php
  $Qreviews = $OSCOM_Db->prepare('select SQL_CALC_FOUND_ROWS r.reviews_id, left(rd.reviews_text, 100) as reviews_text, r.reviews_rating, r.date_added, p.products_id, pd.products_name, p.products_image, r.customers_name from :table_reviews r, :table_reviews_description rd, :table_products p, :table_products_description pd where p.products_id = r.products_id and p.products_status = 1 and r.reviews_status = 1 and r.reviews_id = rd.reviews_id and p.products_id = pd.products_id and pd.language_id = :language_id and pd.language_id = rd.languages_id order by r.reviews_id desc limit :page_set_offset, :page_set_max_results');
  $Qreviews->bindInt(':language_id', $OSCOM_Language->getId());
  $Qreviews->setPageSet(MAX_DISPLAY_NEW_REVIEWS);
  $Qreviews->execute();

  if ($Qreviews->getPageSetTotalRows() > 0) {
    if ((PREV_NEXT_BAR_LOCATION == '1') || (PREV_NEXT_BAR_LOCATION == '3')) {

?>

  <div class="row">
    <div class="col-sm-6 pagenumber hidden-xs">
      <?php echo $Qreviews->getPageSetLabel(OSCOM::getDef('text_display_number_of_reviews')); ?>
    </div>
    <div class="col-sm-6">
      <span class="pull-right pagenav"><?php echo $Qreviews->getPageSetLinks(tep_get_all_get_params(array('page', 'info'))); ?></span>
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
      <span class="pull-right"><?php echo OSCOM::getDef('text_result_page'); ?></span>
    </div>
  </div>
<?php
    }
    ?>
    <div class="contentText">
      <div class="reviews">
<?php
    while ($Qreviews->fetch()) {
      echo '<blockquote class="col-sm-6">';
      echo '  <p><span class="pull-left">' . HTML::image(OSCOM::linkImage($Qreviews->value('products_image')), $Qreviews->value('products_name'), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</span>' . $Qreviews->valueProtected('reviews_text') . ' ... </p><div class="clearfix"></div>';

	  $review_name = $Qreviews->valueProtected('customers_name');

	  echo '<footer>';
        $review_name = $Qreviews->valueProtected('customers_name');
        echo OSCOM::getDef('reviews_text_rated', [
		'reviews_rating' => HTML::stars($Qreviews->value('reviews_rating')),
		'review_name' => $review_name
		]);

	  echo '<a href="' . OSCOM::link('product_reviews.php', 'products_id=' . $Qreviews->valueInt('products_id')) . '">';
	  echo '<span class="pull-right label label-info">' . OSCOM::getDef('reviews_text_read_more') . '</span>';
	  echo '</a>';
	  echo '</footer>';
      echo '</blockquote>';
    }
    ?>
      </div>
      <div class="clearfix"></div>
    </div>
<?php
  } else {
?>

  <div class="alert alert-info">
    <?php echo OSCOM::getDef('text_no_reviews'); ?>
  </div>

<?php
  }

  if (($Qreviews->getPageSetTotalRows() > 0) && ((PREV_NEXT_BAR_LOCATION == '2') || (PREV_NEXT_BAR_LOCATION == '3'))) {

?>
<div class="row">
  <div class="col-sm-6 pagenumber hidden-xs">
    <?php echo $Qreviews->getPageSetLabel(OSCOM::getDef('text_display_number_of_reviews')); ?>
  </div>
  <div class="col-sm-6">
    <span class="pull-right pagenav"><?php echo $Qreviews->getPageSetLinks(tep_get_all_get_params(array('page', 'info'))); ?></span>
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
    <span class="pull-right"><?php echo OSCOM::getDef('text_result_page'); ?></span>
  </div>
</div>
<?php
  }
?>

</div>

<?php
  require($oscTemplate->getFile('template_bottom.php'));
  require('includes/application_bottom.php');
?>


1		<?php
2		/**
3		* osCommerce Online Merchant
4		*
5		* @copyright (c) 2016 osCommerce; https://www.oscommerce.com
6		* @license MIT; https://www.oscommerce.com/license/mit.txt
7		*/
8
9		use OSC\OM\HTML;
10		use OSC\OM\OSCOM;
11
12		require('includes/application_top.php');
13
14		$OSCOM_Language->loadDefinitions('reviews');
15
16		$breadcrumb->add(OSCOM::getDef('navbar_title'), OSCOM::link('reviews.php'));
17
18		require($oscTemplate->getFile('template_top.php'));
19		?>
20
21		<div class="page-header">
22		<h1><?php echo OSCOM::getDef('heading_title'); ?></h1>
23		</div>
24
25		<div class="contentContainer">
26
27		<?php
28		$Qreviews = $OSCOM_Db->prepare('select SQL_CALC_FOUND_ROWS r.reviews_id, left(rd.reviews_text, 100) as reviews_text, r.reviews_rating, r.date_added, p.products_id, pd.products_name, p.products_image, r.customers_name from :table_reviews r, :table_reviews_description rd, :table_products p, :table_products_description pd where p.products_id = r.products_id and p.products_status = 1 and r.reviews_status = 1 and r.reviews_id = rd.reviews_id and p.products_id = pd.products_id and pd.language_id = :language_id and pd.language_id = rd.languages_id order by r.reviews_id desc limit :page_set_offset, :page_set_max_results');
29		$Qreviews->bindInt(':language_id', $OSCOM_Language->getId());
30		$Qreviews->setPageSet(MAX_DISPLAY_NEW_REVIEWS);
31		$Qreviews->execute();
32
33		if ($Qreviews->getPageSetTotalRows() > 0) {
34	View Code Duplication	if ((PREV_NEXT_BAR_LOCATION == '1') \|\| (PREV_NEXT_BAR_LOCATION == '3')) {
		0 ignored issues – show Duplication introduced 2016-03-21 09:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		?>
36
37		<div class="row">
38		<div class="col-sm-6 pagenumber hidden-xs">
39		<?php echo $Qreviews->getPageSetLabel(OSCOM::getDef('text_display_number_of_reviews')); ?>
40		</div>
41		<div class="col-sm-6">
42		<span class="pull-right pagenav"><?php echo $Qreviews->getPageSetLinks(tep_get_all_get_params(array('page', 'info'))); ?></span>
		0 ignored issues – show Documentation introduced 2016-03-21 09:57 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('page', 'info')` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
43		<span class="pull-right"><?php echo OSCOM::getDef('text_result_page'); ?></span>
44		</div>
45		</div>
46		<?php
47		}
48		?>
49		<div class="contentText">
50		<div class="reviews">
51		<?php
52		while ($Qreviews->fetch()) {
53		echo '<blockquote class="col-sm-6">';
54		echo ' <p><span class="pull-left">' . HTML::image(OSCOM::linkImage($Qreviews->value('products_image')), $Qreviews->value('products_name'), SMALL_IMAGE_WIDTH, SMALL_IMAGE_HEIGHT) . '</span>' . $Qreviews->valueProtected('reviews_text') . ' ... </p><div class="clearfix"></div>';
55
56		$review_name = $Qreviews->valueProtected('customers_name');
57
58		echo '<footer>';
59		$review_name = $Qreviews->valueProtected('customers_name');
60		echo OSCOM::getDef('reviews_text_rated', [
61		'reviews_rating' => HTML::stars($Qreviews->value('reviews_rating')),
62		'review_name' => $review_name
63		]);
64
65		echo '<a href="' . OSCOM::link('product_reviews.php', 'products_id=' . $Qreviews->valueInt('products_id')) . '">';
66		echo '<span class="pull-right label label-info">' . OSCOM::getDef('reviews_text_read_more') . '</span>';
67		echo '</a>';
68		echo '</footer>';
69		echo '</blockquote>';
70		}
71		?>
72		</div>
73		<div class="clearfix"></div>
74		</div>
75		<?php
76		} else {
77		?>
78
79		<div class="alert alert-info">
80		<?php echo OSCOM::getDef('text_no_reviews'); ?>
81		</div>
82
83		<?php
84		}
85
86	View Code Duplication	if (($Qreviews->getPageSetTotalRows() > 0) && ((PREV_NEXT_BAR_LOCATION == '2') \|\| (PREV_NEXT_BAR_LOCATION == '3'))) {
		0 ignored issues – show Duplication introduced 2016-10-16 15:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		?>
88		<div class="row">
89		<div class="col-sm-6 pagenumber hidden-xs">
90		<?php echo $Qreviews->getPageSetLabel(OSCOM::getDef('text_display_number_of_reviews')); ?>
91		</div>
92		<div class="col-sm-6">
93		<span class="pull-right pagenav"><?php echo $Qreviews->getPageSetLinks(tep_get_all_get_params(array('page', 'info'))); ?></span>
		0 ignored issues – show Documentation introduced 2016-10-16 15:54 UTC by Report Bug Copy Issue Report Show Similar Issues like this `array('page', 'info')` is of type `array<integer,string,{"0":"string","1":"string"}>`, but the function expects a `string`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
94		<span class="pull-right"><?php echo OSCOM::getDef('text_result_page'); ?></span>
95		</div>
96		</div>
97		<?php
98		}
99		?>
100
101		</div>
102
103		<?php
104		require($oscTemplate->getFile('template_bottom.php'));
105		require('includes/application_bottom.php');
106		?>
107

osCommerce / oscommerce2

Issues (2021)

Security Analysis not enabled

catalog/reviews.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like