OSCOM_Braintree_CC - Code Metrics - Inspection of "Merge pull request #431 from haraldpdl/paypal" - osCommerce/oscommerce2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — 23 ( 09d773...16ee8e )

by Harald

created 2016-11-09 09:49 UTC

OSCOM_Braintree_CC C

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	227
Duplicated Lines	18.94 %

Coupling/Cohesion

Components	2
Dependencies	0

Importance

Changes

Metric	Value
dl	43
loc	227
rs	5.488
c	0
b	0
f	0
wmc	76
lcom	2
cbo	0

7 Methods

Rating	Name	Duplication	Size	Complexity
F	OSCOM_Braintree_CC()	0	79	26
A	getTitle()	0	3	1
A	getShortTitle()	0	3	1
A	install()	0	6	1
A	uninstall()	0	10	2
B	canMigrate()	21	21	9
F	migrate()	22	91	36

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like OSCOM_Braintree_CC often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use OSCOM_Braintree_CC, and based on these observations, apply Extract Interface, too.

<?php
/*
  $Id$

  osCommerce, Open Source E-Commerce Solutions
  http://www.oscommerce.com

  Copyright (c) 2016 osCommerce

  Released under the GNU General Public License
*/

  class OSCOM_Braintree_CC {
    var $_title;
    var $_short_title;
    var $_req_notes;
    var $_pm_code = 'braintree_cc';
    var $_sort_order = 100;

    function OSCOM_Braintree_CC() {
      global $OSCOM_Braintree;

      $this->_title = $OSCOM_Braintree->getDef('module_cc_title');
      $this->_short_title = $OSCOM_Braintree->getDef('module_cc_short_title');

      $this->_req_notes = array();

      if ( version_compare(PHP_VERSION, '5.4.0', '<') ) {
        $this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_php', array('version' => '5.4.0'));
      }

      $requiredExtensions = array('xmlwriter', 'openssl', 'dom', 'hash', 'curl');

      $exts = array();

      foreach ( $requiredExtensions as $ext ) {
        if ( !extension_loaded($ext) ) {
          $exts[] = $ext;
        }
      }

      if ( !empty($exts) ) {
        $this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_php_ext', array('ext' => implode('<br />', $exts)));
      }

      if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS') ) {
        $warning = false;

        if (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '1') {
          if ( !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_MERCHANT_ID) || !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_PUBLIC_KEY) || !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_PRIVATE_KEY) ) {
            $warning = true;
          }
        } elseif (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '0') {
          if ( !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_MERCHANT_ID) || !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_PUBLIC_KEY) || !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_PRIVATE_KEY) ) {
            $warning = true;
          }
        }

        if ($warning === true) {
          $this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_credentials');
        }
      }

      if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS') ) {
        $ma = null;

        if (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '1') {
          if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_CURRENCIES_MA') ) {
            $ma = OSCOM_APP_PAYPAL_BRAINTREE_CURRENCIES_MA;
          }
        } elseif (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '0') {
          if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_CURRENCIES_MA') ) {
            $ma = OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_CURRENCIES_MA;
          }
        }

        if (isset($ma)) {
          $ma_error = true;

          if ( tep_not_null($ma) ) {
            $mas = explode(';', $ma);

            foreach ( $mas as $a ) {
              $ac = explode(':', $a, 2);

              if ( isset($ac[1]) && ($ac[1] == DEFAULT_CURRENCY) ) {
                $ma_error = false;
                break;
              }
            }
          }

          if ( $ma_error === true ) {
            $this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_merchant_accounts_currency', array('currency' => DEFAULT_CURRENCY));
          }
        }
      }
    }

    function getTitle() {
      return $this->_title;
    }

    function getShortTitle() {
      return $this->_short_title;
    }

    function install($OSCOM_Braintree) {
      $installed = explode(';', MODULE_PAYMENT_INSTALLED);
      $installed[] = $this->_pm_code . '.php';

      $OSCOM_Braintree->saveParameter('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
    }

    function uninstall($OSCOM_Braintree) {
      $installed = explode(';', MODULE_PAYMENT_INSTALLED);
      $installed_pos = array_search($this->_pm_code . '.php', $installed);

      if ( $installed_pos !== false ) {
        unset($installed[$installed_pos]);

        $OSCOM_Braintree->saveParameter('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
      }
    }

    function canMigrate() {

      $class = $this->_pm_code;

      if ( file_exists(DIR_FS_CATALOG . 'includes/modules/payment/' . $class . '.php') ) {
        if ( !class_exists($class) ) {
          include(DIR_FS_CATALOG . 'includes/modules/payment/' . $class . '.php');
        }

        $module = new $class();

        if ( isset($module->signature) ) {
          $sig = explode('|', $module->signature);

          if ( isset($sig[0]) && ($sig[0] == 'braintree') && isset($sig[1]) && ($sig[1] == $class) && isset($sig[2]) ) {
            return version_compare($sig[2], 2) >= 0;
          }
        }
      }

      return false;
    }

    function migrate($OSCOM_PayPal) {
      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {

        $server = (MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER == 'Live') ? '' : 'SANDBOX_';

        if ( defined('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID') && defined('MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY') && defined('MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY') ) {
          if ( tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID) && tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY) && tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY) ) {
            if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'MERCHANT_ID') || !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'MERCHANT_ID')) ) {
              if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PUBLIC_KEY') || !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PUBLIC_KEY')) ) {
                if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PRIVATE_KEY') || !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PRIVATE_KEY')) ) {
                  $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'MERCHANT_ID', MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID);
                  $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PUBLIC_KEY', MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY);
                  $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PRIVATE_KEY', MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY);
                }
              }
            }
          }

          $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID');
          $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY');
          $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY');
          $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_CLIENT_KEY');
        }
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
        $server = (MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER == 'Live') ? '' : 'SANDBOX_';

        if ( defined('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS') ) {
          if ( tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS) ) {
            if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'CURRENCIES_MA') || !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'CURRENCIES_MA')) ) {
              $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'CURRENCIES_MA', MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS);
            }
          }

          $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS');
        }
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_METHOD') ) {
        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_TRANSACTION_METHOD', (MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_METHOD == 'Payment') ? '1' : '0');
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_METHOD');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_ORDER_STATUS_ID') ) {
        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_ORDER_STATUS_ID', MODULE_PAYMENT_BRAINTREE_CC_ORDER_STATUS_ID);
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_ORDER_STATUS_ID');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_ZONE') ) {
        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_ZONE', MODULE_PAYMENT_BRAINTREE_CC_ZONE);
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_ZONE');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_SORT_ORDER') ) {
        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_SORT_ORDER', MODULE_PAYMENT_BRAINTREE_CC_SORT_ORDER, 'Sort Order', 'Sort order of display (lowest to highest).');
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_SORT_ORDER');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_ORDER_STATUS_ID') ) {
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_ORDER_STATUS_ID');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_STATUS') ) {
        $status = '-1';

        if ( (MODULE_PAYMENT_BRAINTREE_CC_STATUS == 'True') && defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
          if ( MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER == 'Live' ) {
            $status = '1';
          } else {
            $status = '0';
          }
        }

        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS', $status);
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_STATUS');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TOKENS') ) {
        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_CC_TOKENS', (MODULE_PAYMENT_BRAINTREE_CC_TOKENS == 'True') ? '1' : '0');
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TOKENS');
      }

      if ( defined('MODULE_PAYMENT_BRAINTREE_CC_VERIFY_WITH_CVV') ) {
        $OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_VERIFY_CVV', (MODULE_PAYMENT_BRAINTREE_CC_VERIFY_WITH_CVV == 'True') ? '1' : '0');
        $OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_VERIFY_WITH_CVV');
      }
    }
  }
?>



1		<?php
2		/*
3		$Id$
4
5		osCommerce, Open Source E-Commerce Solutions
6		http://www.oscommerce.com
7
8		Copyright (c) 2016 osCommerce
9
10		Released under the GNU General Public License
11		*/
12
13		class OSCOM_Braintree_CC {
14		var $_title;
15		var $_short_title;
16		var $_req_notes;
17		var $_pm_code = 'braintree_cc';
18		var $_sort_order = 100;
19
20		function OSCOM_Braintree_CC() {
21		global $OSCOM_Braintree;
22
23		$this->_title = $OSCOM_Braintree->getDef('module_cc_title');
24		$this->_short_title = $OSCOM_Braintree->getDef('module_cc_short_title');
25
26		$this->_req_notes = array();
27
28		if ( version_compare(PHP_VERSION, '5.4.0', '<') ) {
29		$this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_php', array('version' => '5.4.0'));
30		}
31
32		$requiredExtensions = array('xmlwriter', 'openssl', 'dom', 'hash', 'curl');
33
34		$exts = array();
35
36		foreach ( $requiredExtensions as $ext ) {
37		if ( !extension_loaded($ext) ) {
38		$exts[] = $ext;
39		}
40		}
41
42		if ( !empty($exts) ) {
43		$this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_php_ext', array('ext' => implode('<br />', $exts)));
44		}
45
46		if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS') ) {
47		$warning = false;
48
49		if (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '1') {
50		if ( !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_MERCHANT_ID) \|\| !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_PUBLIC_KEY) \|\| !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_PRIVATE_KEY) ) {
51		$warning = true;
52		}
53		} elseif (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '0') {
54		if ( !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_MERCHANT_ID) \|\| !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_PUBLIC_KEY) \|\| !tep_not_null(OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_PRIVATE_KEY) ) {
55		$warning = true;
56		}
57		}
58
59		if ($warning === true) {
60		$this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_credentials');
61		}
62		}
63
64		if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS') ) {
65		$ma = null;
66
67		if (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '1') {
68		if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_CURRENCIES_MA') ) {
69		$ma = OSCOM_APP_PAYPAL_BRAINTREE_CURRENCIES_MA;
70		}
71		} elseif (OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS == '0') {
72		if ( defined('OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_CURRENCIES_MA') ) {
73		$ma = OSCOM_APP_PAYPAL_BRAINTREE_SANDBOX_CURRENCIES_MA;
74		}
75		}
76
77		if (isset($ma)) {
78		$ma_error = true;
79
80		if ( tep_not_null($ma) ) {
81		$mas = explode(';', $ma);
82
83		foreach ( $mas as $a ) {
84		$ac = explode(':', $a, 2);
85
86		if ( isset($ac[1]) && ($ac[1] == DEFAULT_CURRENCY) ) {
87		$ma_error = false;
88		break;
89		}
90		}
91		}
92
93		if ( $ma_error === true ) {
94		$this->_req_notes[] = $OSCOM_Braintree->getDef('module_cc_error_merchant_accounts_currency', array('currency' => DEFAULT_CURRENCY));
95		}
96		}
97		}
98		}
99
100		function getTitle() {
101		return $this->_title;
102		}
103
104		function getShortTitle() {
105		return $this->_short_title;
106		}
107
108		function install($OSCOM_Braintree) {
109		$installed = explode(';', MODULE_PAYMENT_INSTALLED);
110		$installed[] = $this->_pm_code . '.php';
111
112		$OSCOM_Braintree->saveParameter('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
113		}
114
115		function uninstall($OSCOM_Braintree) {
116		$installed = explode(';', MODULE_PAYMENT_INSTALLED);
117		$installed_pos = array_search($this->_pm_code . '.php', $installed);
118
119		if ( $installed_pos !== false ) {
120		unset($installed[$installed_pos]);
121
122		$OSCOM_Braintree->saveParameter('MODULE_PAYMENT_INSTALLED', implode(';', $installed));
123		}
124		}
125
126	View Code Duplication	function canMigrate() {
		0 ignored issues – show Duplication introduced 2016-10-28 01:09 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
127		$class = $this->_pm_code;
128
129		if ( file_exists(DIR_FS_CATALOG . 'includes/modules/payment/' . $class . '.php') ) {
130		if ( !class_exists($class) ) {
131		include(DIR_FS_CATALOG . 'includes/modules/payment/' . $class . '.php');
132		}
133
134		$module = new $class();
135
136		if ( isset($module->signature) ) {
137		$sig = explode('\|', $module->signature);
138
139		if ( isset($sig[0]) && ($sig[0] == 'braintree') && isset($sig[1]) && ($sig[1] == $class) && isset($sig[2]) ) {
140		return version_compare($sig[2], 2) >= 0;
141		}
142		}
143		}
144
145		return false;
146		}
147
148		function migrate($OSCOM_PayPal) {
149	View Code Duplication	if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
		0 ignored issues – show Duplication introduced 2016-10-28 01:09 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
150		$server = (MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER == 'Live') ? '' : 'SANDBOX_';
151
152		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID') && defined('MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY') && defined('MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY') ) {
153		if ( tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID) && tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY) && tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY) ) {
154		if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'MERCHANT_ID') \|\| !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'MERCHANT_ID')) ) {
155		if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PUBLIC_KEY') \|\| !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PUBLIC_KEY')) ) {
156		if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PRIVATE_KEY') \|\| !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PRIVATE_KEY')) ) {
157		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'MERCHANT_ID', MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID);
158		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PUBLIC_KEY', MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY);
159		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'PRIVATE_KEY', MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY);
160		}
161		}
162		}
163		}
164
165		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ID');
166		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_PUBLIC_KEY');
167		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_PRIVATE_KEY');
168		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_CLIENT_KEY');
169		}
170		}
171
172		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
173		$server = (MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER == 'Live') ? '' : 'SANDBOX_';
174
175		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS') ) {
176		if ( tep_not_null(MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS) ) {
177		if ( !defined('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'CURRENCIES_MA') \|\| !tep_not_null(constant('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'CURRENCIES_MA')) ) {
178		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_' . $server . 'CURRENCIES_MA', MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS);
179		}
180		}
181
182		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_MERCHANT_ACCOUNTS');
183		}
184		}
185
186		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_METHOD') ) {
187		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_TRANSACTION_METHOD', (MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_METHOD == 'Payment') ? '1' : '0');
188		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_METHOD');
189		}
190
191		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_ORDER_STATUS_ID') ) {
192		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_ORDER_STATUS_ID', MODULE_PAYMENT_BRAINTREE_CC_ORDER_STATUS_ID);
193		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_ORDER_STATUS_ID');
194		}
195
196		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_ZONE') ) {
197		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_ZONE', MODULE_PAYMENT_BRAINTREE_CC_ZONE);
198		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_ZONE');
199		}
200
201		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_SORT_ORDER') ) {
202		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_SORT_ORDER', MODULE_PAYMENT_BRAINTREE_CC_SORT_ORDER, 'Sort Order', 'Sort order of display (lowest to highest).');
203		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_SORT_ORDER');
204		}
205
206		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_ORDER_STATUS_ID') ) {
207		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_ORDER_STATUS_ID');
208		}
209
210		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_STATUS') ) {
211		$status = '-1';
212
213		if ( (MODULE_PAYMENT_BRAINTREE_CC_STATUS == 'True') && defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
214		if ( MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER == 'Live' ) {
215		$status = '1';
216		} else {
217		$status = '0';
218		}
219		}
220
221		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_STATUS', $status);
222		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_STATUS');
223		}
224
225		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER') ) {
226		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TRANSACTION_SERVER');
227		}
228
229		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_TOKENS') ) {
230		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_CC_TOKENS', (MODULE_PAYMENT_BRAINTREE_CC_TOKENS == 'True') ? '1' : '0');
231		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_TOKENS');
232		}
233
234		if ( defined('MODULE_PAYMENT_BRAINTREE_CC_VERIFY_WITH_CVV') ) {
235		$OSCOM_PayPal->saveParameter('OSCOM_APP_PAYPAL_BRAINTREE_CC_VERIFY_CVV', (MODULE_PAYMENT_BRAINTREE_CC_VERIFY_WITH_CVV == 'True') ? '1' : '0');
236		$OSCOM_PayPal->deleteParameter('MODULE_PAYMENT_BRAINTREE_CC_VERIFY_WITH_CVV');
237		}
238		}
239		}
240		?>
		0 ignored issues – show Best Practice introduced 2016-10-28 01:09 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
241

osCommerce / oscommerce2