OSC\OM\PagesAbstract

Complexity

Total Complexity

37

Size/Duplication

Total Lines	175
Duplicated Lines	6.29 %

Coupling/Cohesion

Components	2
Dependencies	1

Importance

Changes

0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	init()	0	3	1
A	getCode()	0	4	1
A	getFile()	0	6	2
A	useSiteTemplate()	0	4	1
A	setFile()	0	4	1
B	isActionRequest()	3	18	5
C	runAction()	0	40	11
B	runActions()	3	24	6
A	actionExists()	5	20	4
A	getActionsRun()	0	4	1
A	isRPC()	0	4	1
A	getActionClassName()	0	10	2

<?php
/**
  * osCommerce Online Merchant
  *
  * @copyright Copyright (c) 2015 osCommerce; http://www.oscommerce.com
  * @license GPL; http://www.oscommerce.com/gpllicense.txt
  */

namespace OSC\OM;

use OSC\OM\HTML;
use OSC\OM\OSCOM;
use OSC\OM\Registry;

abstract class PagesAbstract implements \OSC\OM\PagesInterface
{
    public $data = [];

    protected $code;
    protected $file = 'main.php';
    protected $use_site_template = true;
    protected $site;
    protected $actions_run = [];
    protected $ignored_actions = [];
    protected $is_rpc = false;

    protected $app;

    final public function __construct(\OSC\OM\SitesInterface $site)
    {
        $this->code = (new \ReflectionClass($this))->getShortName();
        $this->site = $site;

        $this->init();
    }

    protected function init()
    {
    }

    public function getCode()
    {
        return $this->code;
    }

    public function getFile()
    {
        if (isset($this->file)) {
            return dirname(OSCOM::BASE_DIR) . '/' . str_replace('\\', '/', (new \ReflectionClass($this))->getNamespaceName()) . '/templates/' . $this->file;
        }
    }

    public function useSiteTemplate()
    {
        return $this->use_site_template;
    }

    public function setFile($file)
    {
        $this->file = $file;
    }

    public function isActionRequest()
    {
        $furious_pete = [];

        if (count($_GET) > $this->site->actions_index) {

Accessing actions_index on the interface OSC\OM\SitesInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

This code seems to be duplicated across your project.

            $furious_pete = array_keys(array_slice($_GET, $this->site->actions_index, null, true));

Accessing actions_index on the interface OSC\OM\SitesInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        if (!empty($furious_pete)) {
            $action = HTML::sanitize(basename($furious_pete[0]));

            if (!in_array($action, $this->ignored_actions) && $this->actionExists($action)) {
                return true;
            }
        }

        return false;
    }

    public function runAction($actions)
    {
        if (!is_array($actions)) {
            $actions = [
                $actions
            ];
        }

        $run = [];

        foreach ($actions as $action) {
            $run[] = $action;

            if ($this->actionExists($run)) {
                $this->actions_run[] = $action;

                $class = $this->getActionClassName($run);

                $ns = explode('\\', $class);

                if ((count($ns) > 2) && ($ns[0] == 'OSC') && ($ns[1] == 'Apps')) {
                    if (isset($this->app) && is_subclass_of($this->app, 'OSC\OM\AppAbstract')) {
                        if ($this->app->definitionsExist(implode('/', array_slice($ns, 4)))) {
                            $this->app->loadDefinitions(implode('/', array_slice($ns, 4)));
                        }
                    }
                }

                $action = new $class($this);

                $action->execute();

                if ($action->isRPC()) {
                    $this->is_rpc = true;
                }
            } else {
                break;
            }
        }
    }

    public function runActions()
    {
        $actions = $furious_pete = [];

        if (count($_GET) > $this->site->actions_index) {

Accessing actions_index on the interface OSC\OM\SitesInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

This code seems to be duplicated across your project.

            $furious_pete = array_keys(array_slice($_GET, $this->site->actions_index, null, true));

Accessing actions_index on the interface OSC\OM\SitesInterface suggest that you code against a concrete implementation. How about adding an instanceof check?

        }

        foreach ($furious_pete as $action) {
            $action = HTML::sanitize(basename($action));

            $actions[] = $action;

            if (in_array($action, $this->ignored_actions) || !$this->actionExists($actions)) {
                array_pop($actions);

                break;
            }
        }

        if (!empty($actions)) {
            $this->runAction($actions);
        }
    }

    public function actionExists($action)
    {
        if (!is_array($action)) {
            $action = [
                $action
            ];
        }

        $class = $this->getActionClassName($action);

        if (class_exists($class)) {
            if (is_subclass_of($class, 'OSC\OM\PagesActionsInterface')) {

Due to PHP Bug #53727, is_subclass_of returns inconsistent results on some PHP versions for interfaces; you could instead use ReflectionClass::implementsInterface.

This code seems to be duplicated across your project.

                return true;
            } else {
                trigger_error('OSC\OM\PagesAbstract::actionExists() - ' . implode('\\', $action) . ': Action does not implement OSC\OM\PagesActionInterface and cannot be loaded.');
            }
        }

        return false;
    }

    public function getActionsRun()
    {
        return $this->actions_run;
    }

    public function isRPC()
    {
        return ($this->is_rpc === true);
    }

    protected function getActionClassName($action)
    {
        if (!is_array($action)) {
            $action = [
                $action
            ];
        }

        return (new \ReflectionClass($this))->getNamespaceName() . '\\Actions\\' . implode('\\', $action);
    }
}