Completed
Pull Request — 23 (#431)
by Harald
08:41
created
catalog/includes/apps/braintree/lib/Braintree/PayPalAccountGateway.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@  discard block
 block discarded – undo
27 27
     private $_config;
28 28
     private $_http;
29 29
 
30
+    /**
31
+     * @param Gateway $gateway
32
+     */
30 33
     public function __construct($gateway)
31 34
     {
32 35
         $this->_gateway = $gateway;
@@ -118,6 +121,7 @@  discard block
 block discarded – undo
118 121
      * @ignore
119 122
      * @param string $subPath
120 123
      * @param array $params
124
+     * @param string $httpVerb
121 125
      * @return mixed
122 126
      */
123 127
     private function _doUpdate($httpVerb, $subPath, $params)
@@ -160,7 +164,6 @@  discard block
 block discarded – undo
160 164
      * verifies that a valid paypal account identifier is being used
161 165
      * @ignore
162 166
      * @param string $identifier
163
-     * @param Optional $string $identifierType type of identifier supplied, default 'token'
164 167
      * @throws InvalidArgumentException
165 168
      */
166 169
     private function _validateId($identifier = null, $identifierType = 'token')
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Result/Successful.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -44,7 +44,7 @@
 block discarded – undo
44 44
     /**
45 45
      * @ignore
46 46
      * @param array|null $objsToReturn
47
-     * @param array|null $propertyNames
47
+     * @param string $propertyNames
48 48
      */
49 49
     public function __construct($objsToReturn = [], $propertyNames = [])
50 50
     {
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Test/Transaction.php 1 patch
Doc Comments   +4 added lines, -12 removed lines patch added patch discarded remove patch
@@ -16,9 +16,7 @@  discard block
 block discarded – undo
16 16
     /**
17 17
      * settle a transaction by id in sandbox
18 18
      *
19
-     * @param string $id transaction id
20
-     * @param Configuration $config gateway config
21
-     * @return Transaction
19
+     * @return \Braintree\Transaction
22 20
      */
23 21
     public static function settle($transactionId)
24 22
     {
@@ -28,9 +26,7 @@  discard block
 block discarded – undo
28 26
     /**
29 27
      * settlement confirm a transaction by id in sandbox
30 28
      *
31
-     * @param string $id transaction id
32
-     * @param Configuration $config gateway config
33
-     * @return Transaction
29
+     * @return \Braintree\Transaction
34 30
      */
35 31
     public static function settlementConfirm($transactionId)
36 32
     {
@@ -40,9 +36,7 @@  discard block
 block discarded – undo
40 36
     /**
41 37
      * settlement decline a transaction by id in sandbox
42 38
      *
43
-     * @param string $id transaction id
44
-     * @param Configuration $config gateway config
45
-     * @return Transaction
39
+     * @return \Braintree\Transaction
46 40
      */
47 41
     public static function settlementDecline($transactionId)
48 42
     {
@@ -52,9 +46,7 @@  discard block
 block discarded – undo
52 46
     /**
53 47
      * settlement pending a transaction by id in sandbox
54 48
      *
55
-     * @param string $id transaction id
56
-     * @param Configuration $config gateway config
57
-     * @return Transaction
49
+     * @return \Braintree\Transaction
58 50
      */
59 51
     public static function settlementPending($transactionId)
60 52
     {
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Transaction.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
         }
434 434
     }
435 435
 
436
-    /** @return void|Braintree\Customer */
436
+    /** @return null|Customer */
437 437
     public function vaultCustomer()
438 438
     {
439 439
         $customerId = $this->customerDetails->id;
@@ -507,6 +507,9 @@  discard block
 block discarded – undo
507 507
         return Configuration::gateway()->transaction()->saleNoValidate($attribs);
508 508
     }
509 509
 
510
+    /**
511
+     * @param MultipleValueNode[] $query
512
+     */
510 513
     public static function search($query)
511 514
     {
512 515
         return Configuration::gateway()->transaction()->search($query);
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/TransactionGateway.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
     private $_config;
24 24
     private $_http;
25 25
 
26
+    /**
27
+     * @param Gateway $gateway
28
+     */
26 29
     public function __construct($gateway)
27 30
     {
28 31
         $this->_gateway = $gateway;
@@ -65,7 +68,6 @@  discard block
 block discarded – undo
65 68
      *
66 69
      * @deprecated since version 2.3.0
67 70
      * @access public
68
-     * @param array $attribs
69 71
      * @return object
70 72
      */
71 73
     public function createFromTransparentRedirect($queryString)
@@ -304,7 +306,6 @@  discard block
 block discarded – undo
304 306
      * For more detailed information and examples, see {@link http://www.braintreepayments.com/gateway/transaction-api#searching http://www.braintreepaymentsolutions.com/gateway/transaction-api}
305 307
      *
306 308
      * @param mixed $query search query
307
-     * @param array $options options such as page number
308 309
      * @return ResourceCollection
309 310
      * @throws InvalidArgumentException
310 311
      */
@@ -349,7 +350,6 @@  discard block
 block discarded – undo
349 350
     /**
350 351
      * void a transaction by id
351 352
      *
352
-     * @param string $id transaction id
353 353
      * @return Result\Successful|Result\Error
354 354
      */
355 355
     public function void($transactionId)
@@ -457,7 +457,7 @@  discard block
 block discarded – undo
457 457
      * sends the create request to the gateway
458 458
      *
459 459
      * @ignore
460
-     * @param var $subPath
460
+     * @param string $subPath
461 461
      * @param array $params
462 462
      * @return mixed
463 463
      */
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/UsBankAccountGateway.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -27,6 +27,9 @@
 block discarded – undo
27 27
     private $_config;
28 28
     private $_http;
29 29
 
30
+    /**
31
+     * @param Gateway $gateway
32
+     */
30 33
     public function __construct($gateway)
31 34
     {
32 35
         $this->_gateway = $gateway;
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Braintree;
3 3
 
4
-use InvalidArgumentException;
5
-
6 4
 /**
7 5
  * Braintree UsBankAccountGateway module
8 6
  *
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Util.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      * removes the  header from a classname
103 103
      *
104 104
      * @param string $name ClassName
105
-     * @return camelCased classname minus  header
105
+     * @return string classname minus  header
106 106
      */
107 107
     public static function cleanClassName($name)
108 108
     {
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
      * @param array $array associative array to implode
292 292
      * @param string $separator (optional, defaults to =)
293 293
      * @param string $glue (optional, defaults to ', ')
294
-     * @return bool
294
+     * @return string|false
295 295
      */
296 296
     public static function implodeAssociativeArray($array, $separator = '=', $glue = ', ')
297 297
     {
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Xml/Generator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      *
59 59
      * @access protected
60 60
      * @static
61
-     * @param object $writer XMLWriter object
61
+     * @param XMLWriter $writer XMLWriter object
62 62
      * @param array $aData contains attributes and values
63 63
      * @return void
64 64
      */
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     /**
126 126
      * converts datetime back to xml schema format
127 127
      * @access protected
128
-     * @param object $dateTime
128
+     * @param DateTime $dateTime
129 129
      * @return string XML schema formatted timestamp
130 130
      */
131 131
     private static function _dateTimeToXmlTimestamp($dateTime)
Please login to merge, or discard this patch.
catalog/includes/modules/payment/braintree_cc.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -45,6 +45,9 @@
 block discarded – undo
45 45
       return '<span class="smallText">Parse Time: ' . $this->timer_total . 's</span>';
46 46
     }
47 47
 
48
+    /**
49
+     * @param string $type
50
+     */
48 51
     function write($message, $type) {
49 52
       error_log(strftime(STORE_PARSE_DATE_TIME_FORMAT) . ' [' . $type . '] ' . $message . "\n", 3, STORE_PAGE_PARSE_TIME_LOG);
50 53
     }
Please login to merge, or discard this patch.