OSC\OM\DateTime

Complexity

Total Complexity

30

Size/Duplication

Total Lines	149
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Importance

Changes

0

11 Methods

Rating	Name	Duplication	Size	Complexity
C	__construct()	0	35	8
A	isValid()	0	4	1
A	get()	0	8	2
A	getShort()	0	6	2
A	getLong()	0	4	1
A	toShort()	0	14	3
A	toLong()	0	12	2
A	getRaw()	0	10	2
A	getTimestamp()	0	4	1
B	getTimeZones()	0	26	5
A	setTimeZone()	0	8	3

<?php
/**
  * osCommerce Online Merchant
  *
  * @copyright (c) 2016 osCommerce; https://www.oscommerce.com
  * @license GPL; https://www.oscommerce.com/gpllicense.txt
  */

namespace OSC\OM;

use OSC\OM\OSCOM;

class DateTime
{
    protected $datetime = false;

    protected $raw_pattern_date = 'Y-m-d';
    protected $raw_pattern_time = 'H:i:s';

    public function __construct($datetime, $use_raw_pattern = false, $strict = false)
    {
        if ($use_raw_pattern === false) {
            $pattern = DATE_TIME_FORMAT;
        } else {
            $pattern = $this->raw_pattern_date . ' ' . $this->raw_pattern_time;
        }

        // format time as 00:00:00 if it is missing from the date
        $new_datetime = strtotime($datetime);

        if ($new_datetime !== false) {
            $new_datetime = date($pattern, $new_datetime);

            $this->datetime = \DateTime::createFromFormat($pattern, $new_datetime);

It seems like \DateTime::createFromFormat($pattern, $new_datetime) can also be of type object<DateTime>. However, the property $datetime is declared as type boolean. Maybe add an additional type check?

            $strict_log = false;
        }

        if ($this->datetime === false) {
            $strict_log = true;
        } else {
            $errors = \DateTime::getLastErrors();

            if (($errors['warning_count'] > 0) || ($errors['error_count'] > 0)) {
                $this->datetime = false;

                $strict_log = true;
            }
        }

        if (($strict === true) && ($strict_log === true)) {

The variable $strict_log does not seem to be defined for all execution paths leading up to this point.

            trigger_error('DateTime: ' . $datetime . ' (' . $new_datetime . ') cannot be formatted to ' . $pattern);
        }
    }

    public function isValid()
    {
        return $this->datetime instanceof \DateTime;
    }

    public function get($pattern = null)
    {
        if (isset($pattern)) {
            return $this->datetime->format($pattern);

The method format cannot be called on $this->datetime (of type boolean).

        }

        return $this->datetime;
    }

    public function getShort($with_time = false)
    {
        $pattern = ($with_time === false) ? DATE_FORMAT_SHORT : DATE_TIME_FORMAT;

        return strftime($pattern, $this->getTimestamp());
    }

    public function getLong()
    {
        return strftime(DATE_FORMAT_LONG, $this->getTimestamp());
    }

    public static function toShort($raw_datetime, $with_time = false, $strict = true)
    {
        $result = '';

        $date = new DateTime($raw_datetime, true, $strict);

        if ($date->isValid()) {
            $pattern = ($with_time === false) ? DATE_FORMAT_SHORT : DATE_TIME_FORMAT;

            $result = strftime($pattern, $date->getTimestamp());
        }

        return $result;
    }

    public static function toLong($raw_datetime, $strict = true)
    {
        $result = '';

        $date = new DateTime($raw_datetime, true, $strict);

        if ($date->isValid()) {
            $result = strftime(DATE_FORMAT_LONG, $date->getTimestamp());
        }

        return $result;
    }

    public function getRaw($with_time = true)
    {
        $pattern = $this->raw_pattern_date;

        if ($with_time === true) {
            $pattern .= ' ' . $this->raw_pattern_time;
        }

        return $this->datetime->format($pattern);

The method format cannot be called on $this->datetime (of type boolean).

    }

    public function getTimestamp()
    {
        return $this->datetime->getTimestamp();

The method getTimestamp cannot be called on $this->datetime (of type boolean).

    }

    public static function getTimeZones()
    {
        $time_zones_array = [];

        foreach (\DateTimeZone::listIdentifiers() as $id) {
            $tz_string = str_replace('_', ' ', $id);

            $id_array = explode('/', $tz_string, 2);

            $time_zones_array[$id_array[0]][$id] = isset($id_array[1]) ? $id_array[1] : $id_array[0];
        }

        $result = [];

        foreach ($time_zones_array as $zone => $zones_array) {
            foreach ($zones_array as $key => $value) {
                $result[] = [
                    'id' => $key,
                    'text' => $value,
                    'group' => $zone
                ];
            }
        }

        return $result;
    }

    public static function setTimeZone($time_zone = null)
    {
        if (!isset($time_zone)) {
            $time_zone = OSCOM::configExists('time_zone') ? OSCOM::getConfig('time_zone') : date_default_timezone_get();
        }

        return date_default_timezone_set($time_zone);
    }
}