newsletter::confirm() - Code Metrics - Inspection of "Merge pull request #545 from haraldpdl/gergely-iss..." - osCommerce/oscommerce2 - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 4a0bdf...a7a78b )

by Harald

created 2016-11-21 01:15 UTC

newsletter::confirm() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	53
Code Lines	49

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	49
nc	1
nop	0
dl	0
loc	53
rs	9.5797
c	0
b	0
f	0

How to fix Long Method

<?php
/**
  * osCommerce Online Merchant
  *
  * @copyright (c) 2016 osCommerce; https://www.oscommerce.com
  * @license MIT; https://www.oscommerce.com/license/mit.txt
  */

  use OSC\OM\HTML;
  use OSC\OM\Mail;
  use OSC\OM\OSCOM;
  use OSC\OM\Registry;

  class newsletter {
    var $show_choose_audience, $title, $content, $content_html;

    function __construct($title, $content, $content_html = null) {

      $this->show_choose_audience = false;
      $this->title = $title;
      $this->content = $content;
      $this->content_html = $content_html;
    }

    function choose_audience() {
      return false;
    }

    function confirm() {
      $OSCOM_Db = Registry::get('Db');

      $Qmail = $OSCOM_Db->get('customers', 'count(*) as count', ['customers_newsletter' => '1']);

      $confirm_string = '<table border="0" cellspacing="0" cellpadding="2">' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td class="main"><font color="#ff0000"><strong>' . OSCOM::getDef('text_count_customers', ['count' => $Qmail->valueInt('count')]) . '</strong></font></td>' . "\n" .
                        '  </tr>' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td>&nbsp;</td>' . "\n" .
                        '  </tr>' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td class="main"><strong>' . $this->title . '</strong></td>' . "\n" .
                        '  </tr>' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td>&nbsp;</td>' . "\n" .
                        '  </tr>' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td class="main">' . "\n" .
                        '      <ul class="nav nav-tabs" role="tablist">' . "\n" .
                        '        <li role="presentation" class="active"><a href="#html_preview" aria-controls="html_preview" role="tab" data-toggle="tab">' . OSCOM::getDef('email_type_html') . '</a></li>' . "\n" .
                        '        <li role="presentation"><a href="#plain_preview" aria-controls="plain_preview" role="tab" data-toggle="tab">' . OSCOM::getDef('email_type_plain') . '</a></li>' . "\n" .
                        '      </ul>' . "\n" .
                        '      <div class="tab-content">' . "\n" .
                        '        <div role="tabpanel" class="tab-pane active" id="html_preview">' . "\n" .
                        '          <iframe id="emailHtmlPreviewContent" style="width: 100%; height: 400px; border: 0;"></iframe>' . "\n" .
                        '          <script id="emailHtmlPreview" type="x-tmpl-mustache">' . "\n" .
                        '            ' . HTML::outputProtected($this->content_html) . "\n" .
                        '          </script>' . "\n" .
                        '          <script>' . "\n" .
                        '            $(function() {' . "\n" .
                        '              var content = $(\'<div />\').html($(\'#emailHtmlPreview\').html()).text();' . "\n" .
                        '              $(\'#emailHtmlPreviewContent\').contents().find(\'html\').html(content);' . "\n" .
                        '            });' . "\n" .
                        '          </script>' . "\n" .
                        '        </div>' . "\n" .
                        '        <div role="tabpanel" class="tab-pane" id="plain_preview">' . "\n" .
                        '          ' . nl2br(HTML::outputProtected($this->content)) . "\n" .
                        '        </div>' . "\n" .
                        '      </div>' . "\n" .
                        '    </td>' . "\n" .
                        '  </tr>' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td>&nbsp;</td>' . "\n" .
                        '  </tr>' . "\n" .
                        '  <tr>' . "\n" .
                        '    <td class="smallText" align="right">' . HTML::button(OSCOM::getDef('image_send'), 'fa fa-envelope', OSCOM::link(FILENAME_NEWSLETTERS, 'page=' . $_GET['page'] . '&nID=' . $_GET['nID'] . '&action=confirm_send')) . HTML::button(OSCOM::getDef('image_cancel'), 'fa fa-close', OSCOM::link(FILENAME_NEWSLETTERS, 'page=' . $_GET['page'] . '&nID=' . $_GET['nID'])) . '</td>' . "\n" .
                        '  </tr>' . "\n" .
                        '</table>';

      return $confirm_string;
    }

    function send($newsletter_id) {
      $OSCOM_Db = Registry::get('Db');

      $newsletterEmail = new Mail();
      $newsletterEmail->setFrom(STORE_OWNER_EMAIL_ADDRESS, STORE_OWNER);
      $newsletterEmail->setSubject($this->title);

      if (!empty($this->content)) {
        $newsletterEmail->setBodyPlain($this->content);
      }

      if (!empty($this->content_html)) {
        $newsletterEmail->setBodyHTML($this->content_html);
      }

      $Qmail = $OSCOM_Db->get('customers', [
        'customers_firstname',
        'customers_lastname',
        'customers_email_address'
      ], [
        'customers_newsletter' => '1'
      ]);

      while ($Qmail->fetch()) {

        $newsletterEmail->clearTo();

        $newsletterEmail->addTo($Qmail->value('customers_email_address'), $Qmail->value('customers_firstname') . ' ' . $Qmail->value('customers_lastname'));

        $newsletterEmail->send();
      }

      $OSCOM_Db->save('newsletters', [
        'date_sent' => 'now()',
        'status' => '1'
      ], [
        'newsletters_id' => (int)$newsletter_id
      ]);
    }
  }
?>



1		<?php
2		/**
3		* osCommerce Online Merchant
4		*
5		* @copyright (c) 2016 osCommerce; https://www.oscommerce.com
6		* @license MIT; https://www.oscommerce.com/license/mit.txt
7		*/
8
9		use OSC\OM\HTML;
10		use OSC\OM\Mail;
11		use OSC\OM\OSCOM;
12		use OSC\OM\Registry;
13
14		class newsletter {
15		var $show_choose_audience, $title, $content, $content_html;
16
17	View Code Duplication	function __construct($title, $content, $content_html = null) {
		0 ignored issues – show Duplication introduced 2016-11-21 01:17 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
18		$this->show_choose_audience = false;
19		$this->title = $title;
20		$this->content = $content;
21		$this->content_html = $content_html;
22		}
23
24		function choose_audience() {
25		return false;
26		}
27
28		function confirm() {
29		$OSCOM_Db = Registry::get('Db');
30
31		$Qmail = $OSCOM_Db->get('customers', 'count(*) as count', ['customers_newsletter' => '1']);
32
33		$confirm_string = '<table border="0" cellspacing="0" cellpadding="2">' . "\n" .
34		' <tr>' . "\n" .
35		' <td class="main"><font color="#ff0000"><strong>' . OSCOM::getDef('text_count_customers', ['count' => $Qmail->valueInt('count')]) . '</strong></font></td>' . "\n" .
36		' </tr>' . "\n" .
37		' <tr>' . "\n" .
38		' <td> </td>' . "\n" .
39		' </tr>' . "\n" .
40		' <tr>' . "\n" .
41		' <td class="main"><strong>' . $this->title . '</strong></td>' . "\n" .
42		' </tr>' . "\n" .
43		' <tr>' . "\n" .
44		' <td> </td>' . "\n" .
45		' </tr>' . "\n" .
46		' <tr>' . "\n" .
47		' <td class="main">' . "\n" .
48		' <ul class="nav nav-tabs" role="tablist">' . "\n" .
49		' <li role="presentation" class="active"><a href="#html_preview" aria-controls="html_preview" role="tab" data-toggle="tab">' . OSCOM::getDef('email_type_html') . '</a></li>' . "\n" .
50		' <li role="presentation"><a href="#plain_preview" aria-controls="plain_preview" role="tab" data-toggle="tab">' . OSCOM::getDef('email_type_plain') . '</a></li>' . "\n" .
51		' </ul>' . "\n" .
52		' <div class="tab-content">' . "\n" .
53		' <div role="tabpanel" class="tab-pane active" id="html_preview">' . "\n" .
54		' <iframe id="emailHtmlPreviewContent" style="width: 100%; height: 400px; border: 0;"></iframe>' . "\n" .
55		' <script id="emailHtmlPreview" type="x-tmpl-mustache">' . "\n" .
56		' ' . HTML::outputProtected($this->content_html) . "\n" .
57		' </script>' . "\n" .
58		' <script>' . "\n" .
59		' $(function() {' . "\n" .
60		' var content = $(\'<div />\').html($(\'#emailHtmlPreview\').html()).text();' . "\n" .
61		' $(\'#emailHtmlPreviewContent\').contents().find(\'html\').html(content);' . "\n" .
62		' });' . "\n" .
63		' </script>' . "\n" .
64		' </div>' . "\n" .
65		' <div role="tabpanel" class="tab-pane" id="plain_preview">' . "\n" .
66		' ' . nl2br(HTML::outputProtected($this->content)) . "\n" .
67		' </div>' . "\n" .
68		' </div>' . "\n" .
69		' </td>' . "\n" .
70		' </tr>' . "\n" .
71		' <tr>' . "\n" .
72		' <td> </td>' . "\n" .
73		' </tr>' . "\n" .
74		' <tr>' . "\n" .
75		' <td class="smallText" align="right">' . HTML::button(OSCOM::getDef('image_send'), 'fa fa-envelope', OSCOM::link(FILENAME_NEWSLETTERS, 'page=' . $_GET['page'] . '&nID=' . $_GET['nID'] . '&action=confirm_send')) . HTML::button(OSCOM::getDef('image_cancel'), 'fa fa-close', OSCOM::link(FILENAME_NEWSLETTERS, 'page=' . $_GET['page'] . '&nID=' . $_GET['nID'])) . '</td>' . "\n" .
76		' </tr>' . "\n" .
77		'</table>';
78
79		return $confirm_string;
80		}
81
82		function send($newsletter_id) {
83		$OSCOM_Db = Registry::get('Db');
84
85		$newsletterEmail = new Mail();
86		$newsletterEmail->setFrom(STORE_OWNER_EMAIL_ADDRESS, STORE_OWNER);
87		$newsletterEmail->setSubject($this->title);
88
89		if (!empty($this->content)) {
90		$newsletterEmail->setBodyPlain($this->content);
91		}
92
93		if (!empty($this->content_html)) {
94		$newsletterEmail->setBodyHTML($this->content_html);
95		}
96
97		$Qmail = $OSCOM_Db->get('customers', [
98		'customers_firstname',
99		'customers_lastname',
100		'customers_email_address'
101		], [
102		'customers_newsletter' => '1'
103		]);
104
105	View Code Duplication	while ($Qmail->fetch()) {
		0 ignored issues – show Duplication introduced 2016-10-16 15:54 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
106		$newsletterEmail->clearTo();
107
108		$newsletterEmail->addTo($Qmail->value('customers_email_address'), $Qmail->value('customers_firstname') . ' ' . $Qmail->value('customers_lastname'));
109
110		$newsletterEmail->send();
111		}
112
113		$OSCOM_Db->save('newsletters', [
114		'date_sent' => 'now()',
115		'status' => '1'
116		], [
117		'newsletters_id' => (int)$newsletter_id
118		]);
119		}
120		}
121		?>
		0 ignored issues – show Best Practice introduced 2016-03-21 09:57 UTC by Report Bug Copy Issue Report It is not recommended to use PHP's closing tag `?>` in files other than templates. Using a closing tag in PHP files that only contain PHP code is not recommended as you might accidentally add whitespace after the closing tag which would then be output by PHP. This can cause severe problems, for example headers cannot be sent anymore. A simple precaution is to leave off the closing tag as it is not required, and it also has no negative effects whatsoever. Loading history...
122

osCommerce / oscommerce2

Push — master ( 4a0bdf...a7a78b )

newsletter::confirm() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like