Completed
Pull Request — 23 (#615)
by Harald
03:18
created
catalog/includes/apps/braintree/lib/Braintree/Transaction.php 1 patch
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -433,7 +433,7 @@  discard block
 block discarded – undo
433 433
         }
434 434
     }
435 435
 
436
-    /** @return void|Braintree\Customer */
436
+    /** @return null|Customer */
437 437
     public function vaultCustomer()
438 438
     {
439 439
         $customerId = $this->customerDetails->id;
@@ -507,6 +507,9 @@  discard block
 block discarded – undo
507 507
         return Configuration::gateway()->transaction()->saleNoValidate($attribs);
508 508
     }
509 509
 
510
+    /**
511
+     * @param MultipleValueNode[] $query
512
+     */
510 513
     public static function search($query)
511 514
     {
512 515
         return Configuration::gateway()->transaction()->search($query);
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/TransactionGateway.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -23,6 +23,9 @@  discard block
 block discarded – undo
23 23
     private $_config;
24 24
     private $_http;
25 25
 
26
+    /**
27
+     * @param Gateway $gateway
28
+     */
26 29
     public function __construct($gateway)
27 30
     {
28 31
         $this->_gateway = $gateway;
@@ -65,7 +68,6 @@  discard block
 block discarded – undo
65 68
      *
66 69
      * @deprecated since version 2.3.0
67 70
      * @access public
68
-     * @param array $attribs
69 71
      * @return object
70 72
      */
71 73
     public function createFromTransparentRedirect($queryString)
@@ -304,7 +306,6 @@  discard block
 block discarded – undo
304 306
      * For more detailed information and examples, see {@link http://www.braintreepayments.com/gateway/transaction-api#searching http://www.braintreepaymentsolutions.com/gateway/transaction-api}
305 307
      *
306 308
      * @param mixed $query search query
307
-     * @param array $options options such as page number
308 309
      * @return ResourceCollection
309 310
      * @throws InvalidArgumentException
310 311
      */
@@ -349,7 +350,6 @@  discard block
 block discarded – undo
349 350
     /**
350 351
      * void a transaction by id
351 352
      *
352
-     * @param string $id transaction id
353 353
      * @return Result\Successful|Result\Error
354 354
      */
355 355
     public function void($transactionId)
@@ -457,7 +457,7 @@  discard block
 block discarded – undo
457 457
      * sends the create request to the gateway
458 458
      *
459 459
      * @ignore
460
-     * @param var $subPath
460
+     * @param string $subPath
461 461
      * @param array $params
462 462
      * @return mixed
463 463
      */
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/UsBankAccountGateway.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -1,8 +1,6 @@
 block discarded – undo
1 1
 <?php
2 2
 namespace Braintree;
3 3
 
4
-use InvalidArgumentException;
5
-
6 4
 /**
7 5
  * Braintree UsBankAccountGateway module
8 6
  *
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -7,6 +7,9 @@
 block discarded – undo
7 7
     private $_config;
8 8
     private $_http;
9 9
 
10
+    /**
11
+     * @param Gateway $gateway
12
+     */
10 13
     public function __construct($gateway)
11 14
     {
12 15
         $this->_gateway = $gateway;
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Util.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -102,7 +102,7 @@  discard block
 block discarded – undo
102 102
      * removes the  header from a classname
103 103
      *
104 104
      * @param string $name ClassName
105
-     * @return camelCased classname minus  header
105
+     * @return string classname minus  header
106 106
      */
107 107
     public static function cleanClassName($name)
108 108
     {
@@ -291,7 +291,7 @@  discard block
 block discarded – undo
291 291
      * @param array $array associative array to implode
292 292
      * @param string $separator (optional, defaults to =)
293 293
      * @param string $glue (optional, defaults to ', ')
294
-     * @return bool
294
+     * @return string|false
295 295
      */
296 296
     public static function implodeAssociativeArray($array, $separator = '=', $glue = ', ')
297 297
     {
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/lib/Braintree/Xml/Generator.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -58,7 +58,7 @@  discard block
 block discarded – undo
58 58
      *
59 59
      * @access protected
60 60
      * @static
61
-     * @param object $writer XMLWriter object
61
+     * @param XMLWriter $writer XMLWriter object
62 62
      * @param array $aData contains attributes and values
63 63
      * @return void
64 64
      */
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     /**
126 126
      * converts datetime back to xml schema format
127 127
      * @access protected
128
-     * @param object $dateTime
128
+     * @param DateTime $dateTime
129 129
      * @return string XML schema formatted timestamp
130 130
      */
131 131
     private static function _dateTimeToXmlTimestamp($dateTime)
Please login to merge, or discard this patch.
catalog/includes/apps/braintree/OSCOM_Braintree.php 1 patch
Doc Comments   +19 added lines patch added patch discarded remove patch
@@ -182,6 +182,9 @@  discard block
 block discarded – undo
182 182
       return false;
183 183
     }
184 184
 
185
+    /**
186
+     * @param string $info
187
+     */
185 188
     function getModuleInfo($module, $info) {
186 189
       $class = 'OSCOM_Braintree_' . $module;
187 190
 
@@ -368,6 +371,10 @@  discard block
 block discarded – undo
368 371
       return $result;
369 372
     }
370 373
 
374
+    /**
375
+     * @param string $link
376
+     * @param string $type
377
+     */
371 378
     function drawButton($title = null, $link = null, $type = null, $params = null, $force_css = false) {
372 379
       $colours = array('success' => '#1cb841',
373 380
                        'error' => '#ca3c3c',
@@ -424,6 +431,9 @@  discard block
 block discarded – undo
424 431
       return $button;
425 432
     }
426 433
 
434
+    /**
435
+     * @param integer $length
436
+     */
427 437
     function createRandomValue($length, $type = 'mixed') {
428 438
       if ( ($type != 'mixed') && ($type != 'chars') && ($type != 'digits')) $type = 'mixed';
429 439
 
@@ -508,6 +518,9 @@  discard block
 block discarded – undo
508 518
       }
509 519
     }
510 520
 
521
+    /**
522
+     * @param string $key
523
+     */
511 524
     function deleteParameter($key) {
512 525
       tep_db_query("delete from " . TABLE_CONFIGURATION . " where configuration_key = '" . tep_db_input($key) . "'");
513 526
     }
@@ -672,6 +685,9 @@  discard block
 block discarded – undo
672 685
       }
673 686
     }
674 687
 
688
+    /**
689
+     * @param string $filename
690
+     */
675 691
     public function loadLanguageFile($filename, $lang = null) {
676 692
       global $language;
677 693
 
@@ -713,6 +729,9 @@  discard block
 block discarded – undo
713 729
       }
714 730
     }
715 731
 
732
+    /**
733
+     * @param string $key
734
+     */
716 735
     function getDef($key, $values = null) {
717 736
       $def = isset($this->_definitions[$key]) ? $this->_definitions[$key] : $key;
718 737
 
Please login to merge, or discard this patch.
catalog/admin/includes/functions/sessions.php 1 patch
Doc Comments   +9 added lines patch added patch discarded remove patch
@@ -103,6 +103,9 @@  discard block
 block discarded – undo
103 103
     return session_start();
104 104
   }
105 105
 
106
+  /**
107
+   * @param string $variable
108
+   */
106 109
   function tep_session_register($variable) {
107 110
     if (PHP_VERSION < 4.3) {
108 111
       return session_register($variable);
@@ -117,6 +120,9 @@  discard block
 block discarded – undo
117 120
     return false;
118 121
   }
119 122
 
123
+  /**
124
+   * @param string $variable
125
+   */
120 126
   function tep_session_is_registered($variable) {
121 127
     if (PHP_VERSION < 4.3) {
122 128
       return session_is_registered($variable);
@@ -125,6 +131,9 @@  discard block
 block discarded – undo
125 131
     }
126 132
   }
127 133
 
134
+  /**
135
+   * @param string $variable
136
+   */
128 137
   function tep_session_unregister($variable) {
129 138
     if (PHP_VERSION < 4.3) {
130 139
       return session_unregister($variable);
Please login to merge, or discard this patch.
includes/modules/security_check/extended/admin_backup_directory_listing.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@
 block discarded – undo
32 32
       return MODULE_SECURITY_CHECK_EXTENDED_ADMIN_BACKUP_DIRECTORY_LISTING_HTTP_200;
33 33
     }
34 34
 
35
+    /**
36
+     * @param null|string $url
37
+     */
35 38
     function getHttpRequest($url) {
36 39
       global $HTTP_SERVER_VARS;
37 40
 
Please login to merge, or discard this patch.
admin/includes/modules/security_check/extended/admin_backup_file.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -66,6 +66,9 @@
 block discarded – undo
66 66
       return MODULE_SECURITY_CHECK_EXTENDED_ADMIN_BACKUP_FILE_HTTP_200;
67 67
     }
68 68
 
69
+    /**
70
+     * @param null|string $url
71
+     */
69 72
     function getHttpRequest($url) {
70 73
       global $HTTP_SERVER_VARS;
71 74
 
Please login to merge, or discard this patch.