Css2Less::getLess() - Code Metrics - Inspection of "Merge pull request #6 from ortic/fix-double-colon" - ortic/css2less - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e3c06e...d37729 )

by Remo

created 2015-11-21 12:58 UTC

Css2Less::getLess() C

↳ Parent: Css2Less

Complexity

Conditions	9
Paths	14

Size

Total Lines	52
Code Lines	28

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	25
CRAP Score	9.0046

Importance

Changes	3
Bugs	1	Features	0

Metric	Value
c	3
b	1
f	0
dl	0
loc	52
ccs	25
cts	26
cp	0.9615
rs	6.5703
cc	9
eloc	28
nc	14
nop	0
crap	9.0046

How to fix Long Method

<?php

namespace Ortic\Css2Less;

use Ortic\Css2Less\tokens\LessRuleList;
use Ortic\Css2Less\tokens\LessRule;

class Css2Less
{
    /**
     * @var string $cssContent
     */
    protected $cssContent;

    /**
     * @var \CssParser $parser
     */
    protected $parser;

    /**
     * Create a new parser object, use parameter to specify CSS you
     * wish to convert into a LESS file
     *
     * @param string $cssContent
     */
    public function __construct($cssContent)
    {
        $this->cssContent = $cssContent;
        $this->parser = new \CssParser($this->cssContent);
    }

    /**
     * Returns a string containing the LESS content matching the CSS input
     * @return string
     */
    public function getLess()
    {
        $lessTree = array();

        // this variable is true, if we're within a ruleset, e.g. p { .. here .. }
        // we have to normalize them
        $withinRulset = false;
        $ruleSet = null;
        $ruleSetList = new LessRuleList();

        $tokens = $this->parser->getTokens();

        foreach ($tokens as $token) {
            // we have to skip some tokens, their information is redundant
            if ($token instanceof \CssAtMediaStartToken ||
                $token instanceof \CssAtMediaEndToken
            ) {
                continue;
            }

            // we have to build a hierarchy with CssRulesetStartToken, CssRulesetEndToken
            if ($token instanceof \CssRulesetStartToken) {
                $withinRulset = true;
                $ruleSet = new LessRule($token->Selectors);
            } elseif ($token instanceof \CssRulesetEndToken) {
                $withinRulset = false;
                if ($ruleSet) {
                    $ruleSetList->addRule($ruleSet);
                }
                $ruleSet = null;
            } else {
                // as long as we're in a ruleset, we're adding all token to a custom array
                // this will be lessified once we've found CssRulesetEndToken and then added
                // to the actual $lessTree variable
                if ($withinRulset) {
                    $ruleSet->addToken($token);
                } else {
                    $lessTree[] = $token;
                }
            }
        }

        $return = '';
        foreach ($lessTree as $node) {
            // @TODO this format method shouldn't be in this class..
            $return .= $ruleSetList->formatTokenAsLess($node) . "\n";
        }

        $return .= $ruleSetList->lessify();

        return $return;
    }

}
// Incorrect placement according to PSR2
class MyClass
{
    public function foo()
    {

    }
    // This blank line is not allowed.

}

// Correct
class MyClass
{
    public function foo()
    {

    } // No blank lines after this line.
}


1		<?php
2
3		namespace Ortic\Css2Less;
4
5		use Ortic\Css2Less\tokens\LessRuleList;
6		use Ortic\Css2Less\tokens\LessRule;
7
8		class Css2Less
9		{
10		/**
11		* @var string $cssContent
12		*/
13		protected $cssContent;
14
15		/**
16		* @var \CssParser $parser
17		*/
18		protected $parser;
19
20		/**
21		* Create a new parser object, use parameter to specify CSS you
22		* wish to convert into a LESS file
23		*
24		* @param string $cssContent
25		*/
26	9	public function __construct($cssContent)
27		{
28	9	$this->cssContent = $cssContent;
29	9	$this->parser = new \CssParser($this->cssContent);
30	9	}
31
32		/**
33		* Returns a string containing the LESS content matching the CSS input
34		* @return string
35		*/
36	9	public function getLess()
37		{
38	9	$lessTree = array();
39
40		// this variable is true, if we're within a ruleset, e.g. p { .. here .. }
41		// we have to normalize them
42	9	$withinRulset = false;
43	9	$ruleSet = null;
44	9	$ruleSetList = new LessRuleList();
45
46	9	$tokens = $this->parser->getTokens();
47
48	9	foreach ($tokens as $token) {
49		// we have to skip some tokens, their information is redundant
50	9	if ($token instanceof \CssAtMediaStartToken \|\|
51	9	$token instanceof \CssAtMediaEndToken
52		) {
53	1	continue;
54		}
55
56		// we have to build a hierarchy with CssRulesetStartToken, CssRulesetEndToken
57	9	if ($token instanceof \CssRulesetStartToken) {
58	9	$withinRulset = true;
59	9	$ruleSet = new LessRule($token->Selectors);
60		} elseif ($token instanceof \CssRulesetEndToken) {
61	9	$withinRulset = false;
62	9	if ($ruleSet) {
63	9	$ruleSetList->addRule($ruleSet);
64		}
65	9	$ruleSet = null;
66		} else {
67		// as long as we're in a ruleset, we're adding all token to a custom array
68		// this will be lessified once we've found CssRulesetEndToken and then added
69		// to the actual $lessTree variable
70	9	if ($withinRulset) {
71	9	$ruleSet->addToken($token);
72		} else {
73	9	$lessTree[] = $token;
74		}
75		}
76		}
77
78	9	$return = '';
79	9	foreach ($lessTree as $node) {
80		// @TODO this format method shouldn't be in this class..
81	1	$return .= $ruleSetList->formatTokenAsLess($node) . "\n";
82		}
83
84	9	$return .= $ruleSetList->lessify();
85
86	9	return $return;
87		}
88
89		}
		0 ignored issues – show Coding Style introduced 2015-11-21 09:32 UTC by Report Bug Copy Issue Report According to PSR2, the closing brace of classes should be placed on the next line directly after the body. Below you find some examples: // Incorrect placement according to PSR2 class MyClass { public function foo() { } // This blank line is not allowed. } // Correct class MyClass { public function foo() { } // No blank lines after this line. } Loading history...
90

ortic / css2less

Push — master ( e3c06e...d37729 )

Css2Less::getLess() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like