@@ -11,6 +11,11 @@ |
||
11 | 11 | { |
12 | 12 | protected $query; |
13 | 13 | |
14 | + /** |
|
15 | + * @param integer $a |
|
16 | + * @param integer $b |
|
17 | + * @param integer $c |
|
18 | + */ |
|
14 | 19 | public function __construct($a, $b, $c) |
15 | 20 | { |
16 | 21 | $arbitrary = "nothing important here"; |
@@ -4,7 +4,6 @@ |
||
4 | 4 | |
5 | 5 | use Doctrine\Common\Util\ClassUtils; |
6 | 6 | use Doctrine\ORM\Mapping as ORM; |
7 | - |
|
8 | 7 | use Oro\Bundle\TagBundle\Model\ExtendTagging; |
9 | 8 | use Oro\Bundle\UserBundle\Entity\User; |
10 | 9 | use Oro\Bundle\EntityConfigBundle\Metadata\Annotation\Config; |
@@ -50,6 +50,10 @@ discard block |
||
50 | 50 | */ |
51 | 51 | protected $router; |
52 | 52 | |
53 | + /** |
|
54 | + * @param string $tagClass |
|
55 | + * @param string $taggingClass |
|
56 | + */ |
|
53 | 57 | public function __construct( |
54 | 58 | EntityManager $em, |
55 | 59 | $tagClass, |
@@ -285,7 +289,7 @@ discard block |
||
285 | 289 | |
286 | 290 | /** |
287 | 291 | * @param Tag $tag |
288 | - * @return callable |
|
292 | + * @return \Closure |
|
289 | 293 | */ |
290 | 294 | public function compareCallback($tag) |
291 | 295 | { |
@@ -2,13 +2,10 @@ |
||
2 | 2 | |
3 | 3 | namespace Oro\Bundle\TagBundle\Entity; |
4 | 4 | |
5 | -use Doctrine\ORM\Query\Expr; |
|
6 | 5 | use Doctrine\ORM\EntityManager; |
7 | 6 | use Doctrine\Common\Util\ClassUtils; |
8 | 7 | use Doctrine\Common\Collections\ArrayCollection; |
9 | - |
|
10 | 8 | use Symfony\Bundle\FrameworkBundle\Routing\Router; |
11 | - |
|
12 | 9 | use Oro\Bundle\SecurityBundle\SecurityFacade; |
13 | 10 | use Oro\Bundle\OrganizationBundle\Entity\Organization; |
14 | 11 | use Oro\Bundle\UserBundle\Entity\User; |
@@ -5,7 +5,6 @@ |
||
5 | 5 | use Symfony\Component\Form\FormEvent; |
6 | 6 | use Symfony\Component\Form\FormEvents; |
7 | 7 | use Symfony\Component\EventDispatcher\EventSubscriberInterface; |
8 | - |
|
9 | 8 | use Oro\Bundle\OrganizationBundle\Entity\Organization; |
10 | 9 | use Oro\Bundle\TagBundle\Entity\Taggable; |
11 | 10 | use Oro\Bundle\TagBundle\Entity\TagManager; |
@@ -4,9 +4,7 @@ |
||
4 | 4 | |
5 | 5 | use Symfony\Component\Form\FormInterface; |
6 | 6 | use Symfony\Component\HttpFoundation\Request; |
7 | - |
|
8 | 7 | use Doctrine\Common\Persistence\ObjectManager; |
9 | - |
|
10 | 8 | use Oro\Bundle\TagBundle\Entity\Tag; |
11 | 9 | |
12 | 10 | class TagHandler |
@@ -57,6 +57,7 @@ |
||
57 | 57 | |
58 | 58 | /** |
59 | 59 | * {@inheritdoc} |
60 | + * @param integer $tagId |
|
60 | 61 | */ |
61 | 62 | public function getResults($tagId) |
62 | 63 | { |
@@ -3,9 +3,7 @@ |
||
3 | 3 | namespace Oro\Bundle\TagBundle\Provider; |
4 | 4 | |
5 | 5 | use Doctrine\ORM\EntityManager; |
6 | - |
|
7 | 6 | use Symfony\Component\Translation\TranslatorInterface; |
8 | - |
|
9 | 7 | use Oro\Bundle\EntityConfigBundle\Config\ConfigManager; |
10 | 8 | use Oro\Bundle\SearchBundle\Engine\Indexer; |
11 | 9 | use Oro\Bundle\SearchBundle\Query\Query; |
@@ -127,6 +127,10 @@ discard block |
||
127 | 127 | } |
128 | 128 | } |
129 | 129 | |
130 | + /** |
|
131 | + * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login |
|
132 | + * @param string $role |
|
133 | + */ |
|
130 | 134 | public function deleteAcl($login, $role, $username, $tagName) |
131 | 135 | { |
132 | 136 | /** @var Roles $login*/ |
@@ -143,6 +147,10 @@ discard block |
||
143 | 147 | ->checkContextMenu($tagName, 'Delete'); |
144 | 148 | } |
145 | 149 | |
150 | + /** |
|
151 | + * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login |
|
152 | + * @param string $role |
|
153 | + */ |
|
146 | 154 | public function updateAcl($login, $role, $username, $tagName) |
147 | 155 | { |
148 | 156 | /** @var Roles $login*/ |
@@ -159,6 +167,10 @@ discard block |
||
159 | 167 | ->checkContextMenu($tagName, 'Update'); |
160 | 168 | } |
161 | 169 | |
170 | + /** |
|
171 | + * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login |
|
172 | + * @param string $role |
|
173 | + */ |
|
162 | 174 | public function createAcl($login, $role, $username) |
163 | 175 | { |
164 | 176 | /** @var Roles $login*/ |
@@ -175,6 +187,10 @@ discard block |
||
175 | 187 | ->assertElementNotPresent("//div[@class = 'container-fluid']//a[contains(., 'Create Tag')]"); |
176 | 188 | } |
177 | 189 | |
190 | + /** |
|
191 | + * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login |
|
192 | + * @param string $role |
|
193 | + */ |
|
178 | 194 | public function viewListAcl($login, $role, $username) |
179 | 195 | { |
180 | 196 | /** @var Roles $login*/ |
@@ -191,6 +207,10 @@ discard block |
||
191 | 207 | ->assertTitle('403 - Forbidden'); |
192 | 208 | } |
193 | 209 | |
210 | + /** |
|
211 | + * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login |
|
212 | + * @param string $roleName |
|
213 | + */ |
|
194 | 214 | public function unassignGlobalAcl($login, $roleName, $tagName) |
195 | 215 | { |
196 | 216 | $username = 'user' . mt_rand(); |
@@ -229,6 +249,10 @@ discard block |
||
229 | 249 | ); |
230 | 250 | } |
231 | 251 | |
252 | + /** |
|
253 | + * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login |
|
254 | + * @param string $role |
|
255 | + */ |
|
232 | 256 | public function assignAcl($login, $role, $username) |
233 | 257 | { |
234 | 258 | /** @var Roles $login*/ |
@@ -3,10 +3,8 @@ |
||
3 | 3 | namespace Oro\Bundle\TagBundle\Tests\Unit\Form\Handler; |
4 | 4 | |
5 | 5 | use Doctrine\Common\Persistence\ObjectManager; |
6 | - |
|
7 | 6 | use Symfony\Component\Form\FormInterface; |
8 | 7 | use Symfony\Component\HttpFoundation\Request; |
9 | - |
|
10 | 8 | use Oro\Bundle\TagBundle\Entity\Tag; |
11 | 9 | use Oro\Bundle\TagBundle\Form\Handler\TagHandler; |
12 | 10 |
@@ -2,8 +2,6 @@ |
||
2 | 2 | |
3 | 3 | namespace Oro\Bundle\TagBundle\Twig; |
4 | 4 | |
5 | -use Symfony\Component\Routing\Router; |
|
6 | - |
|
7 | 5 | use Oro\Bundle\TagBundle\Entity\Taggable; |
8 | 6 | use Oro\Bundle\TagBundle\Entity\TagManager; |
9 | 7 |