orocrm / platform

src/Oro/Bundle/SecurityBundle/Owner/OwnerTreeProvider.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Doctrine\Common\Cache\CacheProvider;
 use Doctrine\ORM\EntityManager;
-
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
 use Oro\Bundle\SecurityBundle\Owner\Metadata\OwnershipMetadataProvider;
 use Oro\Bundle\UserBundle\Entity\User;

src/Oro/Bundle/SecurityBundle/Request/ParamConverter/DoctrineParamConverter.php

Unused Use Statements -3 removed lines

@@ -4,12 +4,9 @@
 
 use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
-
 use Doctrine\Common\Persistence\ManagerRegistry;
-
 use Sensio\Bundle\FrameworkExtraBundle\Request\ParamConverter\DoctrineParamConverter as BaseParamConverter;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\ConfigurationInterface;
-
 use Oro\Bundle\SecurityBundle\SecurityFacade;
 
 /**

src/Oro/Bundle/SecurityBundle/Search/AclHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
 
     /**
      * @param Query $query
-     * @param $expr
+     * @param \Oro\Bundle\SearchBundle\Query\Criteria\ExpressionBuilder $expr
      */
     protected function addOrganizationLimits(Query $query, $expr)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Bundle\SecurityBundle\Search;
 
 use Doctrine\Common\Collections\Expr\CompositeExpression;
-
 use Oro\Bundle\SearchBundle\Provider\SearchMappingProvider;
 use Oro\Bundle\SearchBundle\Query\Query;
 use Oro\Bundle\SecurityBundle\EventListener\SearchListener;

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Domain/PermissionGrantingStrategyTest.php

Doc Comments +5 added lines, -2 removed lines

@@ -346,6 +346,9 @@ 
         );
     }
 
+    /**
+     * @param ObjectIdentity $oid
+     */
     protected function getAcl($oid = null, $entriesInheriting = true)
     {
         static $id = 1;
@@ -385,7 +388,7 @@ 
 
     /**
      * @param  string     $permission
-     * @param  object     $object
+     * @param  TestEntity     $object
      * @return array|null may return null if permission/object combination is not supported
      */
     private function getMasks($permission, $object)
@@ -395,7 +398,7 @@ 
 
     /**
      * @param  string      $permission
-     * @param  mixed       $object
+     * @param  TestEntity       $object
      * @return MaskBuilder
      */
     private function getMaskBuilder($permission, $object)

Unused Use Statements -1 removed lines

@@ -8,7 +8,6 @@
 use Symfony\Component\Security\Acl\Domain\RoleSecurityIdentity;
 use Symfony\Component\Security\Acl\Domain\UserSecurityIdentity;
 use Symfony\Component\Security\Acl\Exception\NoAceFoundException;
-
 use Oro\Bundle\SecurityBundle\Acl\Domain\ObjectIdAccessor;
 use Oro\Bundle\SecurityBundle\Acl\Domain\PermissionGrantingStrategy;
 use Oro\Bundle\SecurityBundle\Acl\Extension\AclExtensionSelector;

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Extension/EntityAclExtensionTest.php

Unused Use Statements -2 removed lines

@@ -5,9 +5,7 @@
 use Symfony\Component\Security\Core\Util\ClassUtils;
 use Symfony\Component\DependencyInjection\ContainerInterface;
 use Symfony\Component\Security\Acl\Domain\ObjectIdentity;
-
 use Oro\Bundle\EntityBundle\ORM\EntityClassResolver;
-
 use Oro\Bundle\SecurityBundle\Acl\AccessLevel;
 use Oro\Bundle\SecurityBundle\Acl\Domain\ObjectIdAccessor;
 use Oro\Bundle\SecurityBundle\Acl\Domain\ObjectIdentityFactory;

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Group/ChainAclGroupProviderTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -65,7 +65,7 @@
     /**
      * @param bool $isSupports
      * @param string $group
-     * @return \PHPUnit_Framework_MockObject_MockObject|AclGroupProviderInterface
+     * @return AclGroupProviderInterface
      */
     protected function getAclGroupProviderMock($isSupports = true, $group = '')
     {

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Persistence/AceManipulationHelperTest.php

Doc Comments +5 added lines

@@ -436,6 +436,11 @@
         );
     }
 
+    /**
+     * @param boolean $granting
+     * @param integer $mask
+     * @param string $strategy
+     */
     private function getAce(
         $sid,
         $granting = null,

src/Oro/Bundle/SecurityBundle/Tests/Unit/Acl/Persistence/AclPrivilegeRepositoryTest.php

Doc Comments +9 added lines

@@ -352,6 +352,10 @@ 
         $this->assertFalse($p->containsKey('EDIT'));
     }
 
+    /**
+     * @param string $extensionKey
+     * @param ObjectIdentity $rootOid
+     */
     private function initSavePrivileges($extensionKey, $rootOid)
     {
         $this->extension->expects($this->any())
@@ -364,6 +368,11 @@ 
             ->method('adaptRootMask')
             ->will(
                 $this->returnCallback(
+
+                    /**
+                     * @param string $mask
+                     * @param ObjectIdentity $object
+                     */
                     function ($mask, $object) {
                         return $mask;
                     }

src/Oro/Bundle/SecurityBundle/Tests/Unit/DependencyInjection/Compiler/OwnershipDecisionMakerPassTest.php

Unused Use Statements -1 removed lines

@@ -4,7 +4,6 @@
 
 use Symfony\Component\DependencyInjection\ContainerBuilder;
 use Symfony\Component\DependencyInjection\Reference;
-
 use Oro\Bundle\SecurityBundle\DependencyInjection\Compiler\OwnershipDecisionMakerPass;
 
 class OwnershipDecisionMakerPassTest extends \PHPUnit_Framework_TestCase