Completed
Push — 1.8 ( b7094f...f1162e )
by
unknown
83:38 queued 61:44
created
src/Oro/Bundle/EntityPaginationBundle/Twig/EntityPaginationExtension.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      * Null - pager data is not accessible
64 64
      * Array('total' => <int>, 'current' => <int>) - used to generate string "<current> of <total>"
65 65
      *
66
-     * @param object $entity
66
+     * @param \stdClass $entity
67 67
      * @param string $scope
68 68
      * @return null|array
69 69
      */
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     }
93 93
 
94 94
     /**
95
-     * @param object $entity
95
+     * @param \stdClass $entity
96 96
      * @param string $scope
97 97
      */
98 98
     public function showInfoMessage($entity, $scope)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EntityPaginationBundle\Twig;
4 4
 
5 5
 use Symfony\Component\HttpFoundation\Request;
6
-
7 6
 use Oro\Bundle\EntityPaginationBundle\Navigation\EntityPaginationNavigation;
8 7
 use Oro\Bundle\EntityPaginationBundle\Storage\StorageDataCollector;
9 8
 use Oro\Bundle\EntityPaginationBundle\Manager\MessageManager;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Datasource/Orm/OrmManyRelationBuilder.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Doctrine\Common\Persistence\ManagerRegistry;
6 6
 use Doctrine\ORM\Query\Expr\Join;
7 7
 use Doctrine\ORM\QueryBuilder;
8
-
9 8
 use Oro\Bundle\FilterBundle\Datasource\FilterDatasourceAdapterInterface;
10 9
 use Oro\Bundle\FilterBundle\Datasource\ManyRelationBuilderInterface;
11 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Expression/Date/ExpressionResult.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\FilterBundle\Expression\Date;
4 4
 
5 5
 use Carbon\Carbon;
6
-
7 6
 use Oro\Bundle\FilterBundle\Expression\Exception\ExpressionDenied;
8 7
 use Oro\Bundle\FilterBundle\Expression\Exception\SyntaxException;
9 8
 use Oro\Bundle\FilterBundle\Provider\DateModifierInterface;
Please login to merge, or discard this patch.
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@
 block discarded – undo
32 32
     /** @var mixed */
33 33
     private $value;
34 34
 
35
+    /**
36
+     * @param string $timezone
37
+     */
35 38
     public function __construct($value, $timezone = null)
36 39
     {
37 40
         $timezone = $timezone ? : 'UTC';
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Expression/Date/Lexer.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\FilterBundle\Expression\Date;
4 4
 
5 5
 use Symfony\Component\Translation\TranslatorInterface;
6
-
7 6
 use Oro\Bundle\FilterBundle\Provider\DateModifierProvider;
8 7
 use Oro\Bundle\FilterBundle\Expression\Exception\SyntaxException;
9 8
 
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Filter/AbstractDateFilter.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -106,8 +106,8 @@
 block discarded – undo
106 106
      * Apply expression using one condition (less or more)
107 107
      *
108 108
      * @param FilterDatasourceAdapterInterface $ds
109
-     * @param                                  $dateValue
110
-     * @param                                  $dateParameterName
109
+     * @param                                  string $dateValue
110
+     * @param                                  string $dateParameterName
111 111
      * @param string                           $fieldName
112 112
      * @param bool                             $isLess less/more mode, true if 'less than', false if 'more than'
113 113
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\FilterBundle\Filter;
4 4
 
5 5
 use Symfony\Component\Form\FormFactoryInterface;
6
-
7 6
 use Oro\Bundle\FilterBundle\Datasource\FilterDatasourceAdapterInterface;
8 7
 use Oro\Bundle\FilterBundle\Form\Type\Filter\DateRangeFilterType;
9 8
 
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Filter/ChoiceFilter.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,9 +3,7 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\FilterBundle\Filter;
4 4
 
5 5
 use Doctrine\Common\Collections\Collection;
6
-
7 6
 use Symfony\Component\Form\Extension\Core\View\ChoiceView;
8
-
9 7
 use Oro\Bundle\FilterBundle\Datasource\FilterDatasourceAdapterInterface;
10 8
 use Oro\Bundle\FilterBundle\Form\Type\Filter\ChoiceFilterType;
11 9
 
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Filter/DictionaryFilter.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -127,7 +127,7 @@
 block discarded – undo
127 127
      *
128 128
      * @param string $value
129 129
      *
130
-     * @return mixed
130
+     * @return string
131 131
      */
132 132
     protected function parseValue($value)
133 133
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Oro\Bundle\FilterBundle\Datasource\Orm\OrmFilterDatasourceAdapter;
6 6
 use Oro\Bundle\FilterBundle\Form\Type\Filter\DictionaryFilterType;
7 7
 use Oro\Bundle\FilterBundle\Datasource\FilterDatasourceAdapterInterface;
8
-
9 8
 use LogicException;
10 9
 
11 10
 class DictionaryFilter extends AbstractFilter
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Form/EventListener/DateFilterSubscriber.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -157,9 +157,9 @@  discard block
 block discarded – undo
157 157
     /**
158 158
      * Call callback for each of given value, used instead of array_map to walk safely through array
159 159
      *
160
-     * @param array    $keys
160
+     * @param integer[]    $keys
161 161
      * @param array    $data
162
-     * @param callable $callback
162
+     * @param \Closure $callback
163 163
      */
164 164
     private function mapValues(array $keys, array &$data, \Closure $callback)
165 165
     {
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      *
176 176
      * @param string $part
177 177
      *
178
-     * @return callable
178
+     * @return \Closure
179 179
      */
180 180
     private function getDatePartAccessorClosure($part)
181 181
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -7,7 +7,6 @@
 block discarded – undo
7 7
 use Symfony\Component\Form\FormInterface;
8 8
 use Symfony\Component\EventDispatcher\EventSubscriberInterface;
9 9
 use Symfony\Component\Validator\Exception\UnexpectedTypeException;
10
-
11 10
 use Oro\Bundle\FilterBundle\Expression\Date\Compiler;
12 11
 use Oro\Bundle\FilterBundle\Provider\DateModifierInterface;
13 12
 
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Form/Type/Filter/AbstractDateFilterType.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -64,7 +64,7 @@
 block discarded – undo
64 64
     }
65 65
 
66 66
     /**
67
-     * @return array
67
+     * @return string[]
68 68
      */
69 69
     public function getOperatorChoices()
70 70
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Component\Form\FormView;
10 10
 use Symfony\Component\OptionsResolver\OptionsResolverInterface;
11 11
 use Symfony\Component\Translation\TranslatorInterface;
12
-
13 12
 use Oro\Bundle\FilterBundle\Provider\DateModifierProvider;
14 13
 use Oro\Bundle\FilterBundle\Provider\DateModifierInterface;
15 14
 
Please login to merge, or discard this patch.