Completed
Push — 1.8 ( b7094f...f1162e )
by
unknown
83:38 queued 61:44
created
src/Oro/Bundle/DistributionBundle/Controller/PackageController.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -236,7 +236,7 @@
 block discarded – undo
236 236
     /**
237 237
      * @param array $params
238 238
      * @param string $paramName
239
-     * @param mixed $defaultValue
239
+     * @param null|false $defaultValue
240 240
      *
241 241
      * @return mixed
242 242
      */
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Manager/PackageManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@
 block discarded – undo
199 199
 
200 200
     /**
201 201
      * @param string $packageName
202
-     * @param mixed $version
202
+     * @param string|null $version
203 203
      *
204 204
      * @return PackageInterface
205 205
      * @throws \RuntimeException
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -17,9 +17,7 @@
 block discarded – undo
17 17
 use Composer\Repository\CompositeRepository;
18 18
 use Composer\Repository\PlatformRepository;
19 19
 use Composer\Repository\RepositoryInterface;
20
-
21 20
 use Psr\Log\LoggerInterface;
22
-
23 21
 use Oro\Bundle\DistributionBundle\Entity\PackageRequirement;
24 22
 use Oro\Bundle\DistributionBundle\Entity\PackageUpdate;
25 23
 use Oro\Bundle\DistributionBundle\Exception\VerboseException;
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/OroKernel.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@
 block discarded – undo
81 81
     /**
82 82
      * Finds all .../Resource/config/oro/bundles.yml in given root folders
83 83
      *
84
-     * @param array $roots
84
+     * @param string[] $roots
85 85
      *
86 86
      * @return array
87 87
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@  discard block
 block discarded – undo
3 3
 namespace Oro\Bundle\DistributionBundle;
4 4
 
5 5
 use OroRequirements;
6
-
7 6
 use Symfony\Component\HttpKernel\Kernel;
8 7
 use Symfony\Component\Config\ConfigCache;
9 8
 use Symfony\Component\Yaml\Yaml;
@@ -12,7 +11,6 @@  discard block
 block discarded – undo
12 11
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBag;
13 12
 use Symfony\Bridge\ProxyManager\LazyProxy\PhpDumper\ProxyDumper;
14 13
 use Symfony\Bridge\ProxyManager\LazyProxy\Instantiator\RuntimeInstantiator;
15
-
16 14
 use Oro\Component\Config\CumulativeResourceManager;
17 15
 use Oro\Bundle\DistributionBundle\DependencyInjection\OroContainerBuilder;
18 16
 use Oro\Bundle\DistributionBundle\Dumper\PhpBundlesDumper;
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Script/Runner.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -319,7 +319,7 @@
 block discarded – undo
319 319
      * @param string $commandPrefix
320 320
      * @param int $commandSize - windows shell-command is limited by 8kb
321 321
      *
322
-     * @return array of commands to be executed
322
+     * @return string[] of commands to be executed
323 323
      */
324 324
     protected function makeCommands(array $paths, $commandPrefix, $commandSize = 8000)
325 325
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use Symfony\Component\Finder\SplFileInfo;
10 10
 use Symfony\Component\Process\Exception\ProcessFailedException;
11 11
 use Symfony\Component\Process\Process;
12
-
13 12
 use Oro\Bundle\InstallerBundle\Process\PhpExecutableFinder;
14 13
 
15 14
 class Runner
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Test/PhpUnit/Helper/MockHelperTrait.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,7 @@
 block discarded – undo
5 5
 {
6 6
     /**
7 7
      * @param string $className
8
-     * @return \PHPUnit_Framework_MockObject_MockObject
8
+     * @return \Symfony\Component\Form\FormBuilderInterface
9 9
      */
10 10
     protected function createConstructorLessMock($className)
11 11
     {
Please login to merge, or discard this patch.
Oro/Bundle/DistributionBundle/Test/PhpUnit/Helper/ReflectionHelperTrait.php 1 patch
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -5,8 +5,8 @@  discard block
 block discarded – undo
5 5
 trait ReflectionHelperTrait
6 6
 {
7 7
     /**
8
-     * @param mixed $class
9
-     * @param mixed $subclass
8
+     * @param string $class
9
+     * @param string $subclass
10 10
      */
11 11
     public function assertSubclassOf($class, $subclass)
12 12
     {
@@ -15,8 +15,8 @@  discard block
 block discarded – undo
15 15
     }
16 16
 
17 17
     /**
18
-     * @param mixed $interface
19
-     * @param mixed $class
18
+     * @param string $interface
19
+     * @param string $class
20 20
      */
21 21
     public function assertImplementsInterface($interface, $class)
22 22
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Tests/Functional/Script/RunnerTest.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -283,7 +283,7 @@  discard block
 block discarded – undo
283 283
      * @param \Composer\Package\PackageInterface $package
284 284
      * @param string $targetDir
285 285
      *
286
-     * @return \PHPUnit_Framework_MockObject_MockObject|InstallationManager
286
+     * @return InstallationManager
287 287
      */
288 288
     protected function createInstallationManagerMock(PackageInterface $package = null, $targetDir = null)
289 289
     {
@@ -299,9 +299,9 @@  discard block
 block discarded – undo
299 299
     }
300 300
 
301 301
     /**
302
-     * @param $annotationLabel
303
-     * @param $pathToFile
304
-     * @param $scriptOutput
302
+     * @param string $annotationLabel
303
+     * @param string $pathToFile
304
+     * @param string $scriptOutput
305 305
      *
306 306
      * @return string
307 307
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Composer\Installer\InstallationManager;
6 6
 use Composer\Package\PackageInterface;
7 7
 use Psr\Log\LoggerInterface;
8
-
9 8
 use Oro\Bundle\DistributionBundle\Script\Runner;
10 9
 use Oro\Bundle\TestFrameworkBundle\Test\WebTestCase;
11 10
 
Please login to merge, or discard this patch.
DistributionBundle/Tests/Unit/Manager/Helper/ChangeSetBuilderTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 
4 4
 use Composer\Package\PackageInterface;
5 5
 use Oro\Bundle\DistributionBundle\Manager\Helper\ChangeSetBuilder;
6
-use Oro\Bundle\DistributionBundle\Test\PhpUnit\Helper\MockHelperTrait;
7 6
 
8 7
 class ChangeSetBuilderTest extends \PHPUnit_Framework_TestCase
9 8
 {
Please login to merge, or discard this patch.
src/Oro/Bundle/DistributionBundle/Tests/Unit/Routing/AbstractLoaderTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -7,9 +7,7 @@
 block discarded – undo
7 7
 use Symfony\Component\EventDispatcher\EventDispatcherInterface;
8 8
 use Symfony\Component\HttpKernel\KernelInterface;
9 9
 use Symfony\Component\Routing\Loader\YamlFileLoader;
10
-
11 10
 use Oro\Component\Routing\Resolver\RouteOptionsResolverInterface;
12
-
13 11
 use Oro\Bundle\DistributionBundle\Event\RouteCollectionEvent;
14 12
 use Oro\Bundle\DistributionBundle\Routing\AbstractLoader;
15 13
 
Please login to merge, or discard this patch.