orocrm / platform

src/Oro/Bundle/TagBundle/Entity/TagManager.php

Unused Use Statements -3 removed lines

@@ -2,13 +2,10 @@
 
 namespace Oro\Bundle\TagBundle\Entity;
 
-use Doctrine\ORM\Query\Expr;
 use Doctrine\ORM\EntityManager;
 use Doctrine\Common\Util\ClassUtils;
 use Doctrine\Common\Collections\ArrayCollection;
-
 use Symfony\Bundle\FrameworkBundle\Routing\Router;
-
 use Oro\Bundle\SecurityBundle\SecurityFacade;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
 use Oro\Bundle\UserBundle\Entity\User;

Doc Comments +4 added lines, -4 removed lines

@@ -124,8 +124,8 @@ 
     /**
      * Adds multiple tags on the given entity
      *
-     * @param Collection|Tag[] $tags   Array of Tag objects
-     * @param object           $entity entity
+     * @param Tag[] $tags   Array of Tag objects
+     * @param \PHPUnit_Framework_MockObject_MockObject           $entity entity
      */
     public function addTags($tags, $entity)
     {
@@ -153,7 +153,7 @@ 
      *
      * @param object                 $entity
      * @param User|null              $owner
-     * @param Collection|Tag[]|int[] $tags
+     * @param Collection $tags
      *
      * @return int
      */
@@ -410,7 +410,7 @@ 
     /**
      * @param Tag $tag
      *
-     * @return callable
+     * @return \Closure
      *
      * @deprecated Use {@see getComparePredicate} instead
      */

src/Oro/Bundle/TagBundle/Provider/SearchProvider.php

Doc Comments +1 added lines

@@ -57,6 +57,7 @@
 
     /**
      * {@inheritdoc}
+     * @param integer $tagId
      */
     public function getResults($tagId)
     {

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/TagBundle/Tests/Selenium/TagsAcl.php

Doc Comments +24 added lines

@@ -127,6 +127,10 @@ 
         }
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function deleteAcl($login, $role, $username, $tagName)
     {
         /** @var Roles $login*/
@@ -143,6 +147,10 @@ 
             ->checkContextMenu($tagName, 'Delete');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function updateAcl($login, $role, $username, $tagName)
     {
         /** @var Roles $login*/
@@ -159,6 +167,10 @@ 
             ->checkContextMenu($tagName, 'Update');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function createAcl($login, $role, $username)
     {
         /** @var Roles $login*/
@@ -175,6 +187,10 @@ 
             ->assertElementNotPresent("//div[@class = 'container-fluid']//a[contains(., 'Create Tag')]");
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function viewListAcl($login, $role, $username)
     {
         /** @var Roles $login*/
@@ -191,6 +207,10 @@ 
             ->assertTitle('403 - Forbidden');
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $roleName
+     */
     public function unassignGlobalAcl($login, $roleName, $tagName)
     {
         $username = 'user' . mt_rand();
@@ -229,6 +249,10 @@ 
             );
     }
 
+    /**
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
+     * @param string $role
+     */
     public function assignAcl($login, $role, $username)
     {
         /** @var Roles $login*/

src/Oro/Bundle/TestFrameworkBundle/Pages/AbstractPageGrid.php

Doc Comments +5 added lines, -5 removed lines

@@ -24,7 +24,7 @@ 
     abstract public function entityView();
 
     /**
-     * @param array $entityData
+     * @param string[] $entityData
      *
      * @return mixed
      */
@@ -166,7 +166,7 @@ 
      * Get all elements from data grid
      *
      * @param null|int $id
-     * @return array PHPUnit_Extensions_Selenium2TestCase_Element
+     * @return \PHPUnit_Extensions_Selenium2TestCase_Element[] PHPUnit_Extensions_Selenium2TestCase_Element
      */
     public function getRows($id = null)
     {
@@ -401,7 +401,7 @@ 
     }
 
     /**
-     * @param $columnName
+     * @param string $columnName
      * @param string $order DESC or ASC
      * @return $this
      */
@@ -436,7 +436,7 @@ 
     /**
      * Change page size
      *
-     * @param string|int $pageSize
+     * @param string $pageSize
      * @return $this
      */
     public function changePageSize($pageSize)
@@ -484,7 +484,7 @@ 
 
     /**
      * Method checks if no item in action grid menu
-     * @param $actionName
+     * @param string $actionName
      * @return $this
      * @throws  \PHPUnit_Framework_AssertionFailedError
      */

src/Oro/Bundle/TestFrameworkBundle/Pages/FilteredGridTrait.php

Doc Comments +2 added lines, -2 removed lines

@@ -50,8 +50,8 @@
 
     /**
      * Method to filter grid by Multiselect filter
-     * @param $filterName
-     * @param array $values
+     * @param string $filterName
+     * @param string[] $values
      * @return $this
      */
     public function filterByMultiselect($filterName, $values)

src/Oro/Bundle/TestFrameworkBundle/Test/Client.php

Doc Comments +2 added lines

@@ -36,6 +36,8 @@
 
     /**
      * {@inheritdoc}
+     * @param string $method
+     * @param string $uri
      */
     public function request(
         $method,

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/TestFrameworkBundle/Test/DependencyInjection/ExtensionTestCase.php

Doc Comments +1 added lines, -1 removed lines

@@ -110,7 +110,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\DependencyInjection\ContainerBuilder
+     * @return \Symfony\Component\DependencyInjection\ContainerBuilder
      */
     protected function getContainerMock()
     {

src/Oro/Bundle/TestFrameworkBundle/Test/WebTestCase.php

Doc Comments +2 added lines, -2 removed lines

@@ -313,7 +313,7 @@ 
     }
 
     /**
-     * @param array $classNames
+     * @param string[] $classNames
      * @param bool  $force
      */
     protected function loadFixtures(array $classNames, $force = false)
@@ -354,7 +354,7 @@ 
     }
 
     /**
-     * @return ReferenceRepository|null
+     * @return ReferenceRepository
      */
     protected function getReferenceRepository()
     {

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/ThemeBundle/Command/ThemeCommand.php

Doc Comments +3 added lines

@@ -52,6 +52,9 @@
         }
     }
 
+    /**
+     * @param boolean $isActive
+     */
     protected function outputTheme(OutputInterface $output, Theme $theme, $isActive)
     {
         if ($isActive) {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;