Completed
Push — master ( bc9b71...b8b5e6 )
by
unknown
63:33
created
Tests/Unit/ImportExport/Strategy/EntityFieldImportStrategyTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@
 block discarded – undo
186 186
     }
187 187
 
188 188
     /**
189
-     * @param object $object
189
+     * @param EntityFieldImportStrategy $object
190 190
      * @param string $property
191 191
      * @return mixed $value
192 192
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
      *
95 95
      * @param string $className
96 96
      *
97
-     * @return array [$moduleName, $entityName]
97
+     * @return string[] [$moduleName, $entityName]
98 98
      */
99 99
     public static function getModuleAndEntityNames($className)
100 100
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigLoader.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
      * Load entity configs from annotations to a database
38 38
      *
39 39
      * @param bool                 $force  Force overwrite config's option values
40
-     * @param callable|null        $filter function (ClassMetadata[] $doctrineAllMetadata)
40
+     * @param null|\Closure        $filter function (ClassMetadata[] $doctrineAllMetadata)
41 41
      * @param LoggerInterface|null $logger
42 42
      * @param bool                 $dryRun Log modifications without apply them
43 43
      *
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Entity/Manager/AssociationManager.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      * @param string $attribute The name of the entity config attribute which indicates
104 104
      *                          whether the association is enabled or not
105 105
      *
106
-     * @return callable
106
+     * @return \Closure
107 107
      */
108 108
     public function getSingleOwnerFilter($scope, $attribute = 'enabled')
109 109
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      * @param string $attribute The name of the entity config attribute which is used to store
122 122
      *                          enabled associations
123 123
      *
124
-     * @return callable
124
+     * @return \Closure
125 125
      */
126 126
     public function getMultiOwnerFilter($scope, $attribute)
127 127
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Form/Guesser/ExtendFieldTypeGuesser.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace Oro\Bundle\EntityExtendBundle\Form\Guesser;
4 4
 
5
-use Symfony\Component\Form\Guess;
6
-
7 5
 use Doctrine\Common\Persistence\ManagerRegistry;
8
-
9 6
 use Oro\Bundle\EntityBundle\Form\Guesser\AbstractFormGuesser;
10 7
 use Oro\Bundle\EntityConfigBundle\Config\ConfigInterface;
11 8
 use Oro\Bundle\EntityConfigBundle\Config\Id\FieldConfigId;
@@ -15,7 +12,6 @@  discard block
 block discarded – undo
15 12
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendConfigDumper;
16 13
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
17 14
 use Oro\Bundle\EntityExtendBundle\Validator\Constraints\Decimal;
18
-
19 15
 use Symfony\Component\Validator\Constraints\Length;
20 16
 
21 17
 class ExtendFieldTypeGuesser extends AbstractFormGuesser
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Migration/ExtendOptionsBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@
 block discarded – undo
234 234
      *
235 235
      * @param array  $options
236 236
      * @param string $name
237
-     * @return mixed
237
+     * @return string|null
238 238
      */
239 239
     protected function getAndRemoveOption(array &$options, $name)
240 240
     {
Please login to merge, or discard this patch.
EntityExtendBundle/Migrations/Schema/v1_0/RenameExtendTablesAndColumns.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -226,6 +226,9 @@  discard block
 block discarded – undo
226 226
         }
227 227
     }
228 228
 
229
+    /**
230
+     * @param string $associationName
231
+     */
229 232
     protected function renameManyToOneExtendField(
230 233
         Schema $schema,
231 234
         QueryBag $queries,
@@ -247,6 +250,9 @@  discard block
 block discarded – undo
247 250
         }
248 251
     }
249 252
 
253
+    /**
254
+     * @param string $associationName
255
+     */
250 256
     protected function renameOneToManyExtendField(
251 257
         Schema $schema,
252 258
         QueryBag $queries,
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\HttpFoundation\JsonResponse;
6 6
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7
-
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10
-
11 9
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
12 10
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
13 11
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
14
-
15 12
 use Oro\Bundle\UserBundle\Entity\User;
16 13
 use Oro\Bundle\UserBundle\Entity\UserApi;
17
-
18 14
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
19 15
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
20 16
 
Please login to merge, or discard this patch.
Oro/Bundle/EntityExtendBundle/Tests/Unit/Form/Type/EnumValueTypeTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -267,7 +267,7 @@
 block discarded – undo
267 267
     }
268 268
 
269 269
     /**
270
-     * @return \PHPUnit_Framework_MockObject_MockObject|ConstraintValidatorFactoryInterface
270
+     * @return ConstraintValidatorFactoryInterface
271 271
      */
272 272
     protected function getConstraintValidatorFactory()
273 273
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Bundle/EntityExtendBundle/Tests/Unit/Grid/AdditionalFieldsExtensionTest.php 1 patch
Doc Comments   +5 added lines patch added patch discarded remove patch
@@ -490,6 +490,11 @@
 block discarded – undo
490 490
         );
491 491
     }
492 492
 
493
+    /**
494
+     * @param string $className
495
+     * @param string $fieldName
496
+     * @param string $fieldType
497
+     */
493 498
     protected function setExpectationForGetFields($className, $fieldName, $fieldType, array $extendFieldConfig = [])
494 499
     {
495 500
         $extendConfig = new Config(new FieldConfigId('extend', $className, $fieldName, $fieldType));
Please login to merge, or discard this patch.