Completed
Pull Request — master (#364)
by Sufijen
89:03 queued 39:04
created
src/Oro/Bundle/EmailBundle/Manager/EmailNotificationManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@
 block discarded – undo
125 125
     /**
126 126
      * @param Email $email
127 127
      *
128
-     * @return bool|string
128
+     * @return false|string
129 129
      */
130 130
     protected function getFromNameLink(Email $email)
131 131
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Model/Recipient.php 1 patch
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,6 @@
 block discarded – undo
17 17
      * @param string $email
18 18
      * @param string $name
19 19
      * @param RecipientEntity|null $entity
20
-     * @param string|null $organization
21 20
      */
22 21
     public function __construct($email, $name, RecipientEntity $entity = null)
23 22
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/OroEmailBundle.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -7,9 +7,7 @@  discard block
 block discarded – undo
7 7
 use Symfony\Component\Filesystem\Filesystem;
8 8
 use Symfony\Component\HttpKernel\Bundle\Bundle;
9 9
 use Symfony\Component\HttpKernel\KernelInterface;
10
-
11 10
 use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass;
12
-
13 11
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailBodyLoaderPass;
14 12
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailOwnerConfigurationPass;
15 13
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailSynchronizerPass;
@@ -17,7 +15,6 @@  discard block
 block discarded – undo
17 15
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\MailboxProcessPass;
18 16
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\TwigSandboxConfigurationPass;
19 17
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailFlagManagerLoaderPass;
20
-use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailFolderLoaderPass;
21 18
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailRecipientsProviderPass;
22 19
 
23 20
 class OroEmailBundle extends Bundle
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Provider/EmailRecipientsHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -229,7 +229,7 @@
 block discarded – undo
229 229
 
230 230
     /**
231 231
      * @param EmailRecipientsProviderArgs $args
232
-     * @param object|null $object
232
+     * @param \Oro\Bundle\EmailBundle\Entity\EmailOwnerInterface|null $object
233 233
      *
234 234
      * @return bool
235 235
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Provider/EmailRenderer.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@  discard block
 block discarded – undo
143 143
      * @param EmailTemplateInterface $template
144 144
      * @param array                  $templateParams
145 145
      *
146
-     * @return array first element is email subject, second - message
146
+     * @return string[] first element is email subject, second - message
147 147
      */
148 148
     public function compileMessage(EmailTemplateInterface $template, array $templateParams = [])
149 149
     {
@@ -206,7 +206,7 @@  discard block
 block discarded – undo
206 206
      * @param string $template
207 207
      * @param object $entity
208 208
      *
209
-     * @return EmailTemplate
209
+     * @return string
210 210
      */
211 211
     protected function processDefaultFilters($template, $entity)
212 212
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Provider/RecentEmailRecipientsProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -97,7 +97,7 @@
 block discarded – undo
97 97
     }
98 98
 
99 99
     /**
100
-     * @param object|null $owner
100
+     * @param \Oro\Bundle\EmailBundle\Entity\EmailOwnerInterface|null $owner
101 101
      *
102 102
      * @return RecipientEntity|null
103 103
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Sync/AbstractEmailSynchronizationProcessor.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -111,8 +111,8 @@  discard block
 block discarded – undo
111 111
 
112 112
     /**
113 113
      * @param EmailHeader $email
114
-     * @param             $folderType
115
-     * @param             $organization
114
+     * @param             string $folderType
115
+     * @param             OrganizationInterface $organization
116 116
      *
117 117
      * @return bool
118 118
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -292,7 +292,7 @@  discard block
 block discarded – undo
292 292
 
293 293
     /**
294 294
      * @param EmailFolder $folder
295
-     * @param array       $messageIds
295
+     * @param string[]       $messageIds
296 296
      * @return EmailUser[]
297 297
      */
298 298
     protected function getExistingEmailUsers(EmailFolder $folder, array $messageIds)
@@ -356,7 +356,7 @@  discard block
 block discarded – undo
356 356
     }
357 357
 
358 358
     /**
359
-     * @return array
359
+     * @return string[]
360 360
      */
361 361
     protected function entitiesToClear()
362 362
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,8 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\Sync;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-use Doctrine\ORM\Query;
7
-
8 6
 use Psr\Log\LoggerAwareInterface;
9 7
 use Psr\Log\LoggerAwareTrait;
10
-
11 8
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
12 9
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
13 10
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Sync/AbstractEmailSynchronizer.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -308,7 +308,7 @@  discard block
 block discarded – undo
308 308
     /**
309 309
      * Creates a processor is used to synchronize emails
310 310
      *
311
-     * @param object $origin An instance of class implementing EmailOrigin entity
311
+     * @param EmailOrigin $origin An instance of class implementing EmailOrigin entity
312 312
      * @return AbstractEmailSynchronizationProcessor
313 313
      */
314 314
     abstract protected function createSynchronizationProcessor($origin);
@@ -423,7 +423,7 @@  discard block
 block discarded – undo
423 423
      * Finds active email origin by its id
424 424
      *
425 425
      * @param int $originId
426
-     * @return EmailOrigin|null
426
+     * @return EmailOrigin
427 427
      */
428 428
     protected function findOrigin($originId)
429 429
     {
Please login to merge, or discard this patch.
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -4,16 +4,11 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Persistence\ManagerRegistry;
6 6
 use Doctrine\ORM\EntityManager;
7
-use Doctrine\ORM\Query;
8
-use Doctrine\ORM\Query\Expr;
9
-
10 7
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
11 8
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
12
-
13 9
 use Psr\Log\LoggerAwareInterface;
14 10
 use Psr\Log\LoggerAwareTrait;
15 11
 use Psr\Log\NullLogger;
16
-
17 12
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
18 13
 use Oro\Bundle\EmailBundle\Exception\SyncFolderTimeoutException;
19 14
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmailBundle/Sync/KnownEmailAddressChecker.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,11 +3,8 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EmailBundle\Sync;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-use Doctrine\ORM\Query;
7
-
8 6
 use Psr\Log\LoggerAwareInterface;
9 7
 use Psr\Log\LoggerAwareTrait;
10
-
11 8
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
12 9
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
13 10
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;
Please login to merge, or discard this patch.