Completed
Pull Request — master (#352)
by php-br
61:36
created
src/Oro/Bundle/AttachmentBundle/Controller/AttachmentController.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -5,15 +5,11 @@
 block discarded – undo
5 5
 use Symfony\Component\Form\FormInterface;
6 6
 use Symfony\Component\Security\Core\Util\ClassUtils;
7 7
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
8
-
9 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
10 9
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
11
-
12 10
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
13
-
14 11
 use Oro\Bundle\AttachmentBundle\Manager\AttachmentManager;
15 12
 use Oro\Bundle\AttachmentBundle\Entity\Attachment;
16
-
17 13
 use Oro\Bundle\EntityBundle\Tools\EntityRoutingHelper;
18 14
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
19 15
 
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Controller/FileController.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -7,11 +7,8 @@
 block discarded – undo
7 7
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
8 8
 use Symfony\Component\PropertyAccess\PropertyAccess;
9 9
 use Symfony\Component\Security\Core\Exception\AccessDeniedException;
10
-
11 10
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
12
-
13 11
 use Oro\Bundle\AttachmentBundle\Entity\File;
14
-
15 12
 use Doctrine\Common\Collections\Collection;
16 13
 
17 14
 class FileController extends Controller
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/EventListener/AttachmentGridListener.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@
 block discarded – undo
16 16
     protected $paramsToBind = [];
17 17
 
18 18
     /**
19
-     * @param array $paramsToBind
19
+     * @param string[] $paramsToBind
20 20
      */
21 21
     public function __construct($paramsToBind = [])
22 22
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Form/Handler/AttachmentHandler.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Form\FormInterface;
6 6
 use Symfony\Component\HttpFoundation\Request;
7
-
8 7
 use Doctrine\Common\Persistence\ObjectManager;
9
-
10 8
 use Oro\Bundle\AttachmentBundle\Entity\Attachment;
11 9
 
12 10
 class AttachmentHandler
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Manager/AttachmentManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -291,7 +291,7 @@
 block discarded – undo
291 291
     /**
292 292
      * Return url parameters from encoded string
293 293
      *
294
-     * @param $urlString
294
+     * @param string $urlString
295 295
      * @return array
296 296
      *   - parent class
297 297
      *   - field name
Please login to merge, or discard this patch.
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -3,22 +3,17 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\AttachmentBundle\Manager;
4 4
 
5 5
 use Doctrine\ORM\EntityManager;
6
-
7 6
 use Gaufrette\Stream;
8
-
9 7
 use Symfony\Component\Security\Core\Util\ClassUtils;
10 8
 use Symfony\Component\HttpFoundation\File\UploadedFile;
11 9
 use Symfony\Bundle\FrameworkBundle\Routing\Router;
12 10
 use Symfony\Component\Filesystem\Filesystem as SymfonyFileSystem;
13 11
 use Symfony\Component\HttpFoundation\File\File as FileType;
14
-
15 12
 use Knp\Bundle\GaufretteBundle\FilesystemMap;
16
-
17 13
 use Gaufrette\Filesystem;
18 14
 use Gaufrette\StreamMode;
19 15
 use Gaufrette\Adapter\MetadataSupporter;
20 16
 use Gaufrette\Stream\Local as LocalStream;
21
-
22 17
 use Oro\Bundle\AttachmentBundle\Entity\File;
23 18
 use Oro\Bundle\AttachmentBundle\EntityConfig\AttachmentScope;
24 19
 use Oro\Bundle\EntityConfigBundle\DependencyInjection\Utils\ServiceLink;
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Migration/Extension/AttachmentExtension.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\AttachmentBundle\Migration\Extension;
4 4
 
5 5
 use Doctrine\DBAL\Schema\Schema;
6
-
7 6
 use Oro\Bundle\EntityExtendBundle\Migration\Extension\ExtendExtension;
8 7
 use Oro\Bundle\EntityExtendBundle\Migration\Extension\ExtendExtensionAwareInterface;
9 8
 use Oro\Bundle\EntityExtendBundle\Migration\OroOptions;
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Model/ExtendAttachment.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
      *
46 46
      * @param object $target Any configurable entity that can have notes
47 47
      *
48
-     * @return object This object
48
+     * @return ExtendAttachment This object
49 49
      */
50 50
     public function setTarget($target)
51 51
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Provider/AttachmentProvider.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Util\ClassUtils;
6 6
 use Doctrine\ORM\EntityManager;
7
-
8 7
 use Oro\Bundle\AttachmentBundle\Entity\Attachment;
9 8
 use Oro\Bundle\AttachmentBundle\EntityConfig\AttachmentConfig;
10 9
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
Please login to merge, or discard this patch.
src/Oro/Bundle/AttachmentBundle/Tests/Unit/Entity/AttachmentTest.php 1 patch
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -5,7 +5,6 @@
 block discarded – undo
5 5
 use Oro\Bundle\AttachmentBundle\Entity\Attachment;
6 6
 use Oro\Bundle\AttachmentBundle\Entity\File;
7 7
 use Oro\Bundle\AttachmentBundle\Tests\Unit\Fixtures\TestUser;
8
-
9 8
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
10 9
 
11 10
 class AttachmentTest extends EntityTestAbstract
Please login to merge, or discard this patch.