Completed
Push — 1.8 ( 79b91c...110b8e )
by
unknown
85:39 queued 52:15
created
src/Oro/Bundle/EmailBundle/Tests/Unit/Provider/EmailRendererTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -285,7 +285,7 @@
 block discarded – undo
285 285
     }
286 286
 
287 287
     /**
288
-     * @return EmailRenderer|\PHPUnit_Framework_MockObject_MockObject
288
+     * @return string
289 289
      */
290 290
     public function getRendererInstance()
291 291
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EmbeddedFormBundle/Manager/EmbeddedFormManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -33,7 +33,7 @@
 block discarded – undo
33 33
     }
34 34
 
35 35
     /**
36
-     * @param       $type
36
+     * @param       string $type
37 37
      * @param null  $data
38 38
      * @param array $options
39 39
      *
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityBundle/Controller/EntitiesController.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -312,7 +312,7 @@  discard block
 block discarded – undo
312 312
      * @param string $entityName
313 313
      * @param string $id
314 314
      *
315
-     * @return array
315
+     * @return JsonResponse
316 316
      *
317 317
      * @Route(
318 318
      *      "/delete/{entityName}/item/{id}",
@@ -350,7 +350,7 @@  discard block
 block discarded – undo
350 350
      *
351 351
      * @param string $permission
352 352
      * @param string $entityName
353
-     * @return bool
353
+     * @return boolean|null
354 354
      * @throws AccessDeniedException
355 355
      */
356 356
     private function checkAccess($permission, $entityName)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityBundle/ORM/SqlQueryBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -247,7 +247,7 @@
 block discarded – undo
247 247
      * Specifies an item that is to be returned in the query result.
248 248
      * Replaces any previously specified selections, if any.
249 249
      *
250
-     * @param mixed $select The selection expressions.
250
+     * @param null|string $select The selection expressions.
251 251
      *
252 252
      * @return self
253 253
      */
Please login to merge, or discard this patch.
Oro/Bundle/EntityBundle/Tests/Unit/Provider/EntityHierarchyProviderTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -96,7 +96,7 @@
 block discarded – undo
96 96
      * @param \PHPUnit_Framework_MockObject_MockObject|null $emMock
97 97
      * @param boolean                                       $isReturnManager
98 98
      *
99
-     * @return \PHPUnit_Framework_MockObject_MockObject
99
+     * @return \Doctrine\Common\Persistence\ManagerRegistry
100 100
      */
101 101
     protected function getDoctrineMock($emMock = null, $isReturnManager = true)
102 102
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Oro/Bundle/EntityConfigBundle/EventListener/AbstractConfigGridListener.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -262,7 +262,7 @@  discard block
 block discarded – undo
262 262
 
263 263
     /**
264 264
      * @param DatagridConfiguration $config
265
-     * @param                       $itemType
265
+     * @param                       string|null $itemType
266 266
      */
267 267
     protected function addEntityConfigProperties(DatagridConfiguration $config, $itemType)
268 268
     {
@@ -321,7 +321,7 @@  discard block
 block discarded – undo
321 321
      * @param array $filters
322 322
      * @param array $actions
323 323
      *
324
-     * @return callable
324
+     * @return \Closure
325 325
      */
326 326
     public function getActionConfigurationClosure($filters, $actions)
327 327
     {
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,17 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\HttpFoundation\JsonResponse;
6 6
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7
-
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10
-
11 9
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
12 10
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
13 11
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
14
-
15 12
 use Oro\Bundle\UserBundle\Entity\User;
16 13
 use Oro\Bundle\UserBundle\Entity\UserApi;
17
-
18 14
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
19 15
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
20 16
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Form/Type/ConfigScopeType.php 2 patches
Doc Comments   +6 added lines patch added patch discarded remove patch
@@ -218,6 +218,9 @@  discard block
 block discarded – undo
218 218
         return $values;
219 219
     }
220 220
 
221
+    /**
222
+     * @param string $cssClass
223
+     */
221 224
     protected function appendClassAttr(array &$options, $cssClass)
222 225
     {
223 226
         if (isset($options['attr']['class'])) {
@@ -227,6 +230,9 @@  discard block
 block discarded – undo
227 230
         }
228 231
     }
229 232
 
233
+    /**
234
+     * @param string $name
235
+     */
230 236
     protected function setAttr(array &$options, $name, $value)
231 237
     {
232 238
         if (!isset($options['attr'])) {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
      *
95 95
      * @param string $className
96 96
      *
97
-     * @return array [$moduleName, $entityName]
97
+     * @return string[] [$moduleName, $entityName]
98 98
      */
99 99
     public static function getModuleAndEntityNames($className)
100 100
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Entity/Manager/AssociationManager.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      * @param string $attribute The name of the entity config attribute which indicates
104 104
      *                          whether the association is enabled or not
105 105
      *
106
-     * @return callable
106
+     * @return \Closure
107 107
      */
108 108
     public function getSingleOwnerFilter($scope, $attribute = 'enabled')
109 109
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      * @param string $attribute The name of the entity config attribute which is used to store
122 122
      *                          enabled associations
123 123
      *
124
-     * @return callable
124
+     * @return \Closure
125 125
      */
126 126
     public function getMultiOwnerFilter($scope, $attribute)
127 127
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.