orocrm / platform

src/Oro/Bundle/EmailBundle/Sync/AbstractEmailSynchronizationProcessor.php

Doc Comments +4 added lines, -4 removed lines

@@ -111,8 +111,8 @@ 
 
     /**
      * @param EmailHeader $email
-     * @param             $folderType
-     * @param             $organization
+     * @param             string $folderType
+     * @param             OrganizationInterface $organization
      *
      * @return bool
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -292,7 +292,7 @@ 
 
     /**
      * @param EmailFolder $folder
-     * @param array       $messageIds
+     * @param string[]       $messageIds
      * @return EmailUser[]
      */
     protected function getExistingEmailUsers(EmailFolder $folder, array $messageIds)
@@ -356,7 +356,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     protected function entitiesToClear()
     {

Unused Use Statements -3 removed lines

@@ -3,11 +3,8 @@
 namespace Oro\Bundle\EmailBundle\Sync;
 
 use Doctrine\ORM\EntityManager;
-use Doctrine\ORM\Query;
-
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
-
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;

src/Oro/Bundle/EmailBundle/Sync/AbstractEmailSynchronizer.php

Doc Comments +2 added lines, -2 removed lines

@@ -308,7 +308,7 @@ 
     /**
      * Creates a processor is used to synchronize emails
      *
-     * @param object $origin An instance of class implementing EmailOrigin entity
+     * @param EmailOrigin $origin An instance of class implementing EmailOrigin entity
      * @return AbstractEmailSynchronizationProcessor
      */
     abstract protected function createSynchronizationProcessor($origin);
@@ -423,7 +423,7 @@ 
      * Finds active email origin by its id
      *
      * @param int $originId
-     * @return EmailOrigin|null
+     * @return EmailOrigin
      */
     protected function findOrigin($originId)
     {

Unused Use Statements -5 removed lines

@@ -4,16 +4,11 @@
 
 use Doctrine\Common\Persistence\ManagerRegistry;
 use Doctrine\ORM\EntityManager;
-use Doctrine\ORM\Query;
-use Doctrine\ORM\Query\Expr;
-
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
-
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
 use Psr\Log\NullLogger;
-
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
 use Oro\Bundle\EmailBundle\Exception\SyncFolderTimeoutException;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;

src/Oro/Bundle/EmailBundle/Sync/KnownEmailAddressChecker.php

Unused Use Statements -3 removed lines

@@ -3,11 +3,8 @@
 namespace Oro\Bundle\EmailBundle\Sync;
 
 use Doctrine\ORM\EntityManager;
-use Doctrine\ORM\Query;
-
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
-
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;

src/Oro/Bundle/EmailBundle/Tests/Functional/DataFixtures/LoadEmailActivityData.php

Doc Comments +3 added lines, -3 removed lines

@@ -95,9 +95,9 @@
      * @param string               $subject
      * @param string               $messageId
      * @param string               $from
-     * @param string|string[]      $to
-     * @param string|string[]|null $cc
-     * @param string|string[]|null $bcc
+     * @param string      $to
+     * @param string $cc
+     * @param string $bcc
      *
      * @return Email
      */

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/EmailBundle/Tests/Unit/Builder/Helper/EmailModelBuilderHelperTest.php

Doc Comments -1 removed lines

@@ -366,7 +366,6 @@
 
     /**
      * @param object $user
-     * @param mixed  $expected
      *
      * @dataProvider getUserProvider
      */

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/EmailBundle/Tests/Unit/Entity/Manager/EmailActivityManagerTest.php

Doc Comments +3 added lines, -3 removed lines

@@ -236,7 +236,7 @@ 
      * @param integer $id
      * @param integer $thread
 
-     * @return Email|\PHPUnit_Framework_MockObject_MockObject
+     * @return Email
      */
     protected function getEmailEntity($id = null, $thread = null)
     {
@@ -262,7 +262,7 @@ 
 
     /**
      * @param Email       $email
-     * @param object|null $owner
+     * @param TestUser $owner
      */
     protected function addEmailSender(Email $email, $owner = null)
     {
@@ -274,7 +274,7 @@ 
 
     /**
      * @param Email       $email
-     * @param object|null $owner
+     * @param TestUser|null $owner
      */
     protected function addEmailRecipient(Email $email, $owner = null)
     {

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/EmailBundle/Tests/Unit/Fixtures/Entity/TestOrganization.php

Doc Comments +3 added lines

@@ -6,6 +6,9 @@
 {
     protected $id;
 
+    /**
+     * @param integer $id
+     */
     public function __construct($id)
     {
         return $this->id = $id;

src/Oro/Bundle/EmailBundle/Tests/Unit/Form/Type/EmailTypeTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -69,7 +69,7 @@
 
     /**
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
-     * @return array
+     * @return PreloadedExtension[]
      */
     protected function getExtensions()
     {

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/EmailBundle/Tests/Unit/Mailer/ProcessorTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -463,7 +463,7 @@
     }
 
     /**
-     * @param      $user
+     * @param      User $user
      * @param bool $withOrigin
      */
     protected function processWithOwner($user, $withOrigin = false)

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;