Completed
Push — 1.8 ( 79b91c...110b8e )
by
unknown
85:39 queued 52:15
created
src/Oro/Bundle/EntityPaginationBundle/Storage/StorageDataCollector.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
     protected $paginationManager;
48 48
 
49 49
     /**
50
-     * @param DataGridManager $dataGridManager
50
+     * @param DatagridManager $dataGridManager
51 51
      * @param DoctrineHelper $doctrineHelper
52 52
      * @param AclHelper $aclHelper
53 53
      * @param Pager $pager
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,16 +3,13 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\EntityPaginationBundle\Storage;
4 4
 
5 5
 use Symfony\Component\HttpFoundation\Request;
6
-
7 6
 use Oro\Bundle\DataGridBundle\Datasource\ResultRecord;
8 7
 use Oro\Bundle\EntityPaginationBundle\Manager\EntityPaginationManager;
9 8
 use Oro\Bundle\DataGridBundle\Datagrid\DatagridInterface;
10 9
 use Oro\Bundle\DataGridBundle\Datasource\Orm\OrmDatasource;
11 10
 use Oro\Bundle\DataGridBundle\Extension\Pager\Orm\Pager;
12
-use Oro\Bundle\EntityPaginationBundle\Datagrid\EntityPaginationExtension;
13 11
 use Oro\Bundle\SecurityBundle\ORM\Walker\AclHelper;
14 12
 use Oro\Bundle\EntityBundle\ORM\DoctrineHelper;
15
-use Oro\Bundle\DataGridBundle\Datagrid\Manager as DatagridManager;
16 13
 
17 14
 class StorageDataCollector
18 15
 {
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityPaginationBundle/Twig/EntityPaginationExtension.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@  discard block
 block discarded – undo
63 63
      * Null - pager data is not accessible
64 64
      * Array('total' => <int>, 'current' => <int>) - used to generate string "<current> of <total>"
65 65
      *
66
-     * @param object $entity
66
+     * @param \stdClass $entity
67 67
      * @param string $scope
68 68
      * @return null|array
69 69
      */
@@ -92,7 +92,7 @@  discard block
 block discarded – undo
92 92
     }
93 93
 
94 94
     /**
95
-     * @param object $entity
95
+     * @param \stdClass $entity
96 96
      * @param string $scope
97 97
      */
98 98
     public function showInfoMessage($entity, $scope)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Expression/Date/ExpressionResult.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -32,6 +32,9 @@  discard block
 block discarded – undo
32 32
     /** @var mixed */
33 33
     private $value;
34 34
 
35
+    /**
36
+     * @param string $timezone
37
+     */
35 38
     public function __construct($value, $timezone = null)
36 39
     {
37 40
         $timezone = $timezone ? : 'UTC';
@@ -114,7 +117,7 @@  discard block
 block discarded – undo
114 117
     }
115 118
 
116 119
     /**
117
-     * @return null|string
120
+     * @return string
118 121
      */
119 122
     public function getVariableLabel()
120 123
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Filter/AbstractDateFilter.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -106,8 +106,8 @@
 block discarded – undo
106 106
      * Apply expression using one condition (less or more)
107 107
      *
108 108
      * @param FilterDatasourceAdapterInterface $ds
109
-     * @param                                  $dateValue
110
-     * @param                                  $dateParameterName
109
+     * @param                                  string $dateValue
110
+     * @param                                  string $dateParameterName
111 111
      * @param string                           $fieldName
112 112
      * @param bool                             $isLess less/more mode, true if 'less than', false if 'more than'
113 113
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Form/EventListener/DateFilterSubscriber.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -157,9 +157,9 @@  discard block
 block discarded – undo
157 157
     /**
158 158
      * Call callback for each of given value, used instead of array_map to walk safely through array
159 159
      *
160
-     * @param array    $keys
160
+     * @param integer[]    $keys
161 161
      * @param array    $data
162
-     * @param callable $callback
162
+     * @param \Closure $callback
163 163
      */
164 164
     private function mapValues(array $keys, array &$data, \Closure $callback)
165 165
     {
@@ -175,7 +175,7 @@  discard block
 block discarded – undo
175 175
      *
176 176
      * @param string $part
177 177
      *
178
-     * @return callable
178
+     * @return \Closure
179 179
      */
180 180
     private function getDatePartAccessorClosure($part)
181 181
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Grid/Extension/Configuration.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -17,7 +17,7 @@
 block discarded – undo
17 17
     protected $types;
18 18
 
19 19
     /**
20
-     * @param $types
20
+     * @param integer[] $types
21 21
      */
22 22
     public function __construct($types)
23 23
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/FilterBundle/Tests/Unit/Form/Type/AbstractTypeTestCase.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
     }
80 80
 
81 81
     /**
82
-     * @return OptionsResolverInterface|\PHPUnit_Framework_MockObject_MockObject
82
+     * @return OptionsResolverInterface
83 83
      */
84 84
     protected function createMockOptionsResolver()
85 85
     {
@@ -154,7 +154,7 @@  discard block
 block discarded – undo
154 154
     abstract protected function getTestFormType();
155 155
 
156 156
     /**
157
-     * @return array|FormExtensionInterface[]
157
+     * @return FormExtensionInterface[]
158 158
      */
159 159
     protected function getExtensions()
160 160
     {
@@ -165,7 +165,7 @@  discard block
 block discarded – undo
165 165
      * @param string  $class
166 166
      * @param array $events
167 167
      *
168
-     * @return mixed
168
+     * @return MutableFormEventSubscriber
169 169
      */
170 170
     public function getMockSubscriber($class, array $events = [])
171 171
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Config/BlockConfig.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@  discard block
 block discarded – undo
42 42
     protected $subBlocks = array();
43 43
 
44 44
     /**
45
-     * @param $code
45
+     * @param string $code
46 46
      */
47 47
     public function __construct($code)
48 48
     {
@@ -69,7 +69,7 @@  discard block
 block discarded – undo
69 69
     }
70 70
 
71 71
     /**
72
-     * @param $code
72
+     * @param string $code
73 73
      * @return $this
74 74
      */
75 75
     public function setCode($code)
Please login to merge, or discard this patch.
src/Oro/Bundle/FormBundle/Form/Extension/JsValidationExtension.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -145,7 +145,7 @@
 block discarded – undo
145 145
      * Gets constraint name based on object
146 146
      *
147 147
      * @param Constraint $constraint
148
-     * @return mixed|string
148
+     * @return string
149 149
      */
150 150
     protected function getConstraintName(Constraint $constraint)
151 151
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.