orocrm / platform

src/Oro/Bundle/WorkflowBundle/Model/StepManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -55,7 +55,7 @@ 
     }
 
     /**
-     * @return Collection|Step[]
+     * @return Collection
      */
     public function getSteps()
     {
@@ -65,7 +65,7 @@ 
     /**
      * Get steps sorted by order.
      *
-     * @return Collection|Step[]
+     * @return ArrayCollection
      */
     public function getOrderedSteps()
     {

src/Oro/Bundle/WorkflowBundle/Model/WorkflowData.php

Doc Comments +4 added lines, -4 removed lines

@@ -61,8 +61,8 @@ 
     /**
      * Get mapped field path by field name.
      *
-     * @param string|PropertyPathInterface $propertyPath
-     * @return null|string
+     * @param string $propertyPath
+     * @return PropertyPathInterface
      */
     protected function getMappedPath($propertyPath)
     {
@@ -81,7 +81,7 @@ 
      * Get property path for array as first accessor.
      *
      * @param string $path
-     * @return string
+     * @return PropertyPath
      */
     protected function getConstructedPropertyPath($path)
     {
@@ -326,7 +326,7 @@ 
 
     /**
      * @param Proxy $entity
-     * @return object|Proxy|null
+     * @return null|Proxy
      */
     protected function extractProxyEntity(Proxy $entity)
     {

Unused Use Statements -3 removed lines

@@ -4,12 +4,9 @@
 
 use Doctrine\Common\Persistence\Proxy;
 use Doctrine\ORM\EntityNotFoundException;
-
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-use Symfony\Component\PropertyAccess\PropertyAccess;
 use Symfony\Component\PropertyAccess\PropertyPath;
 use Symfony\Component\PropertyAccess\PropertyPathInterface;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 
 class WorkflowData implements \ArrayAccess, \IteratorAggregate, \Countable

src/Oro/Bundle/WorkflowBundle/Tests/Functional/Controller/Api/Rest/WorkflowControllerTest.php

Doc Comments +1 added lines

@@ -211,6 +211,7 @@
     /**
      * @param string
      * @param string|null $workflowName
+     * @param string $entityClass
      */
     protected function assertActiveWorkflow($entityClass, $workflowName)
     {

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Acl/Voter/WorkflowEntityVoterTest.php

Doc Comments +2 added lines, -2 removed lines

@@ -232,10 +232,10 @@
     }
 
     /**
-     * @param array $entityAcls
+     * @param WorkflowEntityAcl[] $entityAcls
      * @param string|null $entityClass
      * @param int|null $entityIdentifier
-     * @param array $aclIdentities
+     * @param WorkflowEntityAclIdentity[] $aclIdentities
      */
     protected function setRegistryRepositories(
         array $entityAcls = [],

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/WorkflowBundle/Tests/Unit/EventListener/WorkflowDataSerializeListenerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -193,7 +193,7 @@
 
     /**
      * @param array $uowExpectedCalls
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Doctrine\ORM\EntityManager
+     * @return \Doctrine\ORM\EntityManagerInterface
      */
     protected function getPostFlushEntityManagerMock(array $uowExpectedCalls)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Form/Type/AbstractWorkflowAttributesTypeTestCase.php

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/Action/TreeExecutorTest.php

Doc Comments +7 added lines

@@ -117,6 +117,9 @@ 
         $listAction->execute(array());
     }
 
+    /**
+     * @return \Oro\Bundle\WorkflowBundle\Model\Action\ActionInterface
+     */
     protected function getExceptionAction()
     {
         $action = $this->getMockBuilder('Oro\Bundle\WorkflowBundle\Model\Action\ActionInterface')
@@ -127,6 +130,10 @@ 
             ->method('execute')
             ->will(
                 $this->returnCallback(
+
+                    /**
+                     * @return \Oro\Bundle\WorkflowBundle\Model\Action\ActionInterface
+                     */
                     function () {
                         throw new \Exception('TEST');
                     }

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/AttributeAssemblerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -35,7 +35,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject
+     * @return \Oro\Bundle\WorkflowBundle\Model\AttributeGuesser
      */
     protected function getAttributeGuesser()
     {

src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/TransitionAssemblerTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -317,7 +317,7 @@
     /**
      * @param string $templateType
      * @param array $configuration
-     * @param $actualTransition
+     * @param Transition $actualTransition
      */
     protected function assertTemplate($templateType, $configuration, $actualTransition)
     {