Completed
Push — master ( 468850...c98472 )
by
unknown
54:13
created
src/Oro/Bundle/EntityConfigBundle/Provider/ConfigProvider.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -196,7 +196,7 @@
 block discarded – undo
196 196
      * Applies the callback to configuration data to all configurable entities (if $className is not specified)
197 197
      * or all configurable fields of the given entity.
198 198
      *
199
-     * @param callable    $callback The callback function to run for configuration data for each object
199
+     * @param \Closure    $callback The callback function to run for configuration data for each object
200 200
      * @param string|null $className
201 201
      * @param bool        $withHidden
202 202
      *
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
Tests/Unit/ImportExport/Strategy/EntityFieldImportStrategyTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -186,7 +186,7 @@
 block discarded – undo
186 186
     }
187 187
 
188 188
     /**
189
-     * @param object $object
189
+     * @param EntityFieldImportStrategy $object
190 190
      * @param string $property
191 191
      * @return mixed $value
192 192
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigHelper.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -94,7 +94,7 @@
 block discarded – undo
94 94
      *
95 95
      * @param string $className
96 96
      *
97
-     * @return array [$moduleName, $entityName]
97
+     * @return string[] [$moduleName, $entityName]
98 98
      */
99 99
     public static function getModuleAndEntityNames($className)
100 100
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityConfigBundle/Tools/ConfigLoader.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
      * Load entity configs from annotations to a database
38 38
      *
39 39
      * @param bool                 $force  Force overwrite config's option values
40
-     * @param callable|null        $filter function (ClassMetadata[] $doctrineAllMetadata)
40
+     * @param null|\Closure        $filter function (ClassMetadata[] $doctrineAllMetadata)
41 41
      * @param LoggerInterface|null $logger
42 42
      * @param bool                 $dryRun Log modifications without apply them
43 43
      *
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Entity/Manager/AssociationManager.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -103,7 +103,7 @@  discard block
 block discarded – undo
103 103
      * @param string $attribute The name of the entity config attribute which indicates
104 104
      *                          whether the association is enabled or not
105 105
      *
106
-     * @return callable
106
+     * @return \Closure
107 107
      */
108 108
     public function getSingleOwnerFilter($scope, $attribute = 'enabled')
109 109
     {
@@ -121,7 +121,7 @@  discard block
 block discarded – undo
121 121
      * @param string $attribute The name of the entity config attribute which is used to store
122 122
      *                          enabled associations
123 123
      *
124
-     * @return callable
124
+     * @return \Closure
125 125
      */
126 126
     public function getMultiOwnerFilter($scope, $attribute)
127 127
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Form/Guesser/ExtendFieldTypeGuesser.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@  discard block
 block discarded – undo
2 2
 
3 3
 namespace Oro\Bundle\EntityExtendBundle\Form\Guesser;
4 4
 
5
-use Symfony\Component\Form\Guess;
6
-
7 5
 use Doctrine\Common\Persistence\ManagerRegistry;
8
-
9 6
 use Oro\Bundle\EntityBundle\Form\Guesser\AbstractFormGuesser;
10 7
 use Oro\Bundle\EntityConfigBundle\Config\ConfigInterface;
11 8
 use Oro\Bundle\EntityConfigBundle\Config\Id\FieldConfigId;
@@ -15,7 +12,6 @@  discard block
 block discarded – undo
15 12
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendConfigDumper;
16 13
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
17 14
 use Oro\Bundle\EntityExtendBundle\Validator\Constraints\Decimal;
18
-
19 15
 use Symfony\Component\Validator\Constraints\Length;
20 16
 
21 17
 class ExtendFieldTypeGuesser extends AbstractFormGuesser
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Form/Type/TargetType.php 2 patches
Doc Comments   +12 added lines patch added patch discarded remove patch
@@ -69,6 +69,10 @@  discard block
 block discarded – undo
69 69
         );
70 70
     }
71 71
 
72
+    /**
73
+     * @param string $entityClassName
74
+     * @param string|null $relationType
75
+     */
72 76
     protected function getEntityChoiceList($entityClassName, $relationType)
73 77
     {
74 78
         $choices       = [];
@@ -82,6 +86,10 @@  discard block
 block discarded – undo
82 86
         if (in_array($relationType, [RelationTypeBase::ONE_TO_MANY, RelationTypeBase::MANY_TO_MANY], true)) {
83 87
             $entityIds = array_filter(
84 88
                 $entityIds,
89
+
90
+                /**
91
+                 * @param string $configId
92
+                 */
85 93
                 function (EntityConfigId $configId) {
86 94
                     $config = $this->configManager->getConfig($configId);
87 95
 
@@ -92,6 +100,10 @@  discard block
 block discarded – undo
92 100
 
93 101
         $entityIds = array_filter(
94 102
             $entityIds,
103
+
104
+            /**
105
+             * @param string $configId
106
+             */
95 107
             function (EntityConfigId $configId) {
96 108
                 $config = $this->configManager->getConfig($configId);
97 109
 
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Migration/ExtendOptionsBuilder.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -234,7 +234,7 @@
 block discarded – undo
234 234
      *
235 235
      * @param array  $options
236 236
      * @param string $name
237
-     * @return mixed
237
+     * @return string|null
238 238
      */
239 239
     protected function getAndRemoveOption(array &$options, $name)
240 240
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/EntityExtendBundle/Migration/Extension/ExtendExtension.php 2 patches
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@  discard block
 block discarded – undo
270 270
      * @param string        $enumCode        The target enum identifier
271 271
      * @param bool          $isMultiple      Indicates whether several options can be selected for this enum
272 272
      *                                       or it supports only one selected option
273
-     * @param bool|string[] $immutable       Indicates whether the changing the list of enum values and
273
+     * @param boolean $immutable       Indicates whether the changing the list of enum values and
274 274
      *                                       public flag is allowed or not. More details can be found
275 275
      *                                       in entity_config.yml
276 276
      * @param array         $options
@@ -341,7 +341,7 @@  discard block
 block discarded – undo
341 341
      * Adds one-to-many relation
342 342
      *
343 343
      * @param Schema       $schema
344
-     * @param Table|string $table                     A Table object or table name
344
+     * @param Table $table                     A Table object or table name
345 345
      * @param string       $associationName           A relation name
346 346
      * @param Table|string $targetTable               A Table object or table name
347 347
      * @param string[]     $targetTitleColumnNames    Column names are used to show a title of related entity
@@ -525,7 +525,7 @@  discard block
 block discarded – undo
525 525
      * Adds many-to-one relation
526 526
      *
527 527
      * @param Schema       $schema
528
-     * @param Table|string $table            A Table object or table name
528
+     * @param Table $table            A Table object or table name
529 529
      * @param string       $associationName  A relation name
530 530
      * @param Table|string $targetTable      A Table object or table name
531 531
      * @param string       $targetColumnName A column name is used to show related entity
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.