orocrm / platform

src/Oro/Bundle/EntityConfigBundle/Tools/ConfigLoader.php

Doc Comments +1 added lines, -1 removed lines

@@ -37,7 +37,7 @@
      * Load entity configs from annotations to a database
      *
      * @param bool                 $force  Force overwrite config's option values
-     * @param callable|null        $filter function (ClassMetadata[] $doctrineAllMetadata)
+     * @param null|\Closure        $filter function (ClassMetadata[] $doctrineAllMetadata)
      * @param LoggerInterface|null $logger
      * @param bool                 $dryRun Log modifications without apply them
      *

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/EntityExtendBundle/Entity/Manager/AssociationManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -103,7 +103,7 @@ 
      * @param string $attribute The name of the entity config attribute which indicates
      *                          whether the association is enabled or not
      *
-     * @return callable
+     * @return \Closure
      */
     public function getSingleOwnerFilter($scope, $attribute = 'enabled')
     {
@@ -121,7 +121,7 @@ 
      * @param string $attribute The name of the entity config attribute which is used to store
      *                          enabled associations
      *
-     * @return callable
+     * @return \Closure
      */
     public function getMultiOwnerFilter($scope, $attribute)
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/EntityExtendBundle/Form/Guesser/ExtendFieldTypeGuesser.php

Unused Use Statements -4 removed lines

@@ -2,10 +2,7 @@ 
 
 namespace Oro\Bundle\EntityExtendBundle\Form\Guesser;
 
-use Symfony\Component\Form\Guess;
-
 use Doctrine\Common\Persistence\ManagerRegistry;
-
 use Oro\Bundle\EntityBundle\Form\Guesser\AbstractFormGuesser;
 use Oro\Bundle\EntityConfigBundle\Config\ConfigInterface;
 use Oro\Bundle\EntityConfigBundle\Config\Id\FieldConfigId;
@@ -15,7 +12,6 @@ 
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendConfigDumper;
 use Oro\Bundle\EntityExtendBundle\Tools\ExtendHelper;
 use Oro\Bundle\EntityExtendBundle\Validator\Constraints\Decimal;
-
 use Symfony\Component\Validator\Constraints\Length;
 
 class ExtendFieldTypeGuesser extends AbstractFormGuesser

src/Oro/Bundle/EntityExtendBundle/Form/Type/TargetType.php

Doc Comments +12 added lines

@@ -69,6 +69,10 @@ 
         );
     }
 
+    /**
+     * @param string $entityClassName
+     * @param string|null $relationType
+     */
     protected function getEntityChoiceList($entityClassName, $relationType)
     {
         $choices       = [];
@@ -82,6 +86,10 @@ 
         if (in_array($relationType, [RelationTypeBase::ONE_TO_MANY, RelationTypeBase::MANY_TO_MANY], true)) {
             $entityIds = array_filter(
                 $entityIds,
+
+                /**
+                 * @param string $configId
+                 */
                 function (EntityConfigId $configId) {
                     $config = $this->configManager->getConfig($configId);
 
@@ -92,6 +100,10 @@ 
 
         $entityIds = array_filter(
             $entityIds,
+
+            /**
+             * @param string $configId
+             */
             function (EntityConfigId $configId) {
                 $config = $this->configManager->getConfig($configId);
 

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/EntityExtendBundle/Migration/ExtendOptionsBuilder.php

Doc Comments +1 added lines, -1 removed lines

@@ -234,7 +234,7 @@
      *
      * @param array  $options
      * @param string $name
-     * @return mixed
+     * @return string|null
      */
     protected function getAndRemoveOption(array &$options, $name)
     {

src/Oro/Bundle/EntityExtendBundle/Migration/Extension/ExtendExtension.php

Doc Comments +3 added lines, -3 removed lines

@@ -270,7 +270,7 @@ 
      * @param string        $enumCode        The target enum identifier
      * @param bool          $isMultiple      Indicates whether several options can be selected for this enum
      *                                       or it supports only one selected option
-     * @param bool|string[] $immutable       Indicates whether the changing the list of enum values and
+     * @param boolean $immutable       Indicates whether the changing the list of enum values and
      *                                       public flag is allowed or not. More details can be found
      *                                       in entity_config.yml
      * @param array         $options
@@ -341,7 +341,7 @@ 
      * Adds one-to-many relation
      *
      * @param Schema       $schema
-     * @param Table|string $table                     A Table object or table name
+     * @param Table $table                     A Table object or table name
      * @param string       $associationName           A relation name
      * @param Table|string $targetTable               A Table object or table name
      * @param string[]     $targetTitleColumnNames    Column names are used to show a title of related entity
@@ -525,7 +525,7 @@ 
      * Adds many-to-one relation
      *
      * @param Schema       $schema
-     * @param Table|string $table            A Table object or table name
+     * @param Table $table            A Table object or table name
      * @param string       $associationName  A relation name
      * @param Table|string $targetTable      A Table object or table name
      * @param string       $targetColumnName A column name is used to show related entity

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/EntityExtendBundle/Migrations/Schema/v1_0/RenameExtendTablesAndColumns.php

Doc Comments +6 added lines

@@ -226,6 +226,9 @@ 
         }
     }
 
+    /**
+     * @param string $associationName
+     */
     protected function renameManyToOneExtendField(
         Schema $schema,
         QueryBag $queries,
@@ -247,6 +250,9 @@ 
         }
     }
 
+    /**
+     * @param string $associationName
+     */
     protected function renameOneToManyExtendField(
         Schema $schema,
         QueryBag $queries,

Unused Use Statements -4 removed lines

@@ -4,17 +4,13 @@
 
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
-
 use Oro\Bundle\UserBundle\Entity\User;
 use Oro\Bundle\UserBundle\Entity\UserApi;
-
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
 

src/Oro/Bundle/EntityExtendBundle/Tests/Unit/Form/Type/EnumValueTypeTest.php

Doc Comments +1 added lines, -1 removed lines

@@ -267,7 +267,7 @@
     }
 
     /**
-     * @return \PHPUnit_Framework_MockObject_MockObject|ConstraintValidatorFactoryInterface
+     * @return ConstraintValidatorFactoryInterface
      */
     protected function getConstraintValidatorFactory()
     {

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/EntityExtendBundle/Tests/Unit/Grid/AdditionalFieldsExtensionTest.php

Doc Comments +5 added lines

@@ -490,6 +490,11 @@
         );
     }
 
+    /**
+     * @param string $className
+     * @param string $fieldName
+     * @param string $fieldType
+     */
     protected function setExpectationForGetFields($className, $fieldName, $fieldType, array $extendFieldConfig = [])
     {
         $extendConfig = new Config(new FieldConfigId('extend', $className, $fieldName, $fieldType));