orocrm / platform

src/Oro/Bundle/EmailBundle/Manager/EmailAttachmentManager.php

Doc Comments +2 added lines, -2 removed lines

@@ -46,7 +46,7 @@ 
     protected $attachmentConfig;
 
     /**
-     * @param FileSystemMap       $filesystemMap
+     * @param FilesystemMap       $filesystemMap
      * @param EntityManager       $em
      * @param KernelInterface     $kernel
      * @param ServiceLink         $securityFacadeLink
@@ -137,7 +137,7 @@ 
     /**
      * @param EmailAttachment $emailAttachment
      *
-     * @return File|null
+     * @return File
      */
     protected function copyEmailAttachmentToFileSystem(EmailAttachment $emailAttachment)
     {

Unused Use Statements -4 removed lines

@@ -4,17 +4,13 @@
 
 use Symfony\Component\HttpFoundation\JsonResponse;
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
-
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
-
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
 use Oro\Bundle\SecurityBundle\Authentication\Token\UsernamePasswordOrganizationToken;
-
 use Oro\Bundle\UserBundle\Entity\User;
 use Oro\Bundle\UserBundle\Entity\UserApi;
-
 use Oro\Bundle\OrganizationBundle\Entity\Manager\BusinessUnitManager;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
 

src/Oro/Bundle/EmailBundle/Manager/EmailNotificationManager.php

Doc Comments +1 added lines, -1 removed lines

@@ -125,7 +125,7 @@
     /**
      * @param Email $email
      *
-     * @return bool|string
+     * @return false|string
      */
     protected function getFromNameLink(Email $email)
     {

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/EmailBundle/Model/Recipient.php

Doc Comments -1 removed lines

@@ -17,7 +17,6 @@
      * @param string $email
      * @param string $name
      * @param RecipientEntity|null $entity
-     * @param string|null $organization
      */
     public function __construct($email, $name, RecipientEntity $entity = null)
     {

src/Oro/Bundle/EmailBundle/OroEmailBundle.php

Unused Use Statements -3 removed lines

@@ -7,9 +7,7 @@ 
 use Symfony\Component\Filesystem\Filesystem;
 use Symfony\Component\HttpKernel\Bundle\Bundle;
 use Symfony\Component\HttpKernel\KernelInterface;
-
 use Doctrine\Bundle\DoctrineBundle\DependencyInjection\Compiler\DoctrineOrmMappingsPass;
-
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailBodyLoaderPass;
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailOwnerConfigurationPass;
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailSynchronizerPass;
@@ -17,7 +15,6 @@ 
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\MailboxProcessPass;
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\TwigSandboxConfigurationPass;
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailFlagManagerLoaderPass;
-use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailFolderLoaderPass;
 use Oro\Bundle\EmailBundle\DependencyInjection\Compiler\EmailRecipientsProviderPass;
 
 class OroEmailBundle extends Bundle

src/Oro/Bundle/EmailBundle/Provider/EmailRecipientsHelper.php

Doc Comments +1 added lines, -1 removed lines

@@ -229,7 +229,7 @@
 
     /**
      * @param EmailRecipientsProviderArgs $args
-     * @param object|null $object
+     * @param \Oro\Bundle\EmailBundle\Entity\EmailOwnerInterface|null $object
      *
      * @return bool
      */

Unused Use Statements -2 removed lines

@@ -4,9 +4,7 @@
 
 use Doctrine\Common\EventManager;
 use Doctrine\DBAL\Driver\Connection;
-
 use Symfony\Component\Filesystem\Filesystem;
-
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
 

src/Oro/Bundle/EmailBundle/Provider/EmailRenderer.php

Doc Comments +2 added lines, -2 removed lines

@@ -143,7 +143,7 @@ 
      * @param EmailTemplateInterface $template
      * @param array                  $templateParams
      *
-     * @return array first element is email subject, second - message
+     * @return string[] first element is email subject, second - message
      */
     public function compileMessage(EmailTemplateInterface $template, array $templateParams = [])
     {
@@ -206,7 +206,7 @@ 
      * @param string $template
      * @param object $entity
      *
-     * @return EmailTemplate
+     * @return string
      */
     protected function processDefaultFilters($template, $entity)
     {

Unused Use Statements -3 removed lines

@@ -4,16 +4,13 @@
 
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
-
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
-
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
-
 use Oro\Bundle\WorkflowBundle\Model\Step;
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;

src/Oro/Bundle/EmailBundle/Provider/RecentEmailRecipientsProvider.php

Doc Comments +1 added lines, -1 removed lines

@@ -97,7 +97,7 @@
     }
 
     /**
-     * @param object|null $owner
+     * @param \Oro\Bundle\EmailBundle\Entity\EmailOwnerInterface|null $owner
      *
      * @return RecipientEntity|null
      */

Unused Use Statements -1 removed lines

@@ -3,7 +3,6 @@
 namespace Oro\Component\PropertyAccess\Tests\Unit;
 
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
-
 use Oro\Component\PropertyAccess\PropertyAccessor;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;

src/Oro/Bundle/EmailBundle/Sync/AbstractEmailSynchronizationProcessor.php

Doc Comments +4 added lines, -4 removed lines

@@ -111,8 +111,8 @@ 
 
     /**
      * @param EmailHeader $email
-     * @param             $folderType
-     * @param             $organization
+     * @param             string $folderType
+     * @param             OrganizationInterface $organization
      *
      * @return bool
      * @throws \Doctrine\ORM\NonUniqueResultException
@@ -292,7 +292,7 @@ 
 
     /**
      * @param EmailFolder $folder
-     * @param array       $messageIds
+     * @param string[]       $messageIds
      * @return EmailUser[]
      */
     protected function getExistingEmailUsers(EmailFolder $folder, array $messageIds)
@@ -356,7 +356,7 @@ 
     }
 
     /**
-     * @return array
+     * @return string[]
      */
     protected function entitiesToClear()
     {

Unused Use Statements -3 removed lines

@@ -3,11 +3,8 @@
 namespace Oro\Bundle\EmailBundle\Sync;
 
 use Doctrine\ORM\EntityManager;
-use Doctrine\ORM\Query;
-
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
-
 use Oro\Bundle\EmailBundle\Entity\Provider\EmailOwnerProviderStorage;
 use Oro\Bundle\EmailBundle\Entity\Manager\EmailAddressManager;
 use Oro\Bundle\EmailBundle\Tools\EmailAddressHelper;

src/Oro/Bundle/EmailBundle/Sync/AbstractEmailSynchronizer.php

Doc Comments +2 added lines, -2 removed lines

@@ -308,7 +308,7 @@ 
     /**
      * Creates a processor is used to synchronize emails
      *
-     * @param object $origin An instance of class implementing EmailOrigin entity
+     * @param EmailOrigin $origin An instance of class implementing EmailOrigin entity
      * @return AbstractEmailSynchronizationProcessor
      */
     abstract protected function createSynchronizationProcessor($origin);
@@ -423,7 +423,7 @@ 
      * Finds active email origin by its id
      *
      * @param int $originId
-     * @return EmailOrigin|null
+     * @return EmailOrigin
      */
     protected function findOrigin($originId)
     {

Unused Use Statements -5 removed lines

@@ -4,16 +4,11 @@
 
 use Doctrine\Common\Persistence\ManagerRegistry;
 use Doctrine\ORM\EntityManager;
-use Doctrine\ORM\Query;
-use Doctrine\ORM\Query\Expr;
-
 use Symfony\Component\Security\Core\Authentication\Token\Storage\TokenStorage;
 use Symfony\Component\Security\Core\Authentication\Token\TokenInterface;
-
 use Psr\Log\LoggerAwareInterface;
 use Psr\Log\LoggerAwareTrait;
 use Psr\Log\NullLogger;
-
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
 use Oro\Bundle\EmailBundle\Exception\SyncFolderTimeoutException;
 use Oro\Bundle\OrganizationBundle\Entity\Organization;