Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/TransitionManagerTest.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -58,6 +58,9 @@
 block discarded – undo
58 58
         $this->assertEquals($expected, $transitions->toArray());
59 59
     }
60 60
 
61
+    /**
62
+     * @param string $name
63
+     */
61 64
     protected function getTransitionMock($name, $isStart = false, $step = null)
62 65
     {
63 66
         $transition = $this->getMockBuilder('Oro\Bundle\WorkflowBundle\Model\Transition')
Please login to merge, or discard this patch.
src/Oro/Bundle/WorkflowBundle/Tests/Unit/Model/WorkflowManagerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -891,7 +891,7 @@
 block discarded – undo
891 891
      * @param string $name
892 892
      * @param array $entityAttributes
893 893
      * @param array $startTransitions
894
-     * @return Workflow|\PHPUnit_Framework_MockObject_MockObject
894
+     * @return Workflow
895 895
      */
896 896
     protected function createWorkflow(
897 897
         $name = self::TEST_WORKFLOW_NAME,
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Component/Config/Loader/FolderContentCumulativeLoader.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -199,7 +199,7 @@  discard block
 block discarded – undo
199 199
     /**
200 200
      * Get all data from the directory $dir
201 201
      *
202
-     * @param $dir
202
+     * @param string $dir
203 203
      *
204 204
      * @return array
205 205
      */
@@ -311,7 +311,7 @@  discard block
 block discarded – undo
311 311
     /**
312 312
      * @param string $dir
313 313
      *
314
-     * @return \SplFileInfo[]|\Iterator
314
+     * @return \CallbackFilterIterator
315 315
      */
316 316
     protected function getDirectoryContents($dir)
317 317
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Component/Config/Loader/FolderingCumulativeFileLoader.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -270,7 +270,7 @@
 block discarded – undo
270 270
      * Adds $resource to $result
271 271
      *
272 272
      * @param array $result
273
-     * @param mixed $resource
273
+     * @param null|\Oro\Component\Config\CumulativeResourceInfo $resource
274 274
      */
275 275
     protected function addLoadedResource(array &$result, $resource)
276 276
     {
Please login to merge, or discard this patch.
src/Oro/Component/ConfigExpression/Tests/Unit/EvaluateExpressionTest.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,10 +3,7 @@
 block discarded – undo
3 3
 namespace Oro\Component\ConfigExpression\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\Yaml\Yaml;
6
-
7
-use Oro\Component\ConfigExpression\Condition;
8 6
 use Oro\Component\ConfigExpression\ConfigExpressions;
9
-use Oro\Component\ConfigExpression\Func;
10 7
 use Oro\Component\ConfigExpression\Tests\Unit\Fixtures\ItemStub;
11 8
 
12 9
 class EvaluateExpressionTest extends \PHPUnit_Framework_TestCase
Please login to merge, or discard this patch.
src/Oro/Component/EntitySerializer/EntitySerializer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -756,7 +756,7 @@
 block discarded – undo
756 756
      * @param array  $config The config of an entity the specified field belongs
757 757
      * @param string $field  The name of the field
758 758
      *
759
-     * @return array
759
+     * @return boolean
760 760
      */
761 761
     protected function hasFieldConfig($config, $field)
762 762
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Component/EntitySerializer/Tests/Unit/EntitySerializerTestCase.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
      * @param \PHPUnit_Framework_MockObject_MockObject $conn
116 116
      * @param string                                   $sql
117 117
      * @param array                                    $result
118
-     * @param array                                    $params
118
+     * @param integer[]                                    $params
119 119
      * @param array                                    $types
120 120
      */
121 121
     protected function setQueryExpectation(
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Component/Layout/DeferredLayoutManipulatorInterface.php 1 patch
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -182,6 +182,7 @@
 block discarded – undo
182 182
      *                                   True means that not executed actions are the reason for an error.
183 183
      *
184 184
      * @throws Exception\DeferredUpdateFailureException if not all scheduled action have been performed
185
+     * @return void
185 186
      */
186 187
     public function applyChanges(ContextInterface $context, $finalize = false);
187 188
 }
Please login to merge, or discard this patch.
src/Oro/Component/Layout/LayoutBuilderInterface.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@
 block discarded – undo
115 115
      *
116 116
      * @param string $id             The item id
117 117
      * @param string $optionName     The option name or path
118
-     * @param mixed  $oldOptionValue The option value to be replaced
118
+     * @param string  $oldOptionValue The option value to be replaced
119 119
      * @param mixed  $newOptionValue The option value to replace a value specified in $oldOptionValue parameter
120 120
      *
121 121
      * @return self
Please login to merge, or discard this patch.