Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/TagBundle/Provider/SearchProvider.php 2 patches
Doc Comments   +1 added lines patch added patch discarded remove patch
@@ -57,6 +57,7 @@
 block discarded – undo
57 57
 
58 58
     /**
59 59
      * {@inheritdoc}
60
+     * @param integer $tagId
60 61
      */
61 62
     public function getResults($tagId)
62 63
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/TagBundle/Tests/Selenium/TagsAcl.php 1 patch
Doc Comments   +24 added lines patch added patch discarded remove patch
@@ -127,6 +127,10 @@  discard block
 block discarded – undo
127 127
         }
128 128
     }
129 129
 
130
+    /**
131
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
132
+     * @param string $role
133
+     */
130 134
     public function deleteAcl($login, $role, $username, $tagName)
131 135
     {
132 136
         /** @var Roles $login*/
@@ -143,6 +147,10 @@  discard block
 block discarded – undo
143 147
             ->checkContextMenu($tagName, 'Delete');
144 148
     }
145 149
 
150
+    /**
151
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
152
+     * @param string $role
153
+     */
146 154
     public function updateAcl($login, $role, $username, $tagName)
147 155
     {
148 156
         /** @var Roles $login*/
@@ -159,6 +167,10 @@  discard block
 block discarded – undo
159 167
             ->checkContextMenu($tagName, 'Update');
160 168
     }
161 169
 
170
+    /**
171
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
172
+     * @param string $role
173
+     */
162 174
     public function createAcl($login, $role, $username)
163 175
     {
164 176
         /** @var Roles $login*/
@@ -175,6 +187,10 @@  discard block
 block discarded – undo
175 187
             ->assertElementNotPresent("//div[@class = 'container-fluid']//a[contains(., 'Create Tag')]");
176 188
     }
177 189
 
190
+    /**
191
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
192
+     * @param string $role
193
+     */
178 194
     public function viewListAcl($login, $role, $username)
179 195
     {
180 196
         /** @var Roles $login*/
@@ -191,6 +207,10 @@  discard block
 block discarded – undo
191 207
             ->assertTitle('403 - Forbidden');
192 208
     }
193 209
 
210
+    /**
211
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
212
+     * @param string $roleName
213
+     */
194 214
     public function unassignGlobalAcl($login, $roleName, $tagName)
195 215
     {
196 216
         $username = 'user' . mt_rand();
@@ -229,6 +249,10 @@  discard block
 block discarded – undo
229 249
             );
230 250
     }
231 251
 
252
+    /**
253
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
254
+     * @param string $role
255
+     */
232 256
     public function assignAcl($login, $role, $username)
233 257
     {
234 258
         /** @var Roles $login*/
Please login to merge, or discard this patch.
src/Oro/Bundle/TagBundle/Twig/TagExtension.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Oro\Bundle\TagBundle\Twig;
4 4
 
5
-use Symfony\Component\Routing\Router;
6
-
7 5
 use Oro\Bundle\TagBundle\Entity\Taggable;
8 6
 use Oro\Bundle\TagBundle\Entity\TagManager;
9 7
 
Please login to merge, or discard this patch.
src/Oro/Bundle/TestFrameworkBundle/Pages/AbstractPageGrid.php 2 patches
Doc Comments   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -24,7 +24,7 @@  discard block
 block discarded – undo
24 24
     abstract public function entityView();
25 25
 
26 26
     /**
27
-     * @param array $entityData
27
+     * @param string[] $entityData
28 28
      *
29 29
      * @return mixed
30 30
      */
@@ -166,7 +166,7 @@  discard block
 block discarded – undo
166 166
      * Get all elements from data grid
167 167
      *
168 168
      * @param null|int $id
169
-     * @return array PHPUnit_Extensions_Selenium2TestCase_Element
169
+     * @return \PHPUnit_Extensions_Selenium2TestCase_Element[] PHPUnit_Extensions_Selenium2TestCase_Element
170 170
      */
171 171
     public function getRows($id = null)
172 172
     {
@@ -401,7 +401,7 @@  discard block
 block discarded – undo
401 401
     }
402 402
 
403 403
     /**
404
-     * @param $columnName
404
+     * @param string $columnName
405 405
      * @param string $order DESC or ASC
406 406
      * @return $this
407 407
      */
@@ -436,7 +436,7 @@  discard block
 block discarded – undo
436 436
     /**
437 437
      * Change page size
438 438
      *
439
-     * @param string|int $pageSize
439
+     * @param string $pageSize
440 440
      * @return $this
441 441
      */
442 442
     public function changePageSize($pageSize)
@@ -484,7 +484,7 @@  discard block
 block discarded – undo
484 484
 
485 485
     /**
486 486
      * Method checks if no item in action grid menu
487
-     * @param $actionName
487
+     * @param string $actionName
488 488
      * @return $this
489 489
      * @throws  \PHPUnit_Framework_AssertionFailedError
490 490
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace Oro\Bundle\TestFrameworkBundle\Pages;
4 4
 
5
-use PHPUnit_Framework_Assert;
6
-
7 5
 /**
8 6
  * Class AbstractPageGrid
9 7
  *
Please login to merge, or discard this patch.
src/Oro/Bundle/TestFrameworkBundle/Pages/FilteredGridTrait.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -50,8 +50,8 @@
 block discarded – undo
50 50
 
51 51
     /**
52 52
      * Method to filter grid by Multiselect filter
53
-     * @param $filterName
54
-     * @param array $values
53
+     * @param string $filterName
54
+     * @param string[] $values
55 55
      * @return $this
56 56
      */
57 57
     public function filterByMultiselect($filterName, $values)
Please login to merge, or discard this patch.
src/Oro/Bundle/TestFrameworkBundle/Test/Client.php 2 patches
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -36,6 +36,8 @@
 block discarded – undo
36 36
 
37 37
     /**
38 38
      * {@inheritdoc}
39
+     * @param string $method
40
+     * @param string $uri
39 41
      */
40 42
     public function request(
41 43
         $method,
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Bundle/TestFrameworkBundle/Test/DependencyInjection/ExtensionTestCase.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
     }
111 111
 
112 112
     /**
113
-     * @return \PHPUnit_Framework_MockObject_MockObject|\Symfony\Component\DependencyInjection\ContainerBuilder
113
+     * @return \Symfony\Component\DependencyInjection\ContainerBuilder
114 114
      */
115 115
     protected function getContainerMock()
116 116
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/TestFrameworkBundle/Test/WebTestCase.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -313,7 +313,7 @@  discard block
 block discarded – undo
313 313
     }
314 314
 
315 315
     /**
316
-     * @param array $classNames
316
+     * @param string[] $classNames
317 317
      * @param bool  $force
318 318
      */
319 319
     protected function loadFixtures(array $classNames, $force = false)
@@ -354,7 +354,7 @@  discard block
 block discarded – undo
354 354
     }
355 355
 
356 356
     /**
357
-     * @return ReferenceRepository|null
357
+     * @return ReferenceRepository
358 358
      */
359 359
     protected function getReferenceRepository()
360 360
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/ThemeBundle/Command/ThemeCommand.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -52,6 +52,9 @@
 block discarded – undo
52 52
         }
53 53
     }
54 54
 
55
+    /**
56
+     * @param boolean $isActive
57
+     */
55 58
     protected function outputTheme(OutputInterface $output, Theme $theme, $isActive)
56 59
     {
57 60
         if ($isActive) {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.