Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
OrganizationBundle/Provider/Filter/ChoiceTreeBusinessUnitProvider.php 2 patches
Doc Comments   -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,6 @@
 block discarded – undo
37 37
     }
38 38
 
39 39
     /**
40
-     * @param Organization $currentOrganization
41 40
      *
42 41
      * @return array
43 42
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
OrganizationBundle/Tests/Unit/Entity/Manager/BusinessUnitManagerTest.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -302,8 +302,8 @@
 block discarded – undo
302 302
 
303 303
     /**
304 304
      * @param int   $id
305
-     * @param array $organizations
306
-     * @param array $bUnits
305
+     * @param Organization[] $organizations
306
+     * @param BusinessUnit[] $bUnits
307 307
      * @return User
308 308
      */
309 309
     protected function getCurrentUser($id, array $organizations, array $bUnits)
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
Tests/Unit/Form/EventListener/OwnerFormSubscriberTest.php 2 patches
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -172,6 +172,9 @@
 block discarded – undo
172 172
         $this->subscriber->postSetData($event);
173 173
     }
174 174
 
175
+    /**
176
+     * @param Tag $entity
177
+     */
175 178
     protected function prepareEntityManager($entity)
176 179
     {
177 180
         $entityClass = ClassUtils::getClass($entity);
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/OrganizationBundle/Twig/OwnerTypeExtension.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -40,7 +40,7 @@  discard block
 block discarded – undo
40 40
     }
41 41
 
42 42
     /**
43
-     * @param object $entity
43
+     * @param \Oro\Bundle\OrganizationBundle\Entity\BusinessUnit $entity
44 44
      * @return string
45 45
      */
46 46
     public function getOwnerType($entity)
@@ -55,7 +55,7 @@  discard block
 block discarded – undo
55 55
     }
56 56
 
57 57
     /**
58
-     * @param object $entity
58
+     * @param \Oro\Bundle\OrganizationBundle\Tests\Unit\Fixture\Entity\Entity $entity
59 59
      *
60 60
      * @return null|object
61 61
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/QueryDesignerBundle/Model/Column.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@  discard block
 block discarded – undo
68 68
      * Get sorting mode.
69 69
      * Can be ASC, DESC or null.
70 70
      *
71
-     * @return string|null
71
+     * @return string
72 72
      */
73 73
     public function getSorting()
74 74
     {
@@ -94,7 +94,7 @@  discard block
 block discarded – undo
94 94
      *
95 95
      * Note: getFunc name is used instead of getFunction due a problem with JS
96 96
      *
97
-     * @return array|null
97
+     * @return string
98 98
      */
99 99
     public function getFunc()
100 100
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/QueryDesignerBundle/Model/Grouping.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -22,7 +22,7 @@
 block discarded – undo
22 22
     /**
23 23
      * Get column names
24 24
      *
25
-     * @return string
25
+     * @return string[]
26 26
      */
27 27
     public function getColumnNames()
28 28
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/QueryDesignerBundle/QueryDesigner/AbstractQueryConverter.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -1021,7 +1021,7 @@
 block discarded – undo
1021 1021
 
1022 1022
     /**
1023 1023
      * @param string $columnName
1024
-     * @param array $joinIds
1024
+     * @param string[] $joinIds
1025 1025
      */
1026 1026
     protected function addColumnAliasesForVirtualRelation($columnName, array $joinIds)
1027 1027
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Bundle/ReminderBundle/Entity/Collection/RemindersPersistentCollection.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -185,7 +185,7 @@
 block discarded – undo
185 185
     /**
186 186
      * Get elements to delete
187 187
      *
188
-     * @return array
188
+     * @return ReminderDataInterface[]
189 189
      */
190 190
     public function getDeleteDiff()
191 191
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ReminderBundle/Entity/Reminder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -388,7 +388,7 @@
 block discarded – undo
388 388
     /**
389 389
      * Get related entity class name
390 390
      *
391
-     * @return string
391
+     * @return integer
392 392
      */
393 393
     public function getRelatedEntityClassName()
394 394
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.