Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/NoteBundle/Controller/Api/Soap/NoteController.php 1 patch
Unused Use Statements   -6 removed lines patch added patch discarded remove patch
@@ -3,16 +3,10 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\NoteBundle\Controller\Api\Soap;
4 4
 
5 5
 use Symfony\Component\Form\FormInterface;
6
-
7 6
 use BeSimple\SoapBundle\ServiceDefinition\Annotation as Soap;
8
-
9
-use Oro\Bundle\SecurityBundle\Annotation\Acl;
10 7
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
11
-
12 8
 use Oro\Bundle\EntityBundle\Model\EntityIdSoap;
13
-
14 9
 use Oro\Bundle\NoteBundle\Entity\Repository\NoteRepository;
15
-
16 10
 use Oro\Bundle\SoapBundle\Entity\Manager\ApiEntityManager;
17 11
 use Oro\Bundle\SoapBundle\Controller\Api\Soap\SoapController;
18 12
 use Oro\Bundle\SoapBundle\Form\Handler\ApiFormHandler;
Please login to merge, or discard this patch.
src/Oro/Bundle/NoteBundle/Controller/NoteController.php 1 patch
Unused Use Statements   -5 removed lines patch added patch discarded remove patch
@@ -3,16 +3,11 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\NoteBundle\Controller;
4 4
 
5 5
 use Symfony\Component\Security\Core\Util\ClassUtils;
6
-
7 6
 use FOS\RestBundle\Util\Codes;
8
-
9 7
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
10
-use Symfony\Bundle\FrameworkBundle\Routing\Router;
11 8
 use Symfony\Component\HttpFoundation\Response;
12
-
13 9
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
14 10
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
15
-
16 11
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
17 12
 use Oro\Bundle\EntityBundle\Tools\EntityRoutingHelper;
18 13
 use Oro\Bundle\NoteBundle\Entity\Note;
Please login to merge, or discard this patch.
src/Oro/Bundle/NoteBundle/Model/ExtendNote.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -47,7 +47,7 @@
 block discarded – undo
47 47
      *
48 48
      * @param object $target Any configurable entity that can have notes
49 49
      *
50
-     * @return object This object
50
+     * @return ExtendNote This object
51 51
      */
52 52
     public function setTarget($target)
53 53
     {
Please login to merge, or discard this patch.
Oro/Bundle/NotificationBundle/Processor/AbstractNotificationProcessor.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
      * Checks if command is already queued.
63 63
      *
64 64
      * @param string $command
65
-     * @return Job
65
+     * @return boolean
66 66
      */
67 67
     protected function hasNotFinishedJob($command)
68 68
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/NotificationBundle/Provider/NotificationManager.php 2 patches
Doc Comments   +4 added lines, -1 removed lines patch added patch discarded remove patch
@@ -31,6 +31,9 @@  discard block
 block discarded – undo
31 31
      */
32 32
     protected $notificationRules;
33 33
 
34
+    /**
35
+     * @param string $className
36
+     */
34 37
     public function __construct(ObjectManager $em, $className)
35 38
     {
36 39
         $this->handlers = array();
@@ -92,7 +95,7 @@  discard block
 block discarded – undo
92 95
      *
93 96
      * @param string $entityName
94 97
      * @param string $eventName
95
-     * @return \Doctrine\Common\Collections\Collection|ArrayCollection
98
+     * @return \Doctrine\Common\Collections\ArrayCollection
96 99
      */
97 100
     protected function getRulesByCriteria($entityName, $eventName)
98 101
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Oro/Bundle/NotificationBundle/Tests/Selenium/TransactionEmailsAclTest.php 1 patch
Doc Comments   +16 added lines patch added patch discarded remove patch
@@ -117,6 +117,10 @@  discard block
 block discarded – undo
117 117
         }
118 118
     }
119 119
 
120
+    /**
121
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
122
+     * @param string $roleName
123
+     */
120 124
     public function deleteAcl($login, $roleName, $username, $email)
121 125
     {
122 126
         $login->openRoles('Oro\Bundle\UserBundle')
@@ -132,6 +136,10 @@  discard block
 block discarded – undo
132 136
             ->checkContextMenu($email, 'Delete');
133 137
     }
134 138
 
139
+    /**
140
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
141
+     * @param string $roleName
142
+     */
135 143
     public function updateAcl($login, $roleName, $username, $email)
136 144
     {
137 145
         $login->openRoles('Oro\Bundle\UserBundle')
@@ -147,6 +155,10 @@  discard block
 block discarded – undo
147 155
             ->checkContextMenu($email, 'Edit');
148 156
     }
149 157
 
158
+    /**
159
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
160
+     * @param string $roleName
161
+     */
150 162
     public function createAcl($login, $roleName, $username)
151 163
     {
152 164
         $login->openRoles('Oro\Bundle\UserBundle')
@@ -165,6 +177,10 @@  discard block
 block discarded – undo
165 177
             );
166 178
     }
167 179
 
180
+    /**
181
+     * @param \Oro\Bundle\UserBundle\Tests\Selenium\Pages\Login $login
182
+     * @param string $roleName
183
+     */
168 184
     public function viewListAcl($login, $roleName, $username)
169 185
     {
170 186
         $login->openRoles('Oro\Bundle\UserBundle')
Please login to merge, or discard this patch.
src/Oro/Bundle/OrganizationBundle/Controller/BusinessUnitController.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,13 +3,10 @@
 block discarded – undo
3 3
 namespace Oro\Bundle\OrganizationBundle\Controller;
4 4
 
5 5
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
6
-use Symfony\Component\HttpFoundation\JsonResponse;
7 6
 use Symfony\Component\HttpFoundation\Request;
8 7
 use Symfony\Component\HttpFoundation\Response;
9
-
10 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
11 9
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
12
-
13 10
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
14 11
 use Oro\Bundle\SecurityBundle\Annotation\Acl;
15 12
 use Oro\Bundle\SecurityBundle\Annotation\AclAncestor;
Please login to merge, or discard this patch.
src/Oro/Bundle/OrganizationBundle/Entity/Manager/OrganizationManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -63,7 +63,7 @@
 block discarded – undo
63 63
      * @param User   $user
64 64
      * @param string $name
65 65
      *
66
-     * @return null|Organization
66
+     * @return Organization[]
67 67
      */
68 68
     public function getEnabledUserOrganizationByName(User $user, $name)
69 69
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
Oro/Bundle/OrganizationBundle/Entity/Repository/BusinessUnitRepository.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,7 @@
 block discarded – undo
2 2
 namespace Oro\Bundle\OrganizationBundle\Entity\Repository;
3 3
 
4 4
 use Doctrine\ORM\EntityRepository;
5
-use Doctrine\ORM\Query\Expr;
6 5
 use Doctrine\ORM\QueryBuilder;
7
-
8 6
 use Oro\Bundle\OrganizationBundle\Entity\BusinessUnit;
9 7
 use Oro\Bundle\OrganizationBundle\Entity\Organization;
10 8
 use Oro\Bundle\UserBundle\Entity\User;
Please login to merge, or discard this patch.