Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/NavigationBundle/Entity/Repository/PinbarTabRepository.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -52,7 +52,7 @@
 block discarded – undo
52 52
     /**
53 53
      * Increment positions of Pinbar tabs for specified user
54 54
      *
55
-     * @param User|integer $user
55
+     * @param User $user
56 56
      * @param int          $navigationItemId
57 57
      * @param Organization $organization
58 58
      *
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Entity/Title.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -146,7 +146,7 @@
 block discarded – undo
146 146
     /**
147 147
      * Returns is title not changed in db
148 148
      *
149
-     * @return bool
149
+     * @return string
150 150
      */
151 151
     public function getIsSystem()
152 152
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Menu/BreadcrumbManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -147,7 +147,7 @@
 block discarded – undo
147 147
      * Match routes
148 148
      *
149 149
      * @param array $routes
150
-     * @param $route
150
+     * @param string $route
151 151
      * @return bool
152 152
      */
153 153
     protected function match(array $routes, $route)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Provider/TitleService.php 2 patches
Doc Comments   +2 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
      * @param string $suffix
143 143
      * @param bool   $isJSON
144 144
      * @param bool   $isShort
145
-     * @return $this
145
+     * @return string
146 146
      */
147 147
     public function render(
148 148
         $params = [],
@@ -454,6 +454,7 @@  discard block
 block discarded – undo
454 454
      *
455 455
      * @param $title
456 456
      * @param $route
457
+     * @return string
457 458
      */
458 459
     protected function getShortTitle($title, $route)
459 460
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
Bundle/NavigationBundle/Tests/Unit/Event/ResponseHistoryListenerTest.php 2 patches
Doc Comments   +6 added lines, -3 removed lines patch added patch discarded remove patch
@@ -158,7 +158,7 @@  discard block
 block discarded – undo
158 158
      * @param null|\Symfony\Component\HttpFoundation\Response $response
159 159
      * @param string                                          $type
160 160
      *
161
-     * @return mixed
161
+     * @return \Symfony\Component\HttpKernel\Event\FilterResponseEvent
162 162
      */
163 163
     private function getEventMock($request, $response, $type = 'Symfony\Component\HttpKernel\Event\FilterResponseEvent')
164 164
     {
@@ -214,7 +214,7 @@  discard block
 block discarded – undo
214 214
     /**
215 215
      * Creates response object mock
216 216
      *
217
-     * @return \PHPUnit_Framework_MockObject_MockObject
217
+     * @return null|\Symfony\Component\HttpFoundation\Response
218 218
      */
219 219
     private function getResponse()
220 220
     {
@@ -227,6 +227,9 @@  discard block
 block discarded – undo
227 227
         return $response;
228 228
     }
229 229
 
230
+    /**
231
+     * @return \Oro\Bundle\NavigationBundle\Provider\TitleServiceInterface
232
+     */
230 233
     public function getTitleService()
231 234
     {
232 235
 
@@ -311,7 +314,7 @@  discard block
 block discarded – undo
311 314
     /**
312 315
      * Prepare repository mock
313 316
      *
314
-     * @param  mixed $returnValue
317
+     * @param  \PHPUnit_Framework_MockObject_MockObject|null $returnValue
315 318
      *
316 319
      * @return \PHPUnit_Framework_MockObject_MockObject
317 320
      */
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Tests/Unit/Menu/BreadcrumbManagerTest.php 1 patch
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,9 +2,7 @@
 block discarded – undo
2 2
 namespace Oro\Bundle\NavigationBundle\Tests\Unit\Menu;
3 3
 
4 4
 use Oro\Bundle\NavigationBundle\Menu\BreadcrumbManager;
5
-
6 5
 use Knp\Menu\MenuItem;
7
-use Oro\Bundle\NavigationBundle\Menu\ConfigurationBuilder;
8 6
 use Oro\Bundle\NavigationBundle\Provider\BuilderChainProvider;
9 7
 
10 8
 class BreadcrumbManagerTest extends \PHPUnit_Framework_TestCase
Please login to merge, or discard this patch.
Oro/Bundle/NavigationBundle/Tests/Unit/Menu/ChainBreadcrumbManagerTest.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -42,7 +42,7 @@
 block discarded – undo
42 42
     }
43 43
 
44 44
     /**
45
-     * @return \PHPUnit_Framework_MockObject_MockObject|BreadcrumbManagerInterface
45
+     * @return BreadcrumbManagerInterface
46 46
      */
47 47
     protected function getManagerMock()
48 48
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Title/TitleReader/AnnotationsReader.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -137,7 +137,7 @@
 block discarded – undo
137 137
     }
138 138
 
139 139
     /**
140
-     * @param       $filePattern
140
+     * @param       string $filePattern
141 141
      * @param array $dirs
142 142
      *
143 143
      * @return array
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Twig/MenuExtension.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
     /**
121 121
      * Get menu filtered by isAllowed children.
122 122
      *
123
-     * @param ItemInterface|array $menu
123
+     * @param ItemInterface $menu
124 124
      * @return ItemInterface|array
125 125
      */
126 126
     protected function filterUnallowedItems($menu)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.