Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/LayoutBundle/Layout/Form/FormLayoutBuilder.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -143,7 +143,7 @@
 block discarded – undo
143 143
      *
144 144
      * @param string $fieldPath
145 145
      *
146
-     * @return string|null
146
+     * @return string
147 147
      */
148 148
     protected function getParentFieldPath($fieldPath)
149 149
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,9 +4,7 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\EventManager;
6 6
 use Doctrine\DBAL\Driver\Connection;
7
-
8 7
 use Symfony\Component\Filesystem\Filesystem;
9
-
10 8
 use Oro\Component\TestUtils\ORM\Mocks\DriverMock;
11 9
 use Oro\Component\TestUtils\ORM\Mocks\EntityManagerMock;
12 10
 
Please login to merge, or discard this patch.
src/Oro/Bundle/LayoutBundle/Layout/Form/GroupingFormLayoutBuilder.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -2,10 +2,7 @@
 block discarded – undo
2 2
 
3 3
 namespace Oro\Bundle\LayoutBundle\Layout\Form;
4 4
 
5
-use Symfony\Component\Form\FormInterface;
6
-
7 5
 use Oro\Component\Layout\BlockBuilderInterface;
8
-
9 6
 use Oro\Bundle\LayoutBundle\Layout\Block\Type\FieldsetType;
10 7
 
11 8
 class GroupingFormLayoutBuilder extends FormLayoutBuilder
Please login to merge, or discard this patch.
src/Oro/Bundle/LocaleBundle/DoctrineExtensions/DBAL/Types/UTCTimeType.php 1 patch
Doc Comments   +2 added lines patch added patch discarded remove patch
@@ -13,6 +13,7 @@  discard block
 block discarded – undo
13 13
 
14 14
     /**
15 15
      * {@inheritdoc}
16
+     * @param \DateTime $value
16 17
      */
17 18
     public function convertToDatabaseValue($value, AbstractPlatform $platform)
18 19
     {
@@ -28,6 +29,7 @@  discard block
 block discarded – undo
28 29
 
29 30
     /**
30 31
      * {@inheritdoc}
32
+     * @param string $value
31 33
      */
32 34
     public function convertToPHPValue($value, AbstractPlatform $platform)
33 35
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/LocaleBundle/Formatter/AddressFormatter.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -152,9 +152,9 @@
 block discarded – undo
152 152
     }
153 153
 
154 154
     /**
155
-     * @param object $obj
155
+     * @param AddressInterface $obj
156 156
      * @param string $property
157
-     * @return mixed|null
157
+     * @return string
158 158
      */
159 159
     protected function getValue($obj, $property)
160 160
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/LocaleBundle/Formatter/NumberFormatter.php 1 patch
Doc Comments   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -272,7 +272,7 @@  discard block
 block discarded – undo
272 272
      * @param int|string $attribute Numeric attribute constant of \NumberFormatter or it's string name
273 273
      * @param int|string $style Constant of \NumberFormatter (DECIMAL, CURRENCY, PERCENT, etc) or string name
274 274
      * @param string|null $locale
275
-     * @return bool|int
275
+     * @return integer
276 276
      */
277 277
     public function getAttribute($attribute, $style = null, $locale = null)
278 278
     {
@@ -298,7 +298,7 @@  discard block
 block discarded – undo
298 298
      * @param int|string $attribute Text attribute constant of \NumberFormatter or it's string name
299 299
      * @param int|string $style Constant of \NumberFormatter (DECIMAL, CURRENCY, PERCENT, etc) or string name
300 300
      * @param string|null $locale
301
-     * @return bool|int
301
+     * @return string
302 302
      */
303 303
     public function getTextAttribute($attribute, $style, $locale = null)
304 304
     {
@@ -335,7 +335,7 @@  discard block
 block discarded – undo
335 335
      * @param int|string $symbol Format symbol constant of \NumberFormatter or it's string name
336 336
      * @param int|string $style Constant of \NumberFormatter (DECIMAL, CURRENCY, PERCENT, etc) or string name
337 337
      * @param string|null $locale
338
-     * @return bool|int
338
+     * @return string
339 339
      */
340 340
     public function getSymbol($symbol, $style, $locale = null)
341 341
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/LocaleBundle/Model/LocaleSettings.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -440,10 +440,10 @@
 block discarded – undo
440 440
     }
441 441
 
442 442
     /**
443
-     * @param array  $codes
443
+     * @param string[]  $codes
444 444
      * @param string $locale
445 445
      *
446
-     * @return array
446
+     * @return string[]
447 447
      */
448 448
     public function getLocalesByCodes(array $codes, $locale = 'en')
449 449
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/MigrationBundle/Command/LoadDataFixturesCommand.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -7,11 +7,8 @@
 block discarded – undo
7 7
 use Symfony\Component\Console\Input\InputOption;
8 8
 use Symfony\Component\Console\Output\OutputInterface;
9 9
 use Symfony\Component\HttpKernel\Bundle\BundleInterface;
10
-
11 10
 use Doctrine\Common\DataFixtures\Executor\ORMExecutor;
12
-
13 11
 use Oro\Bundle\MigrationBundle\Migration\Loader\DataFixturesLoader;
14
-use Oro\Bundle\SearchBundle\EventListener\OrmIndexListener;
15 12
 
16 13
 class LoadDataFixturesCommand extends ContainerAwareCommand
17 14
 {
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/Controller/ShortcutController.php 1 patch
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -4,16 +4,12 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\Translation\TranslatorInterface;
6 6
 use Symfony\Bundle\FrameworkBundle\Controller\Controller;
7
-
8 7
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Route;
9 8
 use Sensio\Bundle\FrameworkExtraBundle\Configuration\Template;
10
-
11 9
 use Knp\Menu\Iterator\RecursiveItemIterator;
12 10
 use Knp\Menu\ItemInterface;
13 11
 use Knp\Menu\MenuItem;
14
-
15 12
 use Oro\Bundle\NavigationBundle\Provider\BuilderChainProvider;
16
-use Oro\Bundle\SecurityBundle\Annotation\Acl;
17 13
 
18 14
 /**
19 15
  * @Route("/shortcut")
Please login to merge, or discard this patch.
src/Oro/Bundle/NavigationBundle/DependencyInjection/Configuration.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -39,7 +39,7 @@
 block discarded – undo
39 39
     /**
40 40
      * Add children nodes to menu
41 41
      *
42
-     * @param $node NodeBuilder
42
+     * @param NodeBuilder $node NodeBuilder
43 43
      * @return Configuration
44 44
      *
45 45
      * @SuppressWarnings(PHPMD.ExcessiveMethodLength)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.