Completed
Pull Request — master (#361)
by Ramūnas
37:16
created
src/Oro/Bundle/ImapBundle/Entity/UserEmailOrigin.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -135,7 +135,7 @@  discard block
 block discarded – undo
135 135
     /**
136 136
      * Gets the port of SMTP server
137 137
      *
138
-     * @return int
138
+     * @return string
139 139
      */
140 140
     public function getSmtpPort()
141 141
     {
@@ -159,7 +159,7 @@  discard block
 block discarded – undo
159 159
     /**
160 160
      * Gets the port of IMAP server
161 161
      *
162
-     * @return int
162
+     * @return string
163 163
      */
164 164
     public function getImapPort()
165 165
     {
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/EventListener/UserEmailOriginListener.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -60,7 +60,7 @@
 block discarded – undo
60 60
     }
61 61
 
62 62
     /**
63
-     * @param ArrayCollection|EmailFolder[] $folders
63
+     * @param ArrayCollection $folders
64 64
      * @param ImapEmailFolderManager $manager
65 65
      */
66 66
     protected function createImapEmailFolders($folders, ImapEmailFolderManager $manager)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Manager/ImapEmailFolderManager.php 2 patches
Doc Comments   +8 added lines, -7 removed lines patch added patch discarded remove patch
@@ -50,7 +50,7 @@  discard block
 block discarded – undo
50 50
     }
51 51
 
52 52
     /**
53
-     * @return EmailFolder[]
53
+     * @return ArrayCollection
54 54
      */
55 55
     public function getFolders()
56 56
     {
@@ -118,9 +118,9 @@  discard block
 block discarded – undo
118 118
     }
119 119
 
120 120
     /**
121
-     * @param Folder[]|ArrayCollection $srcFolders
121
+     * @param Folder[] $srcFolders
122 122
      *
123
-     * @return EmailFolderModel[]
123
+     * @return ArrayCollection
124 124
      */
125 125
     protected function processFolders(array $srcFolders)
126 126
     {
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
     }
156 156
 
157 157
     /**
158
-     * @param EmailFolderModel[]|ArrayCollection $syncedFolderModels
159
-     * @param ImapEmailFolder[]|ArrayCollection $existingImapFolders
158
+     * @param ArrayCollection $syncedFolderModels
159
+     * @param ArrayCollection $existingImapFolders
160 160
      *
161 161
      * @return EmailFolderModel[]
162 162
      */
@@ -202,6 +202,7 @@  discard block
 block discarded – undo
202 202
 
203 203
     /**
204 204
      * @param Folder $srcFolder
205
+     * @param integer $uidValidity
205 206
      *
206 207
      * @return EmailFolderModel
207 208
      */
@@ -243,7 +244,7 @@  discard block
 block discarded – undo
243 244
     /**
244 245
      * @param EmailFolderModel[]|ArrayCollection $emailFolderModels
245 246
      *
246
-     * @return EmailFolder[]|ArrayCollection
247
+     * @return ArrayCollection
247 248
      */
248 249
     protected function extractEmailFolders($emailFolderModels)
249 250
     {
@@ -263,7 +264,7 @@  discard block
 block discarded – undo
263 264
     }
264 265
 
265 266
     /**
266
-     * @return ImapEmailFolder[]|ArrayCollection
267
+     * @return ArrayCollection
267 268
      */
268 269
     protected function getExistingFolders()
269 270
     {
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,9 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityManager;
7
-
8
-use Zend\Mail\Storage\Exception as MailException;
9
-
10 7
 use Oro\Bundle\EmailBundle\Entity\EmailFolder;
11 8
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
12 9
 use Oro\Bundle\ImapBundle\Connector\ImapConnector;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Manager/ImapEmailManager.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -295,7 +295,7 @@
 block discarded – undo
295 295
 
296 296
     /**
297 297
      * @param Headers $headers
298
-     * @param $name
298
+     * @param string $name
299 299
      * @return array|null
300 300
      */
301 301
     protected function getMultiMessageId(Headers $headers, $name)
Please login to merge, or discard this patch.
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,16 +4,13 @@
 block discarded – undo
4 4
 
5 5
 use Oro\Bundle\WorkflowBundle\Model\ContextAccessor;
6 6
 use Symfony\Component\Form\Test\FormIntegrationTestCase;
7
-
8 7
 use Oro\Bundle\WorkflowBundle\Form\EventListener\DefaultValuesListener;
9 8
 use Oro\Bundle\WorkflowBundle\Form\EventListener\InitActionsListener;
10 9
 use Oro\Bundle\WorkflowBundle\Form\EventListener\RequiredAttributesListener;
11 10
 use Oro\Bundle\WorkflowBundle\Form\Type\WorkflowAttributesType;
12
-
13 11
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowItem;
14 12
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowStep;
15 13
 use Oro\Bundle\WorkflowBundle\Entity\WorkflowDefinition;
16
-
17 14
 use Oro\Bundle\WorkflowBundle\Model\Step;
18 15
 use Oro\Bundle\WorkflowBundle\Model\Attribute;
19 16
 use Oro\Bundle\WorkflowBundle\Model\WorkflowData;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImapBundle/Sync/ImapEmailSynchronizationProcessor.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -456,7 +456,7 @@
 block discarded – undo
456 456
      * Check allowing to save email by uid
457 457
      *
458 458
      * @param Email $email
459
-     * @param array $existingUids
459
+     * @param integer[] $existingUids
460 460
      *
461 461
      * @return bool
462 462
      */
Please login to merge, or discard this patch.
Unused Use Statements   -4 removed lines patch added patch discarded remove patch
@@ -5,8 +5,6 @@  discard block
 block discarded – undo
5 5
 use Doctrine\Common\Collections\ArrayCollection;
6 6
 use Doctrine\ORM\EntityManager;
7 7
 use Doctrine\ORM\Query;
8
-
9
-
10 8
 use Oro\Bundle\EmailBundle\Entity\Mailbox;
11 9
 use Oro\Bundle\EmailBundle\Model\FolderType;
12 10
 use Oro\Bundle\EmailBundle\Builder\EmailEntityBuilder;
@@ -15,7 +13,6 @@  discard block
 block discarded – undo
15 13
 use Oro\Bundle\EmailBundle\Entity\EmailOrigin;
16 14
 use Oro\Bundle\EmailBundle\Sync\AbstractEmailSynchronizationProcessor;
17 15
 use Oro\Bundle\EmailBundle\Sync\KnownEmailAddressCheckerInterface;
18
-
19 16
 use Oro\Bundle\ImapBundle\Entity\ImapEmail;
20 17
 use Oro\Bundle\ImapBundle\Entity\ImapEmailFolder;
21 18
 use Oro\Bundle\ImapBundle\Entity\Repository\ImapEmailFolderRepository;
@@ -23,7 +20,6 @@  discard block
 block discarded – undo
23 20
 use Oro\Bundle\ImapBundle\Mail\Storage\Exception\UnsupportException;
24 21
 use Oro\Bundle\ImapBundle\Mail\Storage\Exception\UnselectableFolderException;
25 22
 use Oro\Bundle\ImapBundle\Mail\Storage\Folder;
26
-use Oro\Bundle\ImapBundle\Mail\Storage\Imap;
27 23
 use Oro\Bundle\ImapBundle\Manager\ImapEmailIterator;
28 24
 use Oro\Bundle\ImapBundle\Manager\ImapEmailManager;
29 25
 use Oro\Bundle\ImapBundle\Manager\DTO\Email;
Please login to merge, or discard this patch.
DependencyInjection/Compiler/ProcessorRegistryCompilerPass.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -74,7 +74,7 @@
 block discarded – undo
74 74
      * @param string $serviceId
75 75
      * @param string $tagName
76 76
      * @param array $tagAttributes
77
-     * @param array $requiredAttributes
77
+     * @param string[] $requiredAttributes
78 78
      * @throws LogicException
79 79
      */
80 80
     private function assertTagHasAttributes($serviceId, $tagName, array $tagAttributes, array $requiredAttributes)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@
 block discarded – undo
4 4
 
5 5
 use Symfony\Component\DependencyInjection\ContainerBuilder;
6 6
 use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
7
-use Symfony\Component\DependencyInjection\Definition;
8 7
 use Symfony\Component\DependencyInjection\Reference;
9 8
 use Symfony\Component\DependencyInjection\Exception\LogicException;
10 9
 
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Field/DatabaseHelper.php 2 patches
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@  discard block
 block discarded – undo
142 142
     }
143 143
 
144 144
     /**
145
-     * @param object $entity
145
+     * @param \stdClass $entity
146 146
      * @return object
147 147
      */
148 148
     public function getEntityReference($entity)
@@ -287,7 +287,7 @@  discard block
 block discarded – undo
287 287
     /**
288 288
      * We should limit data with current organization
289 289
      *
290
-     * @param $entityName
290
+     * @param string $entityName
291 291
      * @return bool
292 292
      */
293 293
     protected function shouldBeAddedOrganizationLimits($entityName)
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Formatter/ExcelDateTimeTypeFormatter.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -96,6 +96,9 @@
 block discarded – undo
96 96
 
97 97
     /**
98 98
      * {@inheritdoc}
99
+     * @param integer $dateType
100
+     * @param integer $timeType
101
+     * @param string $locale
99 102
      */
100 103
     public function getPattern($dateType, $timeType, $locale = null)
101 104
     {
Please login to merge, or discard this patch.
src/Oro/Bundle/ImportExportBundle/Handler/AbstractImportHandler.php 2 patches
Doc Comments   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -132,10 +132,10 @@
 block discarded – undo
132 132
     }
133 133
 
134 134
     /**
135
-     * @param $jobName
136
-     * @param $processorAlias
137
-     * @param $inputFormat
138
-     * @param $inputFilePrefix
135
+     * @param string $jobName
136
+     * @param string $processorAlias
137
+     * @param string $inputFormat
138
+     * @param string $inputFilePrefix
139 139
      * @param array $options
140 140
      * @param $entityName
141 141
      * @return JobResult
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -3,7 +3,6 @@
 block discarded – undo
3 3
 namespace Oro\Component\PropertyAccess\Tests\Unit;
4 4
 
5 5
 use Symfony\Component\PropertyAccess\Exception\NoSuchPropertyException;
6
-
7 6
 use Oro\Component\PropertyAccess\PropertyAccessor;
8 7
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClass;
9 8
 use Oro\Component\PropertyAccess\Tests\Unit\Fixtures\TestClassMagicCall;
Please login to merge, or discard this patch.